commits May 2013

commits@lists.open-mesh.org

1 participants
91 discussions

[openwrt-feed-batman-adv] master: batman-adv-devel: Use section garbage collection to reduce binary size (3e056f3)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/openwrt-feed-batman-adv On branch : master >--------------------------------------------------------------- commit 3e056f38754cd39678a1fe16ef5a86b6fd0818dc Author: Sven Eckelmann <sven(a)narfation.org> Date: Tue May 7 14:51:08 2013 +0200 batman-adv-devel: Use section garbage collection to reduce binary size The linker can identify unused sections of a binary when each symbol is stored in a separate section. This mostly removes unused linker sections and reduces the size by ~3% on mipsel. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 3e056f38754cd39678a1fe16ef5a86b6fd0818dc batman-adv-devel/Makefile | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile index 69dfdc7..79b4294 100644 --- a/batman-adv-devel/Makefile +++ b/batman-adv-devel/Makefile @@ -64,6 +64,13 @@ MAKE_BATMAN_ADV_ARGS += \ CONFIG_BATMAN_ADV_NC=$(if $(CONFIG_KMOD_BATMAN_ADV_DEVEL_NC),y,n) \ REVISION="$(PKG_BATMAN_SHORTREV)" all +# The linker can identify unused sections of a binary when each symbol is stored +# in a separate section. This mostly removes unused linker sections and reduces +# the size by ~3% on mipsel. + +TARGET_CFLAGS += -ffunction-sections -fdata-sections +TARGET_LDFLAGS += -Wl,--gc-sections + MAKE_BATCTL_ENV += \ CPPFLAGS="$(TARGET_CPPFLAGS)" \ CFLAGS="$(TARGET_CFLAGS)" \

1 0

[openwrt-feed-batman-adv] master: batman-adv-devel: Enable Link-time optimization (e25de79)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/openwrt-feed-batman-adv On branch : master >--------------------------------------------------------------- commit e25de79760c368b03e641bd7bc90ef3cf6294320 Author: Sven Eckelmann <sven(a)narfation.org> Date: Tue May 7 14:51:09 2013 +0200 batman-adv-devel: Enable Link-time optimization Link-time optimization allows to move parts of the optimization from the single source file to the global source view. This is done by emitting the GIMPLE representation in each object file and analyzing it again during the link step. This reduces the binary size by around 6% on mipsel (this includes parts which were also removed by garbage collection). Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- e25de79760c368b03e641bd7bc90ef3cf6294320 batman-adv-devel/Makefile | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile index 79b4294..12749be 100644 --- a/batman-adv-devel/Makefile +++ b/batman-adv-devel/Makefile @@ -71,6 +71,13 @@ MAKE_BATMAN_ADV_ARGS += \ TARGET_CFLAGS += -ffunction-sections -fdata-sections TARGET_LDFLAGS += -Wl,--gc-sections +# Link-time optimization allows to move parts of the optimization from the single +# source file to the global source view. This is done by emitting the GIMPLE +# representation in each object file and analyzing it again during the link step. + +TARGET_CFLAGS += -flto +TARGET_LDFLAGS += -fuse-linker-plugin + MAKE_BATCTL_ENV += \ CPPFLAGS="$(TARGET_CPPFLAGS)" \ CFLAGS="$(TARGET_CFLAGS)" \

1 0

[openwrt-feed-batman-adv] master: batman-adv-devel: Remove unused parameters from MAKE_BATCTL_ARGS (ffa6898)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/openwrt-feed-batman-adv On branch : master >--------------------------------------------------------------- commit ffa689894b56da1da3db1a8aa2a2f41f126308b1 Author: Sven Eckelmann <sven(a)narfation.org> Date: Wed May 8 09:21:26 2013 +0200 batman-adv-devel: Remove unused parameters from MAKE_BATCTL_ARGS The NODEBUG, UNAME and STRIP parameter aren't used in batctl's Makefile. Removing them should be safe. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- ffa689894b56da1da3db1a8aa2a2f41f126308b1 batman-adv-devel/Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile index 0250701..69dfdc7 100644 --- a/batman-adv-devel/Makefile +++ b/batman-adv-devel/Makefile @@ -72,10 +72,7 @@ MAKE_BATCTL_ENV += \ MAKE_BATCTL_ARGS += \ REVISION="$(PKG_BATCTL_SHORTREV)" \ CC="$(TARGET_CC)" \ - NODEBUG=1 \ - UNAME="Linux" \ DESTDIR="$(PKG_INSTALL_DIR)" \ - STRIP="/bin/true" \ batctl install ifneq ($(DEVELOPER)$(CONFIG_KMOD_BATMAN_ADV_DEVEL_BATCTL),)

1 0

[openwrt-feed-batman-adv] master: batman-adv-devel: Don't overwrite batctl's CFLAGS (110ca73)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/openwrt-feed-batman-adv On branch : master >--------------------------------------------------------------- commit 110ca7339b01c3349548110e14c9c783a05adab0 Author: Sven Eckelmann <sven(a)narfation.org> Date: Wed May 8 09:21:25 2013 +0200 batman-adv-devel: Don't overwrite batctl's CFLAGS The batctl makefile has CFLAGS which change the behavior of the compiler. This includes important things like the C-dialect used or whether the compiler can ignore aliasing problems during the optimization step. The OpenWRT build environment should not overwrite these settings without a good reason. Most of these reasons can probably directly be fixed upstream. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 110ca7339b01c3349548110e14c9c783a05adab0 batman-adv-devel/Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile index db93ac7..0250701 100644 --- a/batman-adv-devel/Makefile +++ b/batman-adv-devel/Makefile @@ -70,9 +70,6 @@ MAKE_BATCTL_ENV += \ LDFLAGS="$(TARGET_LDFLAGS)" MAKE_BATCTL_ARGS += \ - CFLAGS="$(TARGET_CFLAGS)" \ - CCFLAGS="$(TARGET_CFLAGS)" \ - OFLAGS="$(TARGET_CFLAGS)" \ REVISION="$(PKG_BATCTL_SHORTREV)" \ CC="$(TARGET_CC)" \ NODEBUG=1 \

1 0

[openwrt-feed-batman-adv] master: batman-adv-devel: Add missing TARGET_* flags to batctl compile (f41a85c)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/openwrt-feed-batman-adv On branch : master >--------------------------------------------------------------- commit f41a85c9984dcffea1737ccf85c47335350df4f3 Author: Sven Eckelmann <sven(a)narfation.org> Date: Tue May 7 14:51:07 2013 +0200 batman-adv-devel: Add missing TARGET_* flags to batctl compile The compilation step of batctl completely dropped the TARGET_CFLAGS, TARGET_CPPFLAGS and TARGET_LDFLAGS and therefore weren't compiled and linked with the flags given by the OpenWRT build environment. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> >--------------------------------------------------------------- f41a85c9984dcffea1737ccf85c47335350df4f3 batman-adv-devel/Makefile | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile index 0958f38..db93ac7 100644 --- a/batman-adv-devel/Makefile +++ b/batman-adv-devel/Makefile @@ -64,6 +64,11 @@ MAKE_BATMAN_ADV_ARGS += \ CONFIG_BATMAN_ADV_NC=$(if $(CONFIG_KMOD_BATMAN_ADV_DEVEL_NC),y,n) \ REVISION="$(PKG_BATMAN_SHORTREV)" all +MAKE_BATCTL_ENV += \ + CPPFLAGS="$(TARGET_CPPFLAGS)" \ + CFLAGS="$(TARGET_CFLAGS)" \ + LDFLAGS="$(TARGET_LDFLAGS)" + MAKE_BATCTL_ARGS += \ CFLAGS="$(TARGET_CFLAGS)" \ CCFLAGS="$(TARGET_CFLAGS)" \ @@ -85,7 +90,7 @@ $(eval $(call Download,batctl)) BATCTL_EXTRACT = tar xzf "$(DL_DIR)/$(PKG_BATCTL_FNAME)" -C "$(BUILD_DIR)/$(PKG_NAME)" BATCTL_PATCH = $(call Build/DoPatch,"$(PKG_BATCTL_BUILD_DIR)","$(PATCH_DIR)","*batctl*") -BATCTL_BUILD = $(MAKE) -C $(PKG_BATCTL_BUILD_DIR) $(MAKE_BATCTL_ARGS) +BATCTL_BUILD = $(MAKE_BATCTL_ENV) $(MAKE) -C $(PKG_BATCTL_BUILD_DIR) $(MAKE_BATCTL_ARGS) BATCTL_INSTALL = $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/local/sbin/batctl $(1)/usr/sbin/ endif

1 0

[batman-adv] master: batman-adv: don't use call_rcu if not needed (1bd8161)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/batman-adv On branch : master >--------------------------------------------------------------- commit 1bd816198771e2cbd44948a12aaca3ac33993d9d Author: Antonio Quartulli <ordex(a)autistici.org> Date: Tue May 7 00:29:22 2013 +0200 batman-adv: don't use call_rcu if not needed batadv_tt_global_entry_free_ref uses call_rcu to schedule a function which will only free the global entry itself. For this reason call_rcu is useless and kfree_rcu can be used to simplify the code. Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> >--------------------------------------------------------------- 1bd816198771e2cbd44948a12aaca3ac33993d9d compat.c | 9 +++++++++ translation-table.c | 20 ++++++-------------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/compat.c b/compat.c index 1f3a39d..da556a4 100644 --- a/compat.c +++ b/compat.c @@ -27,6 +27,15 @@ #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 0, 0) +void batadv_free_rcu_tt_global_entry(struct rcu_head *rcu) +{ + struct batadv_tt_global_entry *global; + + global = container_of(rcu, struct batadv_tt_global_entry, common.rcu); + + kfree(global); +} + void batadv_free_rcu_gw_node(struct rcu_head *rcu) { struct batadv_gw_node *gw_node; diff --git a/translation-table.c b/translation-table.c index df6b5cd..44e7789 100644 --- a/translation-table.c +++ b/translation-table.c @@ -117,25 +117,17 @@ batadv_tt_local_entry_free_ref(struct batadv_tt_local_entry *tt_local_entry) kfree_rcu(tt_local_entry, common.rcu); } -static void batadv_tt_global_entry_free_rcu(struct rcu_head *rcu) -{ - struct batadv_tt_common_entry *tt_common_entry; - struct batadv_tt_global_entry *tt_global_entry; - - tt_common_entry = container_of(rcu, struct batadv_tt_common_entry, rcu); - tt_global_entry = container_of(tt_common_entry, - struct batadv_tt_global_entry, common); - - kfree(tt_global_entry); -} - +/** + * batadv_tt_global_entry_free_ref - decrement the refcounter for a + * tt_global_entry and possibly free it + * @tt_global_entry: the object to free + */ static void batadv_tt_global_entry_free_ref(struct batadv_tt_global_entry *tt_global_entry) { if (atomic_dec_and_test(&tt_global_entry->common.refcount)) { batadv_tt_global_del_orig_list(tt_global_entry); - call_rcu(&tt_global_entry->common.rcu, - batadv_tt_global_entry_free_rcu); + kfree_rcu(tt_global_entry, common.rcu); } }

1 0

[batman-adv] master: Merge branch 'next' (8c77610)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/batman-adv On branch : master >--------------------------------------------------------------- commit 8c77610f60b6071849d7a3555989e47fdf5da71d Merge: 4b1dc4a 64fc7ed Author: Marek Lindner <lindner_marek(a)yahoo.de> Date: Sun May 12 14:48:29 2013 +0800 Merge branch 'next' >--------------------------------------------------------------- 8c77610f60b6071849d7a3555989e47fdf5da71d bridge_loop_avoidance.c | 2 +- main.h | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)

1 0

[batman-adv] master's head updated: Merge branch 'next' (8c77610)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/batman-adv Branch 'master' now includes: 78c836c batman-adv: use VLAN_VID_MASK when printing the vid 64fc7ed batman-adv: use VLAN_VID_MASK instead of BATADV_VID_MASK 8c77610 Merge branch 'next'

1 0

[batman-adv] next: batman-adv: use VLAN_VID_MASK instead of BATADV_VID_MASK (64fc7ed)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/batman-adv On branch : next >--------------------------------------------------------------- commit 64fc7ed63afc8b16a5ca3a453c268eeaca3de137 Author: Antonio Quartulli <ordex(a)autistici.org> Date: Thu May 9 18:48:17 2013 +0200 batman-adv: use VLAN_VID_MASK instead of BATADV_VID_MASK VLAN_VID_MASK is already diefined in linux/if_vlan.h and therefore does not need to be privately re-defined Introduced in 0b1da1765fdb00ca5d53bc95c9abc70dfc9aae5b ("batman-adv: change VID semantic in the BLA code") Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> >--------------------------------------------------------------- 64fc7ed63afc8b16a5ca3a453c268eeaca3de137 bridge_loop_avoidance.c | 2 +- main.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index e95cf4b..e9d8e0b 100644 --- a/bridge_loop_avoidance.c +++ b/bridge_loop_avoidance.c @@ -344,7 +344,7 @@ static void batadv_bla_send_claim(struct batadv_priv *bat_priv, uint8_t *mac, if (vid & BATADV_VLAN_HAS_TAG) skb = vlan_insert_tag(skb, htons(ETH_P_8021Q), - vid & BATADV_VID_MASK); + vid & VLAN_VID_MASK); skb_reset_mac_header(skb); skb->protocol = eth_type_trans(skb, soft_iface); diff --git a/main.h b/main.h index 8bcffa5..834b1a0 100644 --- a/main.h +++ b/main.h @@ -172,8 +172,6 @@ enum batadv_vlan_flags { BATADV_VLAN_HAS_TAG = BIT(15), }; -/* mask needed to extract the vlan ID (12bits) from a 16bits variable */ -#define BATADV_VID_MASK 0x0FFF #define BATADV_PRINT_VID(vid) (vid & BATADV_VLAN_HAS_TAG ? \ (int)(vid & VLAN_VID_MASK) : -1)

1 0

[batman-adv] next: batman-adv: use VLAN_VID_MASK when printing the vid (78c836c)
by postmaster＠open-mesh.org 12 May '13

12 May '13

Repository : ssh://git@open-mesh.org/batman-adv On branch : next >--------------------------------------------------------------- commit 78c836cfa6cfb44885118dc4310456ffdd87f915 Author: Antonio Quartulli <ordex(a)autistici.org> Date: Thu May 9 18:48:16 2013 +0200 batman-adv: use VLAN_VID_MASK when printing the vid Introduced in 454b849c7de18a7b44eecebe889f5f3149d24780 ("batman-adv: print the VID properly") Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> >--------------------------------------------------------------- 78c836cfa6cfb44885118dc4310456ffdd87f915 main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.h b/main.h index d575436..8bcffa5 100644 --- a/main.h +++ b/main.h @@ -175,7 +175,7 @@ enum batadv_vlan_flags { /* mask needed to extract the vlan ID (12bits) from a 16bits variable */ #define BATADV_VID_MASK 0x0FFF #define BATADV_PRINT_VID(vid) (vid & BATADV_VLAN_HAS_TAG ? \ - (int)(vid & BATADV_VID_MASK) : -1) + (int)(vid & VLAN_VID_MASK) : -1) extern char batadv_routing_algo[]; extern struct list_head batadv_hardif_list;

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits May 2013