commits September 2010

commits@lists.open-mesh.org

2 participants
78 discussions

batman-adv; branch, master, updated. v2010.1.0-158-ge704b9c
by postmaster＠open-mesh.net 12 Sep '10

12 Sep '10

The following commit has been merged in the master branch: commit e704b9c52a49d4bc745c730e8e4a9614ed014c54 Author: Marek Lindner <lindner_marek(a)yahoo.de> Date: Sun Sep 12 15:53:02 2010 +0000 batman-adv: removing redundant assignment of skb->dev Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> diff --git a/soft-interface.c b/soft-interface.c index 853bfc8..2a84d3b 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -211,7 +211,7 @@ void interface_rx(struct net_device *soft_iface, skb_pull_rcsum(skb, hdr_size); /* skb_set_mac_header(skb, -sizeof(struct ethhdr));*/ - skb->dev = soft_iface; + /* skb->dev & skb->pkt_type are set here */ skb->protocol = eth_type_trans(skb, soft_iface); /* should not be neccesary anymore as we use skb_pull_rcsum() @@ -220,9 +220,6 @@ void interface_rx(struct net_device *soft_iface, /* skb->ip_summed = CHECKSUM_UNNECESSARY;*/ - /* TODO: set skb->pkt_type to PACKET_BROADCAST, PACKET_MULTICAST, - * PACKET_OTHERHOST or PACKET_HOST */ - priv->stats.rx_packets++; priv->stats.rx_bytes += skb->len + sizeof(struct ethhdr); -- batman-adv

1 0

batman-adv branch, next, updated. v2010.1.0-25-g3faffe9
by postmaster＠open-mesh.net 07 Sep '10

07 Sep '10

The following commit has been merged in the next branch: commit 3faffe95d0c1221b746fe83bb61a2ad303aab47d Author: Sven Eckelmann <sven.eckelmann(a)gmx.de> Date: Tue Sep 7 11:37:50 2010 +0200 batman-adv: Remove currently unused gw_* datastructures gw_list_lock, gw_list and curr_gw are currently unused members of struct bat_priv. They will be readded when gateway support is really implemented. Signed-off-by: Sven Eckelmann <sven.eckelmann(a)gmx.de> diff --git a/main.c b/main.c index 92ce4f2..c9d3be5 100644 --- a/main.c +++ b/main.c @@ -85,13 +85,11 @@ int mesh_init(struct net_device *soft_iface) spin_lock_init(&bat_priv->forw_bcast_list_lock); spin_lock_init(&bat_priv->hna_lhash_lock); spin_lock_init(&bat_priv->hna_ghash_lock); - spin_lock_init(&bat_priv->gw_list_lock); spin_lock_init(&bat_priv->vis_hash_lock); spin_lock_init(&bat_priv->vis_list_lock); INIT_HLIST_HEAD(&bat_priv->forw_bat_list); INIT_HLIST_HEAD(&bat_priv->forw_bcast_list); - INIT_HLIST_HEAD(&bat_priv->gw_list); if (originator_init(bat_priv) < 1) goto err; diff --git a/types.h b/types.h index e779c4a..9d744d8 100644 --- a/types.h +++ b/types.h @@ -128,7 +128,6 @@ struct bat_priv { struct dentry *debug_dir; struct hlist_head forw_bat_list; struct hlist_head forw_bcast_list; - struct hlist_head gw_list; struct list_head vis_send_list; struct hashtable_t *orig_hash; struct hashtable_t *hna_local_hash; @@ -139,7 +138,6 @@ struct bat_priv { spinlock_t forw_bcast_list_lock; spinlock_t hna_lhash_lock; spinlock_t hna_ghash_lock; - spinlock_t gw_list_lock; spinlock_t vis_hash_lock; spinlock_t vis_list_lock; int16_t num_local_hna; @@ -147,7 +145,6 @@ struct bat_priv { struct delayed_work hna_work; struct delayed_work orig_work; struct delayed_work vis_work; - struct gw_node *curr_gw; struct vis_info *my_vis_info; }; -- batman-adv

1 0

[git] linux integration branch, linux, updated. v2.6.36-rc3-492-g6a10cd9
by postmaster＠open-mesh.net 07 Sep '10

07 Sep '10

The following commit has been merged in the linux branch: commit 6a10cd96982e33b7587c635eaabf1a8944b65f4f Author: Sven Eckelmann <sven.eckelmann(a)gmx.de> Date: Tue Sep 7 20:31:42 2010 +0200 Staging: batman-adv: Add rcu TODO Paul E. McKenney informed us that rcu is misused by leaking pointers to rcu related elements outside read-side protected critical sections. He also recommended that we should check it against the rcu checklist. Signed-off-by: Sven Eckelmann <sven.eckelmann(a)gmx.de> diff --git a/drivers/staging/batman-adv/TODO b/drivers/staging/batman-adv/TODO index 1457c7f..3af8028 100644 --- a/drivers/staging/batman-adv/TODO +++ b/drivers/staging/batman-adv/TODO @@ -1,3 +1,8 @@ + * Rework usage of RCU + - don't leak pointers from rcu out of rcu critical area which may + get freed + - check were synchronize_rcu must be used + - go through Documentation/RCU/checklist.txt * Request a new review * Process the comments from the review * Move into mainline proper -- linux integration

1 0

r1788 - trunk/batman-adv
by postmaster＠open-mesh.org 06 Sep '10

06 Sep '10

Author: marek Date: 2010-09-06 16:08:05 +0200 (Mon, 06 Sep 2010) New Revision: 1788 Modified: trunk/batman-adv/main.c Log: batman-adv: Always synchronize rcu's on module shutdown During the module shutdown procedure in batman_exit(), a rcu callback is being scheduled (batman_exit -> hardif_remove_interfaces -> hardif_remove_interfae -> call_rcu). However, when the kernel unloads the module, the rcu callback might not have been executed yet, resulting in a "unable to handle kernel paging request" in __rcu_process_callback afterwards, causing the kernel to freeze. The synchronize_net and synchronize_rcu in mesh_free are currently called before the call_rcu in hardif_remove_interface and have no real effect on it. Therefore, we should always flush all rcu callback functions scheduled during the shutdown procedure using synchronize_net. The call to synchronize_rcu can be omitted because synchronize_net already calls it. Signed-off-by: Linus L?\195?\188ssing <linus.luessing(a)web.de> Acked-by: Sven Eckelmann <sven.eckelmann(a)gmx.de> Modified: trunk/batman-adv/main.c =================================================================== --- trunk/batman-adv/main.c 2010-09-04 23:47:38 UTC (rev 1787) +++ trunk/batman-adv/main.c 2010-09-06 14:08:05 UTC (rev 1788) @@ -73,6 +73,8 @@ flush_workqueue(bat_event_workqueue); destroy_workqueue(bat_event_workqueue); bat_event_workqueue = NULL; + + synchronize_net(); } int mesh_init(struct net_device *soft_iface) @@ -135,9 +137,6 @@ hna_local_free(bat_priv); hna_global_free(bat_priv); - synchronize_net(); - - synchronize_rcu(); atomic_set(&bat_priv->mesh_state, MESH_INACTIVE); }

1 0

r1787 - trunk/batman-adv
by postmaster＠open-mesh.org 04 Sep '10

04 Sep '10

Author: marek Date: 2010-09-05 01:47:38 +0200 (Sun, 05 Sep 2010) New Revision: 1787 Modified: trunk/batman-adv/bitarray.h Log: batman-adv: make bitarray.h checkpatch clean Signed-off-by: Sven Eckelmann <sven.eckelmann(a)gmx.de> Modified: trunk/batman-adv/bitarray.h =================================================================== --- trunk/batman-adv/bitarray.h 2010-09-04 22:56:50 UTC (rev 1786) +++ trunk/batman-adv/bitarray.h 2010-09-04 23:47:38 UTC (rev 1787) @@ -23,7 +23,7 @@ #define _NET_BATMAN_ADV_BITARRAY_H_ /* you should choose something big, if you don't want to waste cpu - and keep the type in sync with bit_packet_count */ + * and keep the type in sync with bit_packet_count */ #define TYPE_OF_WORD unsigned long #define WORD_BIT_SIZE (sizeof(TYPE_OF_WORD) * 8)

1 0

[git] linux integration branch, linux, updated. v2.6.36-rc3-491-g8001773
by postmaster＠open-mesh.net 04 Sep '10

04 Sep '10

The following commit has been merged in the linux branch: commit b4fb4917c35c29b183bee3f60c55156200f091a0 Author: Sven Eckelmann <sven.eckelmann(a)gmx.de> Date: Sat Sep 4 18:25:43 2010 +0200 batman-adv: Add missing include for bat_sys.h soft_interface.c needs sysfs_add_meshif and sysfs_del_meshif after "batman-adv: attach each hard-interface to a soft-interface". This Include is provided indirectly using compat.h on standalone sources, but missing on kernel builds. We should add it directly as the compat.h include is only a side effect we cannot rely on. Signed-off-by: Sven Eckelmann <sven.eckelmann(a)gmx.de> diff --git a/drivers/staging/batman-adv/soft-interface.c b/drivers/staging/batman-adv/soft-interface.c index 15a7c1e..592cb39 100644 --- a/drivers/staging/batman-adv/soft-interface.c +++ b/drivers/staging/batman-adv/soft-interface.c @@ -29,6 +29,7 @@ #include "types.h" #include "hash.h" #include "send.h" +#include "bat_sysfs.h" #include <linux/slab.h> #include <linux/ethtool.h> #include <linux/etherdevice.h> -- linux integration

1 0

[git] linux integration branch, linux, updated. v2.6.36-rc3-491-g8001773
by postmaster＠open-mesh.net 04 Sep '10

04 Sep '10

The following commit has been merged in the linux branch: commit 8001773d85548980c3a8ada0dfce941577895181 Merge: b4fb4917c35c29b183bee3f60c55156200f091a0 dde523b5e82ba9dc160e4b95dbc95c303fe04843 Author: Sven Eckelmann <sven.eckelmann(a)gmx.de> Date: Sun Sep 5 01:23:18 2010 +0200 Merge remote branch 'origin/next' into linux diff --combined drivers/staging/batman-adv/soft-interface.c index 592cb39,0000000..8d14343 mode 100644,000000..100644 --- a/drivers/staging/batman-adv/soft-interface.c +++ b/drivers/staging/batman-adv/soft-interface.c @@@ -1,394 -1,0 +1,395 @@@ +/* + * Copyright (C) 2007-2010 B.A.T.M.A.N. contributors: + * + * Marek Lindner, Simon Wunderlich + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of version 2 of the GNU General Public + * License as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA + * 02110-1301, USA + * + */ + +#include "main.h" +#include "soft-interface.h" +#include "hard-interface.h" +#include "routing.h" +#include "send.h" +#include "bat_debugfs.h" +#include "translation-table.h" +#include "types.h" +#include "hash.h" +#include "send.h" +#include "bat_sysfs.h" +#include <linux/slab.h> +#include <linux/ethtool.h> +#include <linux/etherdevice.h> +#include "unicast.h" + + +static int bat_get_settings(struct net_device *dev, struct ethtool_cmd *cmd); +static void bat_get_drvinfo(struct net_device *dev, + struct ethtool_drvinfo *info); +static u32 bat_get_msglevel(struct net_device *dev); +static void bat_set_msglevel(struct net_device *dev, u32 value); +static u32 bat_get_link(struct net_device *dev); +static u32 bat_get_rx_csum(struct net_device *dev); +static int bat_set_rx_csum(struct net_device *dev, u32 data); + +static const struct ethtool_ops bat_ethtool_ops = { + .get_settings = bat_get_settings, + .get_drvinfo = bat_get_drvinfo, + .get_msglevel = bat_get_msglevel, + .set_msglevel = bat_set_msglevel, + .get_link = bat_get_link, + .get_rx_csum = bat_get_rx_csum, + .set_rx_csum = bat_set_rx_csum +}; + +int my_skb_head_push(struct sk_buff *skb, unsigned int len) +{ + int result; + + /** + * TODO: We must check if we can release all references to non-payload + * data using skb_header_release in our skbs to allow skb_cow_header to + * work optimally. This means that those skbs are not allowed to read + * or write any data which is before the current position of skb->data + * after that call and thus allow other skbs with the same data buffer + * to write freely in that area. + */ + result = skb_cow_head(skb, len); + if (result < 0) + return result; + + skb_push(skb, len); + return 0; +} + +static int interface_open(struct net_device *dev) +{ + netif_start_queue(dev); + return 0; +} + +static int interface_release(struct net_device *dev) +{ + netif_stop_queue(dev); + return 0; +} + +static struct net_device_stats *interface_stats(struct net_device *dev) +{ + struct bat_priv *bat_priv = netdev_priv(dev); + return &bat_priv->stats; +} + +static int interface_set_mac_addr(struct net_device *dev, void *p) +{ + struct bat_priv *bat_priv = netdev_priv(dev); + struct sockaddr *addr = p; + + if (!is_valid_ether_addr(addr->sa_data)) + return -EADDRNOTAVAIL; + + /* only modify hna-table if it has been initialised before */ + if (atomic_read(&bat_priv->mesh_state) == MESH_ACTIVE) { + hna_local_remove(bat_priv, dev->dev_addr, + "mac address changed"); + hna_local_add(dev, addr->sa_data); + } + + memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN); + + return 0; +} + +static int interface_change_mtu(struct net_device *dev, int new_mtu) +{ + /* check ranges */ + if ((new_mtu < 68) || (new_mtu > hardif_min_mtu(dev))) + return -EINVAL; + + dev->mtu = new_mtu; + + return 0; +} + +int interface_tx(struct sk_buff *skb, struct net_device *soft_iface) +{ + struct ethhdr *ethhdr = (struct ethhdr *)skb->data; + struct bat_priv *bat_priv = netdev_priv(soft_iface); + struct bcast_packet *bcast_packet; + int data_len = skb->len, ret; + + if (atomic_read(&bat_priv->mesh_state) != MESH_ACTIVE) + goto dropped; + + soft_iface->trans_start = jiffies; + + /* TODO: check this for locks */ + hna_local_add(soft_iface, ethhdr->h_source); + + /* ethernet packet should be broadcasted */ + if (is_bcast(ethhdr->h_dest) || is_mcast(ethhdr->h_dest)) { + if (!bat_priv->primary_if) + goto dropped; + + if (my_skb_head_push(skb, sizeof(struct bcast_packet)) < 0) + goto dropped; + + bcast_packet = (struct bcast_packet *)skb->data; + bcast_packet->version = COMPAT_VERSION; + bcast_packet->ttl = TTL; + + /* batman packet type: broadcast */ + bcast_packet->packet_type = BAT_BCAST; + + /* hw address of first interface is the orig mac because only + * this mac is known throughout the mesh */ + memcpy(bcast_packet->orig, + bat_priv->primary_if->net_dev->dev_addr, ETH_ALEN); + + /* set broadcast sequence number */ + bcast_packet->seqno = + htonl(atomic_inc_return(&bat_priv->bcast_seqno)); + + add_bcast_packet_to_list(bat_priv, skb); + + /* a copy is stored in the bcast list, therefore removing + * the original skb. */ + kfree_skb(skb); + + /* unicast packet */ + } else { + ret = unicast_send_skb(skb, bat_priv); + if (ret != 0) - goto dropped; ++ goto dropped_freed; + } + + bat_priv->stats.tx_packets++; + bat_priv->stats.tx_bytes += data_len; + goto end; + +dropped: - bat_priv->stats.tx_dropped++; + kfree_skb(skb); ++dropped_freed: ++ bat_priv->stats.tx_dropped++; +end: + return NETDEV_TX_OK; +} + +void interface_rx(struct net_device *soft_iface, + struct sk_buff *skb, int hdr_size) +{ + struct bat_priv *priv = netdev_priv(soft_iface); + + /* check if enough space is available for pulling, and pull */ + if (!pskb_may_pull(skb, hdr_size)) { + kfree_skb(skb); + return; + } + skb_pull_rcsum(skb, hdr_size); +/* skb_set_mac_header(skb, -sizeof(struct ethhdr));*/ + + skb->dev = soft_iface; + skb->protocol = eth_type_trans(skb, soft_iface); + + /* should not be neccesary anymore as we use skb_pull_rcsum() + * TODO: please verify this and remove this TODO + * -- Dec 21st 2009, Simon Wunderlich */ + +/* skb->ip_summed = CHECKSUM_UNNECESSARY;*/ + + /* TODO: set skb->pkt_type to PACKET_BROADCAST, PACKET_MULTICAST, + * PACKET_OTHERHOST or PACKET_HOST */ + + priv->stats.rx_packets++; + priv->stats.rx_bytes += skb->len + sizeof(struct ethhdr); + + soft_iface->last_rx = jiffies; + + netif_rx(skb); +} + +#ifdef HAVE_NET_DEVICE_OPS +static const struct net_device_ops bat_netdev_ops = { + .ndo_open = interface_open, + .ndo_stop = interface_release, + .ndo_get_stats = interface_stats, + .ndo_set_mac_address = interface_set_mac_addr, + .ndo_change_mtu = interface_change_mtu, + .ndo_start_xmit = interface_tx, + .ndo_validate_addr = eth_validate_addr +}; +#endif + +static void interface_setup(struct net_device *dev) +{ + struct bat_priv *priv = netdev_priv(dev); + char dev_addr[ETH_ALEN]; + + ether_setup(dev); + +#ifdef HAVE_NET_DEVICE_OPS + dev->netdev_ops = &bat_netdev_ops; +#else + dev->open = interface_open; + dev->stop = interface_release; + dev->get_stats = interface_stats; + dev->set_mac_address = interface_set_mac_addr; + dev->change_mtu = interface_change_mtu; + dev->hard_start_xmit = interface_tx; +#endif + dev->destructor = free_netdev; + + /** + * can't call min_mtu, because the needed variables + * have not been initialized yet + */ + dev->mtu = ETH_DATA_LEN; + dev->hard_header_len = BAT_HEADER_LEN; /* reserve more space in the + * skbuff for our header */ + + /* generate random address */ + random_ether_addr(dev_addr); + memcpy(dev->dev_addr, dev_addr, ETH_ALEN); + + SET_ETHTOOL_OPS(dev, &bat_ethtool_ops); + + memset(priv, 0, sizeof(struct bat_priv)); +} + +struct net_device *softif_create(char *name) +{ + struct net_device *soft_iface; + struct bat_priv *bat_priv; + int ret; + + soft_iface = alloc_netdev(sizeof(struct bat_priv) , name, + interface_setup); + + if (!soft_iface) { + pr_err("Unable to allocate the batman interface: %s\n", name); + goto out; + } + + ret = register_netdev(soft_iface); + if (ret < 0) { + pr_err("Unable to register the batman interface '%s': %i\n", + name, ret); + goto free_soft_iface; + } + + bat_priv = netdev_priv(soft_iface); + + atomic_set(&bat_priv->aggregation_enabled, 1); + atomic_set(&bat_priv->bonding_enabled, 0); + atomic_set(&bat_priv->vis_mode, VIS_TYPE_CLIENT_UPDATE); + atomic_set(&bat_priv->orig_interval, 1000); + atomic_set(&bat_priv->log_level, 0); + atomic_set(&bat_priv->frag_enabled, 1); + atomic_set(&bat_priv->bcast_queue_left, BCAST_QUEUE_LEN); + atomic_set(&bat_priv->batman_queue_left, BATMAN_QUEUE_LEN); + + atomic_set(&bat_priv->mesh_state, MESH_INACTIVE); + atomic_set(&bat_priv->bcast_seqno, 1); + atomic_set(&bat_priv->hna_local_changed, 0); + + bat_priv->primary_if = NULL; + bat_priv->num_ifaces = 0; + + ret = sysfs_add_meshif(soft_iface); + if (ret < 0) + goto unreg_soft_iface; + + ret = debugfs_add_meshif(soft_iface); + if (ret < 0) + goto unreg_sysfs; + + ret = mesh_init(soft_iface); + if (ret < 0) + goto unreg_debugfs; + + return soft_iface; + +unreg_debugfs: + debugfs_del_meshif(soft_iface); +unreg_sysfs: + sysfs_del_meshif(soft_iface); +unreg_soft_iface: + unregister_netdev(soft_iface); + return NULL; + +free_soft_iface: + free_netdev(soft_iface); +out: + return NULL; +} + +void softif_destroy(struct net_device *soft_iface) +{ + debugfs_del_meshif(soft_iface); + sysfs_del_meshif(soft_iface); + mesh_free(soft_iface); + unregister_netdevice(soft_iface); +} + +/* ethtool */ +static int bat_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) +{ + cmd->supported = 0; + cmd->advertising = 0; + cmd->speed = SPEED_10; + cmd->duplex = DUPLEX_FULL; + cmd->port = PORT_TP; + cmd->phy_address = 0; + cmd->transceiver = XCVR_INTERNAL; + cmd->autoneg = AUTONEG_DISABLE; + cmd->maxtxpkt = 0; + cmd->maxrxpkt = 0; + + return 0; +} + +static void bat_get_drvinfo(struct net_device *dev, + struct ethtool_drvinfo *info) +{ + strcpy(info->driver, "B.A.T.M.A.N. advanced"); + strcpy(info->version, SOURCE_VERSION); + strcpy(info->fw_version, "N/A"); + strcpy(info->bus_info, "batman"); +} + +static u32 bat_get_msglevel(struct net_device *dev) +{ + return -EOPNOTSUPP; +} + +static void bat_set_msglevel(struct net_device *dev, u32 value) +{ +} + +static u32 bat_get_link(struct net_device *dev) +{ + return 1; +} + +static u32 bat_get_rx_csum(struct net_device *dev) +{ + return 0; +} + +static int bat_set_rx_csum(struct net_device *dev, u32 data) +{ + return -EOPNOTSUPP; +} -- linux integration

1 0

[git] linux integration tag, GregKH-20100904, updated. v2.6.36-rc3-491-g8001773
by postmaster＠open-mesh.net 04 Sep '10

04 Sep '10

The tag, GregKH-20100904 has been updated to 8001773d85548980c3a8ada0dfce941577895181 (commit) from b4fb4917c35c29b183bee3f60c55156200f091a0 - Shortlog ------------------------------------------------------------ commit 8001773d85548980c3a8ada0dfce941577895181 Merge: b4fb491 dde523b Author: Sven Eckelmann <sven.eckelmann(a)gmx.de> Date: Sun Sep 5 01:23:18 2010 +0200 Merge remote branch 'origin/next' into linux ----------------------------------------------------------------------- -- linux integration

1 0

r1786 - trunk/batman-adv
by postmaster＠open-mesh.org 04 Sep '10

04 Sep '10

Author: marek Date: 2010-09-05 00:56:50 +0200 (Sun, 05 Sep 2010) New Revision: 1786 Modified: trunk/batman-adv/soft-interface.c Log: batman-adv: Don't double free unicast skb on failure The soft-interface transmission function expects that the unicast skb is still available when a send failed. This is not true on failed search for a router. Thus we would try to free the skb twice and create many different and hard to debug memory access failures due to access on not (anymore) allocated memory. Reported-by: Andreas Langer <an.langer(a)gmx.de> Signed-off-by: Sven Eckelmann <sven.eckelmann(a)gmx.de> Modified: trunk/batman-adv/soft-interface.c =================================================================== --- trunk/batman-adv/soft-interface.c 2010-09-04 22:37:10 UTC (rev 1785) +++ trunk/batman-adv/soft-interface.c 2010-09-04 22:56:50 UTC (rev 1786) @@ -183,7 +183,7 @@ } else { ret = unicast_send_skb(skb, bat_priv); if (ret != 0) - goto dropped; + goto dropped_freed; } bat_priv->stats.tx_packets++; @@ -191,8 +191,9 @@ goto end; dropped: + kfree_skb(skb); +dropped_freed: bat_priv->stats.tx_dropped++; - kfree_skb(skb); end: return NETDEV_TX_OK; }

1 0

r1785 - trunk/batman-adv
by postmaster＠open-mesh.org 04 Sep '10

04 Sep '10

Author: marek Date: 2010-09-05 00:37:10 +0200 (Sun, 05 Sep 2010) New Revision: 1785 Modified: trunk/batman-adv/soft-interface.c Log: batman-adv: Add missing include for bat_sys.h soft_interface.c needs sysfs_add_meshif and sysfs_del_meshif after "batman-adv: attach each hard-interface to a soft-interface". This Include is provided indirectly using compat.h on standalone sources, but missing on kernel builds. We should add it directly as the compat.h include is only a side effect we cannot rely on. Signed-off-by: Sven Eckelmann <sven.eckelmann(a)gmx.de> Modified: trunk/batman-adv/soft-interface.c =================================================================== --- trunk/batman-adv/soft-interface.c 2010-09-04 12:42:28 UTC (rev 1784) +++ trunk/batman-adv/soft-interface.c 2010-09-04 22:37:10 UTC (rev 1785) @@ -31,6 +31,7 @@ #include "gateway_common.h" #include "gateway_client.h" #include "send.h" +#include "bat_sysfs.h" #include <linux/slab.h> #include <linux/ethtool.h> #include <linux/etherdevice.h>

1 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits September 2010