Build check errors found (B.A.T.M.A.N. V): 2015-11-09

postmaster at open-mesh.org postmaster at open-mesh.org
Mon Nov 9 23:11:59 CET 2015


Name of failed tests
====================

 * checkpatch ecsv/batman_v_test ./net/batman-adv/bat_v.c
 * checkpatch ecsv/batman_v_test ./net/batman-adv/bat_v_elp.c
 * checkpatch ecsv/batman_v_test ./net/batman-adv/bat_v_ogm.c
 * headers ecsv/batman_v_test
 * kerneldoc ecsv/batman_v_test ./net/batman-adv/bat_v.c
 * kerneldoc ecsv/batman_v_test ./net/batman-adv/bat_v_ogm.c
 * kerneldoc ecsv/batman_v_test ./net/batman-adv/packet.h
 * kerneldoc ecsv/batman_v_test ./net/batman-adv/send.c

Output of different failed tests
================================

checkpatch ecsv/batman_v_test ./net/batman-adv/bat_v.c
------------------------------------------------------

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #116: FILE: ./net/batman-adv/bat_v.c:116:
    +	uint32_t throughput;
    
    WARNING: Prefer seq_puts to seq_printf
    #157: FILE: ./net/batman-adv/bat_v.c:157:
    +		seq_printf(seq, "No batman nodes in range ...\n");
    
    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #178: FILE: ./net/batman-adv/bat_v.c:178:
    +	uint32_t i;
    
    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #250: FILE: ./net/batman-adv/bat_v.c:250:
    +	uint32_t threshold;
    
    total: 0 errors, 1 warnings, 3 checks, 333 lines checked


checkpatch ecsv/batman_v_test ./net/batman-adv/bat_v_elp.c
----------------------------------------------------------

    WARNING: line over 80 characters
    #185: FILE: ./net/batman-adv/bat_v_elp.c:185:
    +				      probe_len - hard_iface->bat_v.elp_skb->len,
    
    WARNING: line over 80 characters
    #413: FILE: ./net/batman-adv/bat_v_elp.c:413:
    +	seqno_diff = ntohl(elp_packet->seqno) - hardif_neigh->bat_v.elp_latest_seqno;
    
    total: 0 errors, 2 warnings, 0 checks, 486 lines checked


checkpatch ecsv/batman_v_test ./net/batman-adv/bat_v_ogm.c
----------------------------------------------------------

    WARNING: line over 80 characters
    #258: FILE: ./net/batman-adv/bat_v_ogm.c:258:
    +		neigh_seq_diff = neigh_ifinfo->bat_v.last_seqno - router_ifinfo->bat_v.last_seqno;
    
    total: 0 errors, 1 warnings, 0 checks, 812 lines checked


headers ecsv/batman_v_test
--------------------------

    diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
    index f232a6d..daa63ea 100644
    --- a/net/batman-adv/bat_v.c
    +++ b/net/batman-adv/bat_v.c
    @@ -15,12 +15,24 @@
      * along with this program; if not, see <http://www.gnu.org/licenses/>.
      */
     
    -#include "main.h"
    +#include <linux/atomic.h>
    +#include <linux/bug.h>
    +#include <linux/cache.h>
    +#include <linux/init.h>
    +#include <linux/jiffies.h>
    +#include <linux/netdevice.h>
    +#include <linux/rculist.h>
    +#include <linux/rcupdate.h>
    +#include <linux/seq_file.h>
    +#include <linux/types.h>
    +#include <linux/workqueue.h>
     #include "bat_algo.h"
    -
     #include "bat_v_elp.h"
     #include "bat_v_ogm.h"
    +#include "hash.h"
    +#include "main.h"
     #include "originator.h"
    +#include "packet.h"
     
     static int batadv_v_iface_enable(struct batadv_hard_iface *hard_iface)
     {
    diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c
    index 1a23fc2..274089d 100644
    --- a/net/batman-adv/bat_v_elp.c
    +++ b/net/batman-adv/bat_v_elp.c
    @@ -15,18 +15,36 @@
      * along with this program; if not, see <http://www.gnu.org/licenses/>.
      */
     
    +#include <linux/atomic.h>
    +#include <linux/byteorder/generic.h>
    +#include <linux/errno.h>
    +#include <linux/etherdevice.h>
    +#include <linux/fs.h>
    +#include <linux/if_ether.h>
    +#include <linux/jiffies.h>
    +#include <linux/kernel.h>
    +#include <linux/netdevice.h>
    +#include <linux/random.h>
    +#include <linux/rculist.h>
    +#include <linux/rcupdate.h>
    +#include <linux/rtnetlink.h>
    +#include <linux/skbuff.h>
    +#include <linux/stddef.h>
    +#include <linux/string.h>
    +#include <linux/types.h>
    +#include <linux/workqueue.h>
     #include <net/cfg80211.h>
     #include <linux/ethtool.h>
     
    -#include "main.h"
    -#include "hard-interface.h"
    -#include "send.h"
     #include "bat_algo.h"
     #include "bat_v_elp.h"
     #include "bat_v_ogm.h"
    +#include "hard-interface.h"
    +#include "main.h"
     #include "originator.h"
    +#include "packet.h"
     #include "routing.h"
    -#include "soft-interface.h"
    +#include "send.h"
     
     /**
      * batadv_v_elp_start_timer - restart timer for ELP periodic work
    diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c
    index 70ddfaf..b3baaa2 100644
    --- a/net/batman-adv/bat_v_ogm.c
    +++ b/net/batman-adv/bat_v_ogm.c
    @@ -15,12 +15,31 @@
      * along with this program; if not, see <http://www.gnu.org/licenses/>.
      */
     
    -#include "main.h"
    -
    -#include "bat_v_elp.h"
    +#include <linux/atomic.h>
    +#include <linux/byteorder/generic.h>
    +#include <linux/errno.h>
    +#include <linux/etherdevice.h>
    +#include <linux/fs.h>
    +#include <linux/if_ether.h>
    +#include <linux/jiffies.h>
    +#include <linux/kernel.h>
    +#include <linux/list.h>
    +#include <linux/netdevice.h>
    +#include <linux/random.h>
    +#include <linux/rculist.h>
    +#include <linux/rcupdate.h>
    +#include <linux/skbuff.h>
    +#include <linux/slab.h>
    +#include <linux/stddef.h>
    +#include <linux/string.h>
    +#include <linux/types.h>
    +#include <linux/workqueue.h>
     #include "bat_v_ogm.h"
     #include "hard-interface.h"
    +#include "hash.h"
    +#include "main.h"
     #include "originator.h"
    +#include "packet.h"
     #include "routing.h"
     #include "send.h"
     #include "translation-table.h"


kerneldoc ecsv/batman_v_test ./net/batman-adv/bat_v.c
-----------------------------------------------------

    ./net/batman-adv/bat_v.c:303: warning: contents before sections


kerneldoc ecsv/batman_v_test ./net/batman-adv/bat_v_ogm.c
---------------------------------------------------------

    ./net/batman-adv/bat_v_ogm.c:230: warning: No description found for parameter 'neigh_node'
    ./net/batman-adv/bat_v_ogm.c:478: warning: No description found for parameter 'ethhdr'
    ./net/batman-adv/bat_v_ogm.c:478: warning: Excess function parameter 'eth_hdr' description in 'batadv_v_ogm_route_update'
    ./net/batman-adv/bat_v_ogm.c:478: warning: Excess function parameter 'path_throughput' description in 'batadv_v_ogm_route_update'
    ./net/batman-adv/bat_v_ogm.c:580: warning: No description found for parameter 'ethhdr'
    ./net/batman-adv/bat_v_ogm.c:580: warning: Excess function parameter 'eth_hdr' description in 'batadv_v_ogm_process_per_outif'
    ./net/batman-adv/bat_v_ogm.c:775: warning: No description found for return value of 'batadv_v_ogm_init'


kerneldoc ecsv/batman_v_test ./net/batman-adv/packet.h
------------------------------------------------------

    ./net/batman-adv/packet.h:264: warning: No description found for parameter 'flags'


kerneldoc ecsv/batman_v_test ./net/batman-adv/send.c
----------------------------------------------------

    ./net/batman-adv/send.c:70: warning: No description found for parameter 'dst_addr'
    ./net/batman-adv/send.c:70: warning: Excess function parameter 'neigh_node' description in 'batadv_send_skb_packet'


More information about the linux-merge mailing list