Build check errors found: 2014-07-09

postmaster at open-mesh.org postmaster at open-mesh.org
Wed Jul 9 01:31:24 CEST 2014


Name of failed tests
====================

checkpatch master bat_iv_ogm.c
checkpatch master bitarray.c
checkpatch master bitarray.h
checkpatch master bridge_loop_avoidance.c
checkpatch master debugfs.c
checkpatch master distributed-arp-table.c
checkpatch master fragmentation.c
checkpatch master fragmentation.h
checkpatch master gateway_client.c
checkpatch master main.c
checkpatch master main.h
checkpatch master multicast.h
checkpatch master network-coding.c
checkpatch master originator.c
checkpatch master originator.h
checkpatch master packet.h
checkpatch master routing.c
checkpatch master soft-interface.c
checkpatch master sysfs.c
checkpatch master translation-table.c
checkpatch next bat_iv_ogm.c
checkpatch next bitarray.c
checkpatch next bitarray.h
checkpatch next bridge_loop_avoidance.c
checkpatch next debugfs.c
checkpatch next distributed-arp-table.c
checkpatch next fragmentation.c
checkpatch next fragmentation.h
checkpatch next gateway_client.c
checkpatch next hash.c
checkpatch next main.c
checkpatch next main.h
checkpatch next multicast.h
checkpatch next network-coding.c
checkpatch next originator.c
checkpatch next originator.h
checkpatch next packet.h
checkpatch next routing.c
checkpatch next soft-interface.c
checkpatch next sysfs.c
checkpatch next translation-table.c

Output of different failed tests
================================

checkpatch master bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+

CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#882: FILE: bat_iv_ogm.c:882:
+			word = &(orig_node->bat_iv.bcast_own[word_index]);

CHECK: Please don't use multiple blank lines
#1365: FILE: bat_iv_ogm.c:1365:
+
+

CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1667: FILE: bat_iv_ogm.c:1667:
+			word = &(orig_neigh_node->bat_iv.bcast_own[offset]);

total: 0 errors, 0 warnings, 4 checks, 1980 lines checked

checkpatch master distributed-arp-table.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#1103: FILE: distributed-arp-table.c:1103:
+}
+/**

total: 0 errors, 0 warnings, 1 checks, 1203 lines checked

checkpatch master fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+

total: 0 errors, 0 warnings, 1 checks, 498 lines checked

checkpatch master main.h:
>>>>>>>>
CHECK: No space is necessary after a cast
#320: FILE: main.h:320:
+				 (void) (&_d1 == &_d2); \

total: 0 errors, 0 warnings, 1 checks, 391 lines checked

checkpatch next bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+

WARNING: Prefer kmalloc_array over kmalloc with multiply
#126: FILE: bat_iv_ogm.c:126:
+	data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);

WARNING: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: bat_iv_ogm.c:186:
+	data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);

CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#881: FILE: bat_iv_ogm.c:881:
+			word = &(orig_node->bat_iv.bcast_own[word_index]);

CHECK: Please don't use multiple blank lines
#1364: FILE: bat_iv_ogm.c:1364:
+
+

CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1666: FILE: bat_iv_ogm.c:1666:
+			word = &(orig_neigh_node->bat_iv.bcast_own[offset]);

total: 0 errors, 2 warnings, 4 checks, 1979 lines checked

checkpatch next bitarray.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#32: FILE: bitarray.c:32:
+
+

total: 0 errors, 0 warnings, 1 checks, 93 lines checked

checkpatch next bitarray.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#32: FILE: bitarray.h:32:
+		return 0;
+	else

total: 0 errors, 1 warnings, 0 checks, 52 lines checked

checkpatch next bridge_loop_avoidance.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#72: FILE: bridge_loop_avoidance.c:72:
+
+

CHECK: Please don't use multiple blank lines
#663: FILE: bridge_loop_avoidance.c:663:
+
+

CHECK: Please don't use multiple blank lines
#849: FILE: bridge_loop_avoidance.c:849:
+
+

CHECK: Please don't use multiple blank lines
#1346: FILE: bridge_loop_avoidance.c:1346:
+
+

CHECK: Please don't use multiple blank lines
#1389: FILE: bridge_loop_avoidance.c:1389:
+
+

CHECK: Please don't use multiple blank lines
#1479: FILE: bridge_loop_avoidance.c:1479:
+
+

total: 0 errors, 0 warnings, 6 checks, 1725 lines checked

checkpatch next debugfs.c:
>>>>>>>>
WARNING: void function return statements are not generally useful
#237: FILE: debugfs.c:237:
+	return;
+}

CHECK: Please use a blank line after function/struct/union/enum declarations
#408: FILE: debugfs.c:408:
+}
+static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO,

total: 0 errors, 1 warnings, 1 checks, 561 lines checked

checkpatch next distributed-arp-table.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#540: FILE: distributed-arp-table.c:540:
+	res = kmalloc(BATADV_DAT_CANDIDATES_NUM * sizeof(*res), GFP_ATOMIC);

CHECK: Please use a blank line after function/struct/union/enum declarations
#1102: FILE: distributed-arp-table.c:1102:
+}
+/**

total: 0 errors, 1 warnings, 1 checks, 1202 lines checked

checkpatch next fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+

total: 0 errors, 0 warnings, 1 checks, 494 lines checked

checkpatch next fragmentation.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#44: FILE: fragmentation.h:44:
+		return true;
+	else

total: 0 errors, 1 warnings, 0 checks, 48 lines checked

checkpatch next gateway_client.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#778: FILE: gateway_client.c:778:
+}
+/**

total: 0 errors, 0 warnings, 1 checks, 879 lines checked

checkpatch next hash.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#49: FILE: hash.c:49:
+	hash->table = kmalloc(sizeof(*hash->table) * size, GFP_ATOMIC);

WARNING: Prefer kmalloc_array over kmalloc with multiply
#53: FILE: hash.c:53:
+	hash->list_locks = kmalloc(sizeof(*hash->list_locks) * size,

total: 0 errors, 2 warnings, 0 checks, 76 lines checked

checkpatch next main.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#44: FILE: main.c:44:
+
+

CHECK: No space is necessary after a cast
#438: FILE: main.c:438:
+	BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);

CHECK: No space is necessary after a cast
#439: FILE: main.c:439:
+	BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);

CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+	BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);

CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+	BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);

CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+	BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);

CHECK: No space is necessary after a cast
#443: FILE: main.c:443:
+	BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);

CHECK: No space is necessary after a cast
#444: FILE: main.c:444:
+	BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);

CHECK: No space is necessary after a cast
#445: FILE: main.c:445:
+	BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);

CHECK: No space is necessary after a cast
#446: FILE: main.c:446:
+	BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);

CHECK: No space is necessary after a cast
#447: FILE: main.c:447:
+	BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);

CHECK: No space is necessary after a cast
#448: FILE: main.c:448:
+	BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);

CHECK: No space is necessary after a cast
#449: FILE: main.c:449:
+	BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);

CHECK: No space is necessary after a cast
#450: FILE: main.c:450:
+	BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);

CHECK: No space is necessary after a cast
#451: FILE: main.c:451:
+	BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);

CHECK: No space is necessary after a cast
#452: FILE: main.c:452:
+	BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);

CHECK: No space is necessary after a cast
#453: FILE: main.c:453:
+	BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);

CHECK: No space is necessary after a cast
#1062: FILE: main.c:1062:
+	if (tvlv_handler) {

total: 0 errors, 0 warnings, 18 checks, 1263 lines checked

checkpatch next main.h:
>>>>>>>>
CHECK: No space is necessary after a cast
#312: FILE: main.h:312:
+				 (void) (&_d1 == &_d2); \

total: 0 errors, 0 warnings, 1 checks, 383 lines checked

checkpatch next multicast.h:
>>>>>>>>
WARNING: void function return statements are not generally useful
#54: FILE: multicast.h:54:
+	return;
+}

WARNING: void function return statements are not generally useful
#71: FILE: multicast.h:71:
+	return;
+}

WARNING: void function return statements are not generally useful
#76: FILE: multicast.h:76:
+	return;
+}

total: 0 errors, 3 warnings, 0 checks, 80 lines checked

checkpatch next network-coding.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#1215: FILE: network-coding.c:1215:
+		return false;
+	else

total: 0 errors, 1 warnings, 0 checks, 1937 lines checked

checkpatch next originator.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#802: FILE: originator.c:802:
+
+

total: 0 errors, 0 warnings, 1 checks, 1177 lines checked

checkpatch next originator.h:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#73: FILE: originator.h:73:
+
+

total: 0 errors, 0 warnings, 1 checks, 126 lines checked

checkpatch next packet.h:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#201: FILE: packet.h:201:
+};
+#pragma pack()

total: 0 errors, 0 warnings, 1 checks, 552 lines checked

checkpatch next routing.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#295: FILE: routing.c:295:
+
+

total: 0 errors, 0 warnings, 1 checks, 1085 lines checked

checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#39: FILE: soft-interface.c:39:
+
+

total: 0 errors, 0 warnings, 1 checks, 1114 lines checked

checkpatch next sysfs.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#154: FILE: sysfs.c:154:
+
+

total: 0 errors, 0 warnings, 1 checks, 944 lines checked

checkpatch next translation-table.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#1783: FILE: translation-table.c:1783:
+
+

WARNING: else is not generally useful after a break or return
#2772: FILE: translation-table.c:2772:
+		return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
+	else

total: 0 errors, 1 warnings, 1 checks, 3712 lines checked



More information about the linux-merge mailing list