Failed check master routing.c

postmaster at open-mesh.org postmaster at open-mesh.org
Sat Mar 10 00:34:26 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#91: FILE: routing.c:91:
+			"Changing route towards: %pM "
+			"(now via %pM - was via %pM)\n",

CHECK: braces {} should be used on all arms of this statement
#238: FILE: routing.c:238:
+		if (has_timed_out(*last_reset, RESET_PROTECTION_MS)) {
[...]
+		} else
[...]

CHECK: Coalesced strings are easier to grep and less error prone
#351: FILE: routing.c:351:
+		pr_debug("Warning - can't forward icmp packet from %pM to "
+			 "%pM: ttl exceeded\n", icmp_packet->orig,

CHECK: Coalesced strings are easier to grep and less error prone
#686: FILE: routing.c:686:
+	bat_dbg(DBG_TT, bat_priv, "Received ROAMING_ADV from %pM "
+		"(client %pM)\n", roam_adv_packet->src,

CHECK: Coalesced strings are easier to grep and less error prone
#825: FILE: routing.c:825:
+		pr_debug("Warning - can't forward unicast packet from %pM to "
+			 "%pM: ttl exceeded\n", ethhdr->h_source,

CHECK: Coalesced strings are easier to grep and less error prone
#946: FILE: routing.c:946:
+		bat_dbg(DBG_ROUTES, bat_priv, "TTVN mismatch (old_ttvn %u "
+			"new_ttvn %u)! Rerouting unicast packet (for %pM) to "

CHECK: Coalesced strings are easier to grep and less error prone
#947: FILE: routing.c:947:
+			"new_ttvn %u)! Rerouting unicast packet (for %pM) to "
+			"%pM\n", unicast_packet->ttvn, curr_ttvn,

total: 0 errors, 0 warnings, 7 checks, 1153 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

routing.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list