Failed check master hard-interface.c

postmaster at open-mesh.org postmaster at open-mesh.org
Sat Mar 10 00:34:22 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#180: FILE: hard-interface.c:180:
+		pr_warning("The newly added mac address (%pM) already exists "
+			   "on: %s\n", net_dev->dev_addr,

CHECK: Coalesced strings are easier to grep and less error prone
#183: FILE: hard-interface.c:183:
+		pr_warning("It is strongly recommended to keep mac addresses "
+			   "unique to avoid problems!\n");

CHECK: Coalesced strings are easier to grep and less error prone
#287: FILE: hard-interface.c:287:
+		pr_err("You are about to enable batman-adv on '%s' which "
+		       "already is part of a bridge. Unless you know exactly "

CHECK: Coalesced strings are easier to grep and less error prone
#288: FILE: hard-interface.c:288:
+		       "already is part of a bridge. Unless you know exactly "
+		       "what you are doing this is probably wrong and won't "

CHECK: Coalesced strings are easier to grep and less error prone
#289: FILE: hard-interface.c:289:
+		       "what you are doing this is probably wrong and won't "
+		       "work the way you think it would.\n",

CHECK: Coalesced strings are easier to grep and less error prone
#308: FILE: hard-interface.c:308:
+		pr_err("Can't create batman mesh interface %s: "
+		       "already exists as regular interface\n",

CHECK: Coalesced strings are easier to grep and less error prone
#341: FILE: hard-interface.c:341:
+			 "The MTU of interface %s is too small (%i) to handle "
+			 "the transport of batman-adv packets. Packets going "

CHECK: Coalesced strings are easier to grep and less error prone
#342: FILE: hard-interface.c:342:
+			 "the transport of batman-adv packets. Packets going "
+			 "over this interface will be fragmented on layer2 "

CHECK: Coalesced strings are easier to grep and less error prone
#343: FILE: hard-interface.c:343:
+			 "over this interface will be fragmented on layer2 "
+			 "which could impact the performance. Setting the MTU "

CHECK: Coalesced strings are easier to grep and less error prone
#344: FILE: hard-interface.c:344:
+			 "which could impact the performance. Setting the MTU "
+			 "to %zi would solve the problem.\n",

CHECK: Coalesced strings are easier to grep and less error prone
#352: FILE: hard-interface.c:352:
+			 "The MTU of interface %s is too small (%i) to handle "
+			 "the transport of batman-adv packets. If you "

CHECK: Coalesced strings are easier to grep and less error prone
#353: FILE: hard-interface.c:353:
+			 "the transport of batman-adv packets. If you "
+			 "experience problems getting traffic through try "

CHECK: Coalesced strings are easier to grep and less error prone
#354: FILE: hard-interface.c:354:
+			 "experience problems getting traffic through try "
+			 "increasing the MTU to %zi.\n",

CHECK: Coalesced strings are easier to grep and less error prone
#362: FILE: hard-interface.c:362:
+		bat_err(hard_iface->soft_iface, "Not using interface %s "
+			"(retrying later): interface not active\n",

total: 0 errors, 0 warnings, 14 checks, 596 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

hard-interface.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list