Failed check next icmp_socket.c

postmaster at open-mesh.org postmaster at open-mesh.org
Fri Mar 9 00:41:24 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#63: FILE: icmp_socket.c:63:
+		pr_err("Error - can't add another packet client: "
+		       "maximum number of clients reached\n");

CHECK: Coalesced strings are easier to grep and less error prone
#166: FILE: icmp_socket.c:166:
+			"Error - can't send packet from char device: "
+			"invalid packet size\n");

CHECK: Coalesced strings are easier to grep and less error prone
#197: FILE: icmp_socket.c:197:
+			"Error - can't send packet from char device: "
+			"got bogus packet type (expected: BAT_ICMP)\n");

CHECK: Coalesced strings are easier to grep and less error prone
#205: FILE: icmp_socket.c:205:
+			"Error - can't send packet from char device: "
+			"got bogus message type (expected: ECHO_REQUEST)\n");

total: 0 errors, 0 warnings, 4 checks, 350 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

icmp_socket.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list