Failed check master translation-table.c

postmaster at open-mesh.org postmaster at open-mesh.org
Fri Mar 9 00:34:47 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#338: FILE: translation-table.c:338:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+				 "please specify interfaces to enable it\n",

CHECK: Coalesced strings are easier to grep and less error prone
#345: FILE: translation-table.c:345:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+				 "primary interface not active\n",

CHECK: Coalesced strings are easier to grep and less error prone
#351: FILE: translation-table.c:351:
+	seq_printf(seq, "Locally retrieved addresses (from %s) "
+		   "announced via TT (TTVN: %u):\n",

CHECK: Coalesced strings are easier to grep and less error prone
#394: FILE: translation-table.c:394:
+	bat_dbg(DBG_TT, bat_priv, "Local tt entry (%pM) pending to be removed: "
+		"%s\n", tt_local_entry->common.addr, message);

CHECK: Don't begin block comments with only a /* line, use /* comment...
#601: FILE: translation-table.c:601:
+
+		/*

CHECK: Don't begin block comments with only a /* line, use /* comment...
#638: FILE: translation-table.c:638:
+
+/*

CHECK: Coalesced strings are easier to grep and less error prone
#660: FILE: translation-table.c:660:
+		seq_printf(seq,	" * %pM  (%3u) via %pM     (%3u)   "
+			   "[%c%c]\n", tt_global_entry->common.addr,

CHECK: Coalesced strings are easier to grep and less error prone
#684: FILE: translation-table.c:684:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - please "
+				 "specify interfaces to enable it\n",

CHECK: Coalesced strings are easier to grep and less error prone
#691: FILE: translation-table.c:691:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+				 "primary interface not active\n",

CHECK: Don't begin block comments with only a /* line, use /* comment...
#776: FILE: translation-table.c:776:
+
+/*

CHECK: Don't begin block comments with only a /* line, use /* comment...
#791: FILE: translation-table.c:791:
+
+	/*

CHECK: Coalesced strings are easier to grep and less error prone
#944: FILE: translation-table.c:944:
+			bat_dbg(DBG_TT, bat_priv, "Deleting global "
+				"tt entry (%pM): Roaming timeout\n",

CHECK: Coalesced strings are easier to grep and less error prone
#1353: FILE: translation-table.c:1353:
+	bat_dbg(DBG_TT, bat_priv, "Sending TT_REQUEST to %pM via %pM "
+		"[%c]\n", dst_orig_node->orig, neigh_node->addr,

CHECK: Coalesced strings are easier to grep and less error prone
#1391: FILE: translation-table.c:1391:
+		"Received TT_REQUEST from %pM for "
+		"ttvn: %u (%pM) [%c]\n", tt_request->src,

CHECK: Coalesced strings are easier to grep and less error prone
#1518: FILE: translation-table.c:1518:
+		"Received TT_REQUEST from %pM for "
+		"ttvn: %u (me) [%c]\n", tt_request->src,

CHECK: braces {} should be used on all arms of this statement
#1620: FILE: translation-table.c:1620:
+	if (is_my_mac(tt_request->dst)) {
[...]
+	} else
[...]

CHECK: Coalesced strings are easier to grep and less error prone
#1727: FILE: translation-table.c:1727:
+	bat_dbg(DBG_TT, bat_priv, "Received TT_RESPONSE from %pM for "
+		"ttvn %d t_size: %d [%c]\n",

CHECK: Coalesced strings are easier to grep and less error prone
#1998: FILE: translation-table.c:1998:
+			bat_dbg(DBG_TT, bat_priv, "Deleting local tt entry "
+				"(%pM): pending\n", tt_common_entry->addr);

CHECK: Coalesced strings are easier to grep and less error prone
#2111: FILE: translation-table.c:2111:
+			bat_dbg(DBG_TT, bat_priv, "TT inconsistency for %pM. "
+				"Need to retrieve the correct information "

CHECK: Coalesced strings are easier to grep and less error prone
#2112: FILE: translation-table.c:2112:
+				"Need to retrieve the correct information "
+				"(ttvn: %u last_ttvn: %u crc: %u last_crc: "

CHECK: Coalesced strings are easier to grep and less error prone
#2113: FILE: translation-table.c:2113:
+				"(ttvn: %u last_ttvn: %u crc: %u last_crc: "
+				"%u num_changes: %u)\n", orig_node->orig, ttvn,

total: 0 errors, 0 warnings, 21 checks, 2121 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

translation-table.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list