Failed check master distributed-arp-table.c

postmaster at open-mesh.org postmaster at open-mesh.org
Fri Mar 9 00:34:35 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#60: FILE: distributed-arp-table.c:60:
+		bat_dbg(DBG_DAT, bat_priv, "* encapsulated within a UNICAST "
+			"packet\n");

CHECK: Coalesced strings are easier to grep and less error prone
#64: FILE: distributed-arp-table.c:64:
+		bat_dbg(DBG_DAT, bat_priv, "* encapsulated within a "
+			"UNICAST_4ADDR packet (src: %pM)\n",

CHECK: Coalesced strings are easier to grep and less error prone
#85: FILE: distributed-arp-table.c:85:
+		bat_dbg(DBG_DAT, bat_priv, "* encapsulated within a BCAST "
+			"packet (src: %pM)\n",

CHECK: Coalesced strings are easier to grep and less error prone
#90: FILE: distributed-arp-table.c:90:
+		bat_dbg(DBG_DAT, bat_priv, "* encapsulated within an unknown "
+			"packet type (0x%x)\n",

CHECK: Coalesced strings are easier to grep and less error prone
#181: FILE: distributed-arp-table.c:181:
+		bat_dbg(DBG_DAT, bat_priv, "dht_select_candidates() %d: "
+			"selected %pM addr=%u dist=%u\n", select,

CHECK: Coalesced strings are easier to grep and less error prone
#210: FILE: distributed-arp-table.c:210:
+	bat_dbg(DBG_DAT, bat_priv, "dht_select_candidates(): IP=%pI4 "
+		"hash(IP)=%u\n", &ip_dst, ip_key);

CHECK: Don't begin block comments with only a /* line, use /* comment...
#218: FILE: distributed-arp-table.c:218:
+
+/*

CHECK: Coalesced strings are easier to grep and less error prone
#551: FILE: distributed-arp-table.c:551:
+			bat_dbg(DBG_DAT, bat_priv, "ARP Request for %pI4: "
+				"fallback prevented\n",

CHECK: Coalesced strings are easier to grep and less error prone
#569: FILE: distributed-arp-table.c:569:
+		pr_err("Unable to set ARP parameters for the batman interface "
+		       "'%s'\n", name);

total: 0 errors, 0 warnings, 9 checks, 580 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

distributed-arp-table.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list