Failed check next translation-table.c

postmaster at open-mesh.org postmaster at open-mesh.org
Thu Mar 8 00:45:00 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#313: FILE: translation-table.c:313:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+				 "please specify interfaces to enable it\n",

CHECK: Coalesced strings are easier to grep and less error prone
#320: FILE: translation-table.c:320:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+				 "primary interface not active\n",

CHECK: Coalesced strings are easier to grep and less error prone
#326: FILE: translation-table.c:326:
+	seq_printf(seq, "Locally retrieved addresses (from %s) "
+		   "announced via TT (TTVN: %u):\n",

CHECK: Coalesced strings are easier to grep and less error prone
#369: FILE: translation-table.c:369:
+	bat_dbg(DBG_TT, bat_priv, "Local tt entry (%pM) pending to be removed: "
+		"%s\n", tt_local_entry->common.addr, message);

CHECK: Coalesced strings are easier to grep and less error prone
#578: FILE: translation-table.c:578:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - please "
+				 "specify interfaces to enable it\n",

CHECK: Coalesced strings are easier to grep and less error prone
#585: FILE: translation-table.c:585:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+				 "primary interface not active\n",

CHECK: Coalesced strings are easier to grep and less error prone
#606: FILE: translation-table.c:606:
+			seq_printf(seq, " * %pM  (%3u) via %pM     (%3u)   "
+					"[%c%c]\n",

CHECK: Coalesced strings are easier to grep and less error prone
#714: FILE: translation-table.c:714:
+					"Deleting global tt entry %pM "
+					"(via %pM): %s\n",

CHECK: Coalesced strings are easier to grep and less error prone
#755: FILE: translation-table.c:755:
+			bat_dbg(DBG_TT, bat_priv, "Deleting global "
+				"tt entry (%pM): Roaming timeout\n",

CHECK: Coalesced strings are easier to grep and less error prone
#1138: FILE: translation-table.c:1138:
+	bat_dbg(DBG_TT, bat_priv, "Sending TT_REQUEST to %pM via %pM "
+		"[%c]\n", dst_orig_node->orig, neigh_node->addr,

CHECK: Coalesced strings are easier to grep and less error prone
#1176: FILE: translation-table.c:1176:
+		"Received TT_REQUEST from %pM for "
+		"ttvn: %u (%pM) [%c]\n", tt_request->src,

CHECK: Coalesced strings are easier to grep and less error prone
#1303: FILE: translation-table.c:1303:
+		"Received TT_REQUEST from %pM for "
+		"ttvn: %u (me) [%c]\n", tt_request->src,

CHECK: Coalesced strings are easier to grep and less error prone
#1508: FILE: translation-table.c:1508:
+	bat_dbg(DBG_TT, bat_priv, "Received TT_RESPONSE from %pM for "
+		"ttvn %d t_size: %d [%c]\n",

CHECK: Coalesced strings are easier to grep and less error prone
#1775: FILE: translation-table.c:1775:
+			bat_dbg(DBG_TT, bat_priv, "Deleting local tt entry "
+				"(%pM): pending\n", tt_common_entry->addr);

CHECK: Coalesced strings are easier to grep and less error prone
#1881: FILE: translation-table.c:1881:
+			bat_dbg(DBG_TT, bat_priv, "TT inconsistency for %pM. "
+				"Need to retrieve the correct information "

CHECK: Coalesced strings are easier to grep and less error prone
#1882: FILE: translation-table.c:1882:
+				"Need to retrieve the correct information "
+				"(ttvn: %u last_ttvn: %u crc: %u last_crc: "

CHECK: Coalesced strings are easier to grep and less error prone
#1883: FILE: translation-table.c:1883:
+				"(ttvn: %u last_ttvn: %u crc: %u last_crc: "
+				"%u num_changes: %u)\n", orig_node->orig, ttvn,

total: 0 errors, 0 warnings, 17 checks, 1891 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

translation-table.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list