Failed check next hard-interface.c

postmaster at open-mesh.org postmaster at open-mesh.org
Thu Mar 8 00:44:51 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#179: FILE: hard-interface.c:179:
+		pr_warning("The newly added mac address (%pM) already exists "
+			   "on: %s\n", net_dev->dev_addr,

CHECK: Coalesced strings are easier to grep and less error prone
#182: FILE: hard-interface.c:182:
+		pr_warning("It is strongly recommended to keep mac addresses "
+			   "unique to avoid problems!\n");

CHECK: Coalesced strings are easier to grep and less error prone
#286: FILE: hard-interface.c:286:
+		pr_err("You are about to enable batman-adv on '%s' which "
+		       "already is part of a bridge. Unless you know exactly "

CHECK: Coalesced strings are easier to grep and less error prone
#287: FILE: hard-interface.c:287:
+		       "already is part of a bridge. Unless you know exactly "
+		       "what you are doing this is probably wrong and won't "

CHECK: Coalesced strings are easier to grep and less error prone
#288: FILE: hard-interface.c:288:
+		       "what you are doing this is probably wrong and won't "
+		       "work the way you think it would.\n",

CHECK: Coalesced strings are easier to grep and less error prone
#307: FILE: hard-interface.c:307:
+		pr_err("Can't create batman mesh interface %s: "
+		       "already exists as regular interface\n",

CHECK: Coalesced strings are easier to grep and less error prone
#321: FILE: hard-interface.c:321:
+		bat_err(hard_iface->soft_iface, "Can't add interface packet "
+			"(%s): out of memory\n", hard_iface->net_dev->name);

CHECK: Coalesced strings are easier to grep and less error prone
#345: FILE: hard-interface.c:345:
+			 "The MTU of interface %s is too small (%i) to handle "
+			 "the transport of batman-adv packets. Packets going "

CHECK: Coalesced strings are easier to grep and less error prone
#346: FILE: hard-interface.c:346:
+			 "the transport of batman-adv packets. Packets going "
+			 "over this interface will be fragmented on layer2 "

CHECK: Coalesced strings are easier to grep and less error prone
#347: FILE: hard-interface.c:347:
+			 "over this interface will be fragmented on layer2 "
+			 "which could impact the performance. Setting the MTU "

CHECK: Coalesced strings are easier to grep and less error prone
#348: FILE: hard-interface.c:348:
+			 "which could impact the performance. Setting the MTU "
+			 "to %zi would solve the problem.\n",

CHECK: Coalesced strings are easier to grep and less error prone
#356: FILE: hard-interface.c:356:
+			 "The MTU of interface %s is too small (%i) to handle "
+			 "the transport of batman-adv packets. If you "

CHECK: Coalesced strings are easier to grep and less error prone
#357: FILE: hard-interface.c:357:
+			 "the transport of batman-adv packets. If you "
+			 "experience problems getting traffic through try "

CHECK: Coalesced strings are easier to grep and less error prone
#358: FILE: hard-interface.c:358:
+			 "experience problems getting traffic through try "
+			 "increasing the MTU to %zi.\n",

CHECK: Coalesced strings are easier to grep and less error prone
#366: FILE: hard-interface.c:366:
+		bat_err(hard_iface->soft_iface, "Not using interface %s "
+			"(retrying later): interface not active\n",

total: 0 errors, 0 warnings, 15 checks, 700 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

hard-interface.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list