Failed check next gateway_client.c

postmaster at open-mesh.org postmaster at open-mesh.org
Thu Mar 8 00:44:49 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#234: FILE: gateway_client.c:234:
+			"Changing route to gateway %pM "
+			"(gw_flags: %i, tq: %i)\n",

CHECK: Coalesced strings are easier to grep and less error prone
#291: FILE: gateway_client.c:291:
+		"Restarting gateway selection: better gateway found (tq curr: "
+		"%i, tq new: %i)\n",

CHECK: Coalesced strings are easier to grep and less error prone
#356: FILE: gateway_client.c:356:
+			"Gateway class of originator %pM changed from "
+			"%i to %i\n",

CHECK: Coalesced strings are easier to grep and less error prone
#478: FILE: gateway_client.c:478:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - please "
+				 "specify interfaces to enable it\n",

CHECK: Coalesced strings are easier to grep and less error prone
#485: FILE: gateway_client.c:485:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+				 "primary interface not active\n",

CHECK: Coalesced strings are easier to grep and less error prone
#491: FILE: gateway_client.c:491:
+	seq_printf(seq, "      %-12s (%s/%i) %17s [%10s]: gw_class ... "
+		   "[B.A.T.M.A.N. adv %s, MainIF/MAC: %s/%pM (%s)]\n",

total: 0 errors, 0 warnings, 6 checks, 714 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

gateway_client.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list