Failed check next bat_iv_ogm.c

postmaster at open-mesh.org postmaster at open-mesh.org
Thu Mar 8 00:44:47 CET 2012


CHECK: Coalesced strings are easier to grep and less error prone
#136: FILE: bat_iv_ogm.c:136:
+			"%s %spacket (originator %pM, seqno %d, TQ %d, TTL %d,"
+			" IDF %s, ttvn %d) on interface %s [%pM]\n",

CHECK: Coalesced strings are easier to grep and less error prone
#175: FILE: bat_iv_ogm.c:175:
+		pr_err("Error - can't forward packet: incoming iface not "
+		       "specified\n");

CHECK: Coalesced strings are easier to grep and less error prone
#197: FILE: bat_iv_ogm.c:197:
+			"%s packet (originator %pM, seqno %d, TTL %d) "
+			"on interface %s [%pM]\n",

CHECK: Coalesced strings are easier to grep and less error prone
#512: FILE: bat_iv_ogm.c:512:
+		"Forwarding packet: tq_orig: %i, tq_avg: %i, "
+		"tq_forw: %i, ttl_orig: %i, ttl_forw: %i\n",

CHECK: Coalesced strings are easier to grep and less error prone
#593: FILE: bat_iv_ogm.c:593:
+	bat_dbg(DBG_BATMAN, bat_priv, "update_originator(): "
+		"Searching and updating originator entry of received packet\n");

CHECK: Don't begin block comments with only a /* line, use /* comment...
#786: FILE: bat_iv_ogm.c:786:
+
+	/*

CHECK: Coalesced strings are easier to grep and less error prone
#806: FILE: bat_iv_ogm.c:806:
+		"bidirectional: "
+		"orig = %-15pM neigh = %-15pM => own_bcast = %2i, "

CHECK: Coalesced strings are easier to grep and less error prone
#807: FILE: bat_iv_ogm.c:807:
+		"orig = %-15pM neigh = %-15pM => own_bcast = %2i, "
+		"real recv = %2i, local tq: %3i, asym_penalty: %3i, "

CHECK: Coalesced strings are easier to grep and less error prone
#808: FILE: bat_iv_ogm.c:808:
+		"real recv = %2i, local tq: %3i, asym_penalty: %3i, "
+		"total tq: %3i\n",

CHECK: Coalesced strings are easier to grep and less error prone
#937: FILE: bat_iv_ogm.c:937:
+		"Received BATMAN packet via NB: %pM, IF: %s [%pM] "
+		"(from OG: %pM, via prev OG: %pM, seqno %d, ttvn %u, "

CHECK: Coalesced strings are easier to grep and less error prone
#938: FILE: bat_iv_ogm.c:938:
+		"(from OG: %pM, via prev OG: %pM, seqno %d, ttvn %u, "
+		"crc %u, changes %u, td %d, TTL %d, V %d, IDF %d)\n",

CHECK: Coalesced strings are easier to grep and less error prone
#982: FILE: bat_iv_ogm.c:982:
+			"Drop packet: received my own broadcast (sender: %pM"
+			")\n",

CHECK: Coalesced strings are easier to grep and less error prone
#989: FILE: bat_iv_ogm.c:989:
+		bat_dbg(DBG_BATMAN, bat_priv, "Drop packet: "
+		"ignoring all packets with broadcast source addr (sender: %pM"

CHECK: Coalesced strings are easier to grep and less error prone
#990: FILE: bat_iv_ogm.c:990:
+		"ignoring all packets with broadcast source addr (sender: %pM"
+		")\n", ethhdr->h_source);

CHECK: Coalesced strings are easier to grep and less error prone
#1021: FILE: bat_iv_ogm.c:1021:
+		bat_dbg(DBG_BATMAN, bat_priv, "Drop packet: "
+			"originator packet from myself (via neighbor)\n");

CHECK: Coalesced strings are easier to grep and less error prone
#1029: FILE: bat_iv_ogm.c:1029:
+			"Drop packet: ignoring all rebroadcast echos (sender: "
+			"%pM)\n", ethhdr->h_source);

CHECK: Coalesced strings are easier to grep and less error prone
#1043: FILE: bat_iv_ogm.c:1043:
+			"Drop packet: packet within seqno protection time "
+			"(sender: %pM)\n", ethhdr->h_source);

CHECK: Coalesced strings are easier to grep and less error prone
#1065: FILE: bat_iv_ogm.c:1065:
+			"Drop packet: ignoring all rebroadcast packets that "
+			"may make me loop (sender: %pM)\n", ethhdr->h_source);

CHECK: Coalesced strings are easier to grep and less error prone
#1110: FILE: bat_iv_ogm.c:1110:
+		bat_dbg(DBG_BATMAN, bat_priv, "Forwarding packet: "
+			"rebroadcast neighbor packet with direct link flag\n");

total: 0 errors, 0 warnings, 19 checks, 1193 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

bat_iv_ogm.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list