Failed check master bridge_loop_avoidance.c

postmaster at open-mesh.org postmaster at open-mesh.org
Wed Mar 7 00:36:10 CET 2012


CHECK: Don't begin block comments with only a /* line, use /* comment...
#126: FILE: bridge_loop_avoidance.c:126:
+
+/*

CHECK: Don't begin block comments with only a /* line, use /* comment...
#166: FILE: bridge_loop_avoidance.c:166:
+
+/*

CHECK: Don't begin block comments with only a /* line, use /* comment...
#246: FILE: bridge_loop_avoidance.c:246:
+
+/*

CHECK: No space is necessary after a cast
#295: FILE: bridge_loop_avoidance.c:295:
+	ethhdr = (struct ethhdr *)skb->data;
+	hw_src = (uint8_t *) ethhdr + ETH_HLEN + sizeof(struct arphdr);

CHECK: Don't begin block comments with only a /* line, use /* comment...
#356: FILE: bridge_loop_avoidance.c:356:
+
+/*

CHECK: Coalesced strings are easier to grep and less error prone
#379: FILE: bridge_loop_avoidance.c:379:
+		"bla_get_backbone_gw(): not found (%pM, %d),"
+		" creating new entry\n", orig, vid);

CHECK: Don't begin block comments with only a /* line, use /* comment...
#414: FILE: bridge_loop_avoidance.c:414:
+
+/*

CHECK: Don't begin block comments with only a /* line, use /* comment...
#433: FILE: bridge_loop_avoidance.c:433:
+
+/*

CHECK: Coalesced strings are easier to grep and less error prone
#453: FILE: bridge_loop_avoidance.c:453:
+		"bla_answer_request(): received a "
+		"claim request, send all of our own claims again\n");

CHECK: Don't begin block comments with only a /* line, use /* comment...
#481: FILE: bridge_loop_avoidance.c:481:
+
+/*

CHECK: Don't begin block comments with only a /* line, use /* comment...
#509: FILE: bridge_loop_avoidance.c:509:
+
+/*

CHECK: No space is necessary after a cast
#524: FILE: bridge_loop_avoidance.c:524:
+	crc = htons(backbone_gw->crc);
+	memcpy(&mac[4], (uint8_t *) &crc, 2);

CHECK: Don't begin block comments with only a /* line, use /* comment...
#530: FILE: bridge_loop_avoidance.c:530:
+
+/*

CHECK: Don't begin block comments with only a /* line, use /* comment...
#599: FILE: bridge_loop_avoidance.c:599:
+
+/*

CHECK: No space is necessary after a cast
#643: FILE: bridge_loop_avoidance.c:643:
+	backbone_gw->lasttime = jiffies;
+	crc = ntohs(*((uint16_t *) (&an_addr[4])));

CHECK: Coalesced strings are easier to grep and less error prone
#647: FILE: bridge_loop_avoidance.c:647:
+		"handle_announce(): ANNOUNCE vid %d (sent "
+		"by %pM)... CRC = %04x\n",

CHECK: Coalesced strings are easier to grep and less error prone
#653: FILE: bridge_loop_avoidance.c:653:
+			"handle_announce(): CRC FAILED for %pM/%d"
+			"(my = %04x, sent = %04x)\n",

CHECK: Coalesced strings are easier to grep and less error prone
#688: FILE: bridge_loop_avoidance.c:688:
+		"handle_request(): REQUEST vid %d (sent "
+		"by %pM)...\n",

CHECK: Coalesced strings are easier to grep and less error prone
#715: FILE: bridge_loop_avoidance.c:715:
+	bat_dbg(DBG_BLA, bat_priv, "handle_unclaim():"
+		"UNCLAIM %pM on vid %d (sent by %pM)...\n",

CHECK: No space is necessary after a cast
#773: FILE: bridge_loop_avoidance.c:773:
+
+	bla_dst = (struct bla_claim_dst *) hw_dst;

CHECK: Don't begin block comments with only a /* line, use /* comment...
#826: FILE: bridge_loop_avoidance.c:826:
+
+/*

CHECK: No space is necessary after a cast
#853: FILE: bridge_loop_avoidance.c:853:
+	if (ntohs(ethhdr->h_proto) == ETH_P_8021Q) {
+		vhdr = (struct vlan_ethhdr *) ethhdr;

CHECK: No space is necessary after a cast
#871: FILE: bridge_loop_avoidance.c:871:
+	/* pskb_may_pull() may have modified the pointers, get ethhdr again */
+	ethhdr = (struct ethhdr *) skb_mac_header(skb);

CHECK: No space is necessary after a cast
#872: FILE: bridge_loop_avoidance.c:872:
+	ethhdr = (struct ethhdr *) skb_mac_header(skb);
+	arphdr = (struct arphdr *) ((uint8_t *) ethhdr + headlen);

CHECK: No space is necessary after a cast
#888: FILE: bridge_loop_avoidance.c:888:
+	hw_dst = hw_src + ETH_ALEN + 4;
+	bla_dst = (struct bla_claim_dst *) hw_dst;

CHECK: Coalesced strings are easier to grep and less error prone
#894: FILE: bridge_loop_avoidance.c:894:
+		bat_dbg(DBG_BLA, bat_priv, "bla_process_claim(): received "
+			"a claim frame from another group. From: "

CHECK: Coalesced strings are easier to grep and less error prone
#895: FILE: bridge_loop_avoidance.c:895:
+			"a claim frame from another group. From: "
+			"%pM on vid %d ...(hw_src %pM, hw_dst %pM)\n",

CHECK: Coalesced strings are easier to grep and less error prone
#928: FILE: bridge_loop_avoidance.c:928:
+	bat_dbg(DBG_BLA, bat_priv, "bla_process_claim(): ERROR - this looks"
+		"like a claim frame, but is useless. eth src"

CHECK: Coalesced strings are easier to grep and less error prone
#929: FILE: bridge_loop_avoidance.c:929:
+		"like a claim frame, but is useless. eth src"
+		"%pM on vid %d ...(hw_src %pM, hw_dst %pM)\n",

CHECK: Don't begin block comments with only a /* line, use /* comment...
#934: FILE: bridge_loop_avoidance.c:934:
+
+/*

CHECK: Coalesced strings are easier to grep and less error prone
#966: FILE: bridge_loop_avoidance.c:966:
+				"bla_purge_backbone_gw(): backbone gw %pM"
+				" timed out\n",	backbone_gw->orig);

CHECK: Don't begin block comments with only a /* line, use /* comment...
#1092: FILE: bridge_loop_avoidance.c:1092:
+
+/*

CHECK: braces {} should be used on all arms of this statement
#1160: FILE: bridge_loop_avoidance.c:1160:
+	if (primary_if) {
[...]
+	} else
[...]

CHECK: No space is necessary after a cast
#1215: FILE: bridge_loop_avoidance.c:1215:
+	length = hdr_size - sizeof(*bcast_packet);
+	content = (uint8_t *) bcast_packet;

CHECK: No space is necessary after a cast
#1321: FILE: bridge_loop_avoidance.c:1321:
+
+	ethhdr = (struct ethhdr *) (((uint8_t *)skb->data) + hdr_size);

CHECK: No space is necessary after a cast
#1327: FILE: bridge_loop_avoidance.c:1327:
+
+		vhdr = (struct vlan_ethhdr *) (((uint8_t *)skb->data) +

CHECK: Coalesced strings are easier to grep and less error prone
#1555: FILE: bridge_loop_avoidance.c:1555:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - please "
+				 "specify interfaces to enable it\n",

CHECK: Coalesced strings are easier to grep and less error prone
#1562: FILE: bridge_loop_avoidance.c:1562:
+		ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+				 "primary interface not active\n",

CHECK: Coalesced strings are easier to grep and less error prone
#1568: FILE: bridge_loop_avoidance.c:1568:
+	seq_printf(seq, "Claims announced for the mesh %s "
+		   "(orig %pM, group id %04x)\n",

total: 0 errors, 0 warnings, 39 checks, 1592 lines checked

NOTE: Ignored message types: COMPLEX_MACRO

bridge_loop_avoidance.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


More information about the linux-merge mailing list