[commits] [linux-merge]linux integration; branch, merge/master, updated. v3.7-rc1-1513-g889a479

postmaster at open-mesh.org postmaster at open-mesh.org
Mon Oct 15 09:37:08 CEST 2012


The following commit has been merged in the merge/master branch:
commit fb3b8a32736aa6c19c58dc84677e838d1f1ca4c3
Author: Def <def at laposte.net>
Date:   Thu Sep 20 14:56:13 2012 +0200

    batman-adv: Fix change mac address of soft iface.
    
    Into function interface_set_mac_addr, the function tt_local_add was
    invoked before updating dev->dev_addr. The new MAC address was not
    tagged as NoPurge.
    
    Signed-off-by: Def <def at laposte.net>

diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index 7b683e0..b9a28d2 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -107,18 +107,21 @@ static int batadv_interface_set_mac_addr(struct net_device *dev, void *p)
 {
 	struct batadv_priv *bat_priv = netdev_priv(dev);
 	struct sockaddr *addr = p;
+	uint8_t old_addr[ETH_ALEN];
 
 	if (!is_valid_ether_addr(addr->sa_data))
 		return -EADDRNOTAVAIL;
 
+	memcpy(old_addr, dev->dev_addr, ETH_ALEN);
+	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+
 	/* only modify transtable if it has been initialized before */
 	if (atomic_read(&bat_priv->mesh_state) == BATADV_MESH_ACTIVE) {
-		batadv_tt_local_remove(bat_priv, dev->dev_addr,
+		batadv_tt_local_remove(bat_priv, old_addr,
 				       "mac address changed", false);
 		batadv_tt_local_add(dev, addr->sa_data, BATADV_NULL_IFINDEX);
 	}
 
-	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
 	dev->addr_assign_type &= ~NET_ADDR_RANDOM;
 	return 0;
 }

-- 
linux integration


More information about the commits mailing list