[B.A.T.M.A.N.] [PATCH 0/6] batman-adv: Add routeable multicast optimizations

Sven Eckelmann sven at narfation.org
Sun May 5 19:37:48 CEST 2019


On Wednesday, 24 April 2019 03:19:13 CEST Linus Lüssing wrote:
> The following patchset fills the next gaps in the multicast address
> rules page by adding support for group-aware optimizations for
> multicast addresses of scope greater than link-local. So far, only
> link-local addresses were optimized as packets with routeable
> addresses not only need to be forwarded to local multicast listeners
> but also multicast routers.
[...]

I get a lot of build errors when trying to build these patches. Here is the 
complete list, including warnings of other build tests:

Output of different failed tests
================================

ecsv/pu: checkpatch ./net/batman-adv/multicast.c
------------------------------------------------

    CHECK: Blank lines aren't necessary before a close brace '}'
    #791: FILE: ./net/batman-adv/multicast.c:791:
    +
    +}
    
    WARNING: Block comments should align the * on each line
    #799: FILE: ./net/batman-adv/multicast.c:799:
    + * capabilities and inabilities.
    +  */
    
    total: 0 errors, 1 warnings, 1 checks, 2368 lines checked

ecsv/pu: headers
----------------

    diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c
    index ca4898d3..f106728b 100644
    --- a/net/batman-adv/multicast.c
    +++ b/net/batman-adv/multicast.c
    @@ -23,7 +23,6 @@
     #include <linux/inetdevice.h>
     #include <linux/ip.h>
     #include <linux/ipv6.h>
    -#include <linux/jiffies.h>
     #include <linux/kernel.h>
     #include <linux/kref.h>
     #include <linux/list.h>

ecsv/pu: kerneldoc ./net/batman-adv/multicast.c
-----------------------------------------------

    ./net/batman-adv/multicast.c:803: warning: Function parameter or member 'flags' not described in 'batadv_mcast_mla_flags_update'

ecsv/pu: kerneldoc ./net/batman-adv/types.h
-------------------------------------------

    ./net/batman-adv/types.h:1200: warning: Function parameter or member 'tvlv_flags' not described in 'batadv_mcast_mla_flags'

ecsv/pu: kerneldoc include/uapi/linux/batadv_packet.h
-----------------------------------------------------

    include/uapi/linux/batadv_packet.h:124: warning: Enum value 'BATADV_MCAST_WANT_ALL_RTR6' not described in enum 'batadv_mcast_flags'
    include/uapi/linux/batadv_packet.h:124: warning: Excess enum value 'BATADV_MCAST_NO_WANT_ALL_RTR6' description in 'batadv_mcast_flags'

ecsv/pu: sparse linux-3.18 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=n SYSFS=n
---------------------------------------------------------------------------

    In file included from /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/main.h:216:0,
                     from /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/bat_algo.c:7:
    /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/types.h:1255:13: error: duplicate member ‘mla_lock’
      spinlock_t mla_lock;
                 ^~~~~~~~
    make[3]: *** [/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/bat_algo.o] Error 1
    make[2]: *** [/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv] Error 2
    make[1]: *** [_module_/home/build_test/build_env/tmp.2gwYBLVNdO] Error 2
    make: *** [all] Error 2

ecsv/pu: sparse linux-4.14.104 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n TRACING=y NC=n MCAST=y BATMAN_V=y SYSFS=y
---------------------------------------------------------------------------

    In file included from /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/main.h:216:0,
                     from /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/bat_algo.c:7:
    /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/types.h:1255:13: error: duplicate member ‘mla_lock’
      spinlock_t mla_lock;
                 ^~~~~~~~
    make[3]: *** [/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/bat_algo.o] Error 1
    make[2]: *** [/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv] Error 2
    make[1]: *** [_module_/home/build_test/build_env/tmp.2gwYBLVNdO] Error 2
    make: *** [all] Error 2

Kind regards,
	Sven
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/attachments/20190505/f603bb52/attachment.sig>


More information about the B.A.T.M.A.N mailing list