[B.A.T.M.A.N.] Antwort: [PATCH-maintv2] batman-adv: replace WARN with rate limited output on non-existing VLAN

Simon Wunderlich sw at simonwunderlich.de
Fri May 20 12:34:19 CEST 2016


Hi Andreas,

On Friday 20 May 2016 12:05:35 Andreas Pape wrote:
> Hi,
> 
> this is a point I also stumbled across. In my use case the problem is a
> little bit
> more difficult.
> I use a setup with bat interfaces bridged to ethernet interfaces and my
> mesh nodes
> shall forward layer2 transparently network traffic from the wired network
> into the
> mesh.
> 
> My problem now is that among the layer2 traffic there are also vlan tagged
> frames
> whereas the bat interface isn't member of the vlan to be forwarded itself.
> 
> More specific in my case the frames use vlan id 0 and are tagged mainly
> due to the
> reason to guarantee some QoS in the wired network.
> 
> Yes, I know one might argue what reason QoS priority tagging has in mesh
> setups, but
> these frames are not generated by my devices but I have to forward them
> "as they are".
> 
> As far as I understood the code, these frames do not only lead to the WARN
> messages
> (and there I welcome Simon's patch) but also lead to a drop of the tagged
> packets
> (correct ?). If I understood this correctly I would prefer that batman
> would handle
> vlan tagged packets on layer 2 like an unmanaged switch does: still
> forward such
> packets according to the mac header.
> 
> What do you think?

I completely agree, this is what I'd expect from batman-adv to do. However, 
currently this isn't the case as you have noticed already.

As a workaround, you could create vlan interfaces like bat0.0 and eth0.0 and 
bridge those.

However in the long run, I think we should change the TT/VLAN code to create 
vlan objects on the fly when we get packets and remove those vlan objects when 
the corresponding TT local entries are gone (and no VLAN is actually 
configured). I've put this on my list of things I'll try to work on at some 
point, if anyone wants to prepare a patch before me please go ahead ... :)

Cheers,
      Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/attachments/20160520/c35b1805/attachment.sig>


More information about the B.A.T.M.A.N mailing list