[B.A.T.M.A.N.] [PATCH net] batman-adv: Fix memory leak on tt add with invalid vlan

David Miller davem at davemloft.net
Wed Aug 19 04:08:40 CEST 2015


From: Sven Eckelmann <sven at narfation.org>
Date: Tue, 18 Aug 2015 13:37:01 +0200

> The object tt_local is allocated with kmalloc and not initialized when the
> function batadv_tt_local_add checks for the vlan. But this function can
> only cleanup the object when the (not yet initialized) reference counter of
> the object is 1. This is unlikely and thus the object would leak when the
> vlan could not be found.
> 
> Instead the uninitialized object tt_local has to be freed manually and the
> pointer has to set to NULL to avoid calling the function which would try to
> decrement the reference counter of the not existing object.
> 
> CID: 1316518
> Fixes: 354136bcc3c4 ("batman-adv: fix kernel crash due to missing NULL checks")
> Signed-off-by: Sven Eckelmann <sven at narfation.org>

Applied, thanks.


More information about the B.A.T.M.A.N mailing list