[B.A.T.M.A.N.] [PATCH 3/4] batman-adv: Use {} braces consistent on the arms of a statement

David Laight David.Laight at ACULAB.COM
Mon Mar 12 14:16:43 CET 2012


 
> diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
> index 01b66d4..7f8e158 100644
> --- a/net/batman-adv/routing.c
> +++ b/net/batman-adv/routing.c
> @@ -237,8 +237,9 @@ int window_protected(struct bat_priv 
> *bat_priv, int32_t seq_num_diff,
>  				"old packet received, start
protection\n");
>  
>  			return 0;
> -		} else
> +		} else {
>  			return 1;
> +		}
>  	}
>  	return 0;
>  }

Doesn't this one fail on the "don't use 'else' after return/break" ?
Also look like it would read better if the condition (not quoted)
were inverted and the 'return 1' put first.

	David




More information about the B.A.T.M.A.N mailing list