[B.A.T.M.A.N.] [PATCH] Staging: batman-adv: bonding and interface alternating

Sven Eckelmann sven.eckelmann at gmx.de
Wed May 26 12:39:22 CEST 2010


Only some non-technical comments about the patch for now:

I thought we decided that the "Staging: " part in the title will be appended 
when the stuff will be send to Greg and should be omitted inside our source 
trees. Also your patch wouldn't apply in linux-next because the bonding stuff 
is in master and not in maint (only maint will be send to the kernel folks).

> This is an experimental patch and targeted for upcoming experiments at
> Wireless Battle Mesh v3 in Bracciano/Italy.
> 
> Feedback, comments and reviews appreciated!

That part is quite interesting for the mailinglist but should not be part of 
the commit message, or am I wrong? In that situation such information should 
be appended after the "---". git-am or similar tools should automatically 
ignore that parts, but the receiver can still read that comment.

> Index: a/batman-adv-kernelland/main.h
> ===================================================================
> --- a/batman-adv-kernelland/main.h	(revision 1679)
> +++ a/batman-adv-kernelland/main.h	(working copy)
> @@ -63,6 +63,10 @@
>   * to be considered as bonding candidates */
> 
>  #define BONDING_TQ_THRESHOLD	50
> +#define BONDING_NONE		0
> +#define BONDING_ROUNDROBIN 	1

You've wrote something like "space""tab""1" here. Can you please remove the 
space before the tab.

Have you already painted some nice graphics or wrote some text to explain the 
modes further (yes, code is the best documentation, but a bad specification)?

The rest looks like it should be tested in italy :)

Best regards,
	Sven
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/attachments/20100526/4cde1af1/attachment.pgp>


More information about the B.A.T.M.A.N mailing list