linux-merge March 2012

linux-merge@lists.open-mesh.org

2 participants
186 discussions

Failed check master unicast.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: No space is necessary after a cast #69: FILE: unicast.c:69: + memmove(skb->data + uni_diff, skb->data, hdr_len); + unicast_packet = (struct unicast_packet *) skb_pull(skb, uni_diff); CHECK: No space is necessary after a cast #241: FILE: unicast.c:241: + + unicast_packet = (struct unicast_packet *) skb->data; total: 0 errors, 0 warnings, 2 checks, 418 lines checked NOTE: Ignored message types: COMPLEX_MACRO unicast.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master translation-table.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #338: FILE: translation-table.c:338: + ret = seq_printf(seq, "BATMAN mesh %s disabled - " + "please specify interfaces to enable it\n", CHECK: Coalesced strings are easier to grep and less error prone #345: FILE: translation-table.c:345: + ret = seq_printf(seq, "BATMAN mesh %s disabled - " + "primary interface not active\n", CHECK: Coalesced strings are easier to grep and less error prone #351: FILE: translation-table.c:351: + seq_printf(seq, "Locally retrieved addresses (from %s) " + "announced via TT (TTVN: %u):\n", CHECK: Coalesced strings are easier to grep and less error prone #394: FILE: translation-table.c:394: + bat_dbg(DBG_TT, bat_priv, "Local tt entry (%pM) pending to be removed: " + "%s\n", tt_local_entry->common.addr, message); CHECK: Don't begin block comments with only a /* line, use /* comment... #601: FILE: translation-table.c:601: + + /* CHECK: Don't begin block comments with only a /* line, use /* comment... #638: FILE: translation-table.c:638: + +/* CHECK: Coalesced strings are easier to grep and less error prone #660: FILE: translation-table.c:660: + seq_printf(seq, " * %pM (%3u) via %pM (%3u) " + "[%c%c]\n", tt_global_entry->common.addr, CHECK: Coalesced strings are easier to grep and less error prone #684: FILE: translation-table.c:684: + ret = seq_printf(seq, "BATMAN mesh %s disabled - please " + "specify interfaces to enable it\n", CHECK: Coalesced strings are easier to grep and less error prone #691: FILE: translation-table.c:691: + ret = seq_printf(seq, "BATMAN mesh %s disabled - " + "primary interface not active\n", CHECK: Don't begin block comments with only a /* line, use /* comment... #776: FILE: translation-table.c:776: + +/* CHECK: Don't begin block comments with only a /* line, use /* comment... #791: FILE: translation-table.c:791: + + /* CHECK: Coalesced strings are easier to grep and less error prone #944: FILE: translation-table.c:944: + bat_dbg(DBG_TT, bat_priv, "Deleting global " + "tt entry (%pM): Roaming timeout\n", CHECK: Coalesced strings are easier to grep and less error prone #1353: FILE: translation-table.c:1353: + bat_dbg(DBG_TT, bat_priv, "Sending TT_REQUEST to %pM via %pM " + "[%c]\n", dst_orig_node->orig, neigh_node->addr, CHECK: Coalesced strings are easier to grep and less error prone #1391: FILE: translation-table.c:1391: + "Received TT_REQUEST from %pM for " + "ttvn: %u (%pM) [%c]\n", tt_request->src, CHECK: Coalesced strings are easier to grep and less error prone #1518: FILE: translation-table.c:1518: + "Received TT_REQUEST from %pM for " + "ttvn: %u (me) [%c]\n", tt_request->src, CHECK: braces {} should be used on all arms of this statement #1620: FILE: translation-table.c:1620: + if (is_my_mac(tt_request->dst)) { [...] + } else [...] CHECK: Coalesced strings are easier to grep and less error prone #1727: FILE: translation-table.c:1727: + bat_dbg(DBG_TT, bat_priv, "Received TT_RESPONSE from %pM for " + "ttvn %d t_size: %d [%c]\n", CHECK: Coalesced strings are easier to grep and less error prone #1998: FILE: translation-table.c:1998: + bat_dbg(DBG_TT, bat_priv, "Deleting local tt entry " + "(%pM): pending\n", tt_common_entry->addr); CHECK: Coalesced strings are easier to grep and less error prone #2111: FILE: translation-table.c:2111: + bat_dbg(DBG_TT, bat_priv, "TT inconsistency for %pM. " + "Need to retrieve the correct information " CHECK: Coalesced strings are easier to grep and less error prone #2112: FILE: translation-table.c:2112: + "Need to retrieve the correct information " + "(ttvn: %u last_ttvn: %u crc: %u last_crc: " CHECK: Coalesced strings are easier to grep and less error prone #2113: FILE: translation-table.c:2113: + "(ttvn: %u last_ttvn: %u crc: %u last_crc: " + "%u num_changes: %u)\n", orig_node->orig, ttvn, total: 0 errors, 0 warnings, 21 checks, 2121 lines checked NOTE: Ignored message types: COMPLEX_MACRO translation-table.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master types.h
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Don't begin block comments with only a /* line, use /* comment... #32: FILE: types.h:32: + +/* total: 0 errors, 0 warnings, 1 checks, 418 lines checked NOTE: Ignored message types: COMPLEX_MACRO types.h has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master send.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #50: FILE: send.c:50: + pr_warning("Interface %s is not up - can't send packet via " + "that interface!\n", hard_iface->net_dev->name); CHECK: No space is necessary after a cast #60: FILE: send.c:60: + + ethhdr = (struct ethhdr *) skb_mac_header(skb); total: 0 errors, 0 warnings, 2 checks, 414 lines checked NOTE: Ignored message types: COMPLEX_MACRO send.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master routing.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #91: FILE: routing.c:91: + "Changing route towards: %pM " + "(now via %pM - was via %pM)\n", CHECK: braces {} should be used on all arms of this statement #238: FILE: routing.c:238: + if (has_timed_out(*last_reset, RESET_PROTECTION_MS)) { [...] + } else [...] CHECK: Coalesced strings are easier to grep and less error prone #351: FILE: routing.c:351: + pr_debug("Warning - can't forward icmp packet from %pM to " + "%pM: ttl exceeded\n", icmp_packet->orig, CHECK: Coalesced strings are easier to grep and less error prone #686: FILE: routing.c:686: + bat_dbg(DBG_TT, bat_priv, "Received ROAMING_ADV from %pM " + "(client %pM)\n", roam_adv_packet->src, CHECK: Coalesced strings are easier to grep and less error prone #825: FILE: routing.c:825: + pr_debug("Warning - can't forward unicast packet from %pM to " + "%pM: ttl exceeded\n", ethhdr->h_source, CHECK: Coalesced strings are easier to grep and less error prone #946: FILE: routing.c:946: + bat_dbg(DBG_ROUTES, bat_priv, "TTVN mismatch (old_ttvn %u " + "new_ttvn %u)! Rerouting unicast packet (for %pM) to " CHECK: Coalesced strings are easier to grep and less error prone #947: FILE: routing.c:947: + "new_ttvn %u)! Rerouting unicast packet (for %pM) to " + "%pM\n", unicast_packet->ttvn, curr_ttvn, total: 0 errors, 0 warnings, 7 checks, 1153 lines checked NOTE: Ignored message types: COMPLEX_MACRO routing.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master main.h
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Don't begin block comments with only a /* line, use /* comment... #125: FILE: main.h:125: + +/* CHECK: Don't begin block comments with only a /* line, use /* comment... #145: FILE: main.h:145: + +/* CHECK: Don't begin block comments with only a /* line, use /* comment... #149: FILE: main.h:149: + +/* total: 0 errors, 0 warnings, 3 checks, 271 lines checked NOTE: Ignored message types: COMPLEX_MACRO main.h has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master originator.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #298: FILE: originator.c:298: + "neighbor purge: originator %pM, " + "neighbor: %pM, iface: %s\n", CHECK: Coalesced strings are easier to grep and less error prone #304: FILE: originator.c:304: + "neighbor timeout: originator %pM, " + "neighbor: %pM, last_seen: %u\n", CHECK: Coalesced strings are easier to grep and less error prone #419: FILE: originator.c:419: + ret = seq_printf(seq, "BATMAN mesh %s disabled - " + "please specify interfaces to enable it\n", CHECK: Coalesced strings are easier to grep and less error prone #426: FILE: originator.c:426: + ret = seq_printf(seq, "BATMAN mesh %s " + "disabled - primary interface not active\n", total: 0 errors, 0 warnings, 4 checks, 646 lines checked NOTE: Ignored message types: COMPLEX_MACRO originator.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master icmp_socket.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #63: FILE: icmp_socket.c:63: + pr_err("Error - can't add another packet client: " + "maximum number of clients reached\n"); CHECK: Coalesced strings are easier to grep and less error prone #166: FILE: icmp_socket.c:166: + "Error - can't send packet from char device: " + "invalid packet size\n"); CHECK: Coalesced strings are easier to grep and less error prone #197: FILE: icmp_socket.c:197: + "Error - can't send packet from char device: " + "got bogus packet type (expected: BAT_ICMP)\n"); CHECK: Coalesced strings are easier to grep and less error prone #205: FILE: icmp_socket.c:205: + "Error - can't send packet from char device: " + "got bogus message type (expected: ECHO_REQUEST)\n"); total: 0 errors, 0 warnings, 4 checks, 350 lines checked NOTE: Ignored message types: COMPLEX_MACRO icmp_socket.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master main.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #74: FILE: main.c:74: + pr_info("B.A.T.M.A.N. advanced %s (compatibility version %i) " + "loaded\n", SOURCE_VERSION, COMPAT_VERSION); CHECK: Coalesced strings are easier to grep and less error prone #322: FILE: main.c:322: + pr_info("Trying to register already registered routing " + "algorithm: %s\n", bat_algo_ops->name); total: 0 errors, 0 warnings, 2 checks, 408 lines checked NOTE: Ignored message types: COMPLEX_MACRO main.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master hard-interface.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #180: FILE: hard-interface.c:180: + pr_warning("The newly added mac address (%pM) already exists " + "on: %s\n", net_dev->dev_addr, CHECK: Coalesced strings are easier to grep and less error prone #183: FILE: hard-interface.c:183: + pr_warning("It is strongly recommended to keep mac addresses " + "unique to avoid problems!\n"); CHECK: Coalesced strings are easier to grep and less error prone #287: FILE: hard-interface.c:287: + pr_err("You are about to enable batman-adv on '%s' which " + "already is part of a bridge. Unless you know exactly " CHECK: Coalesced strings are easier to grep and less error prone #288: FILE: hard-interface.c:288: + "already is part of a bridge. Unless you know exactly " + "what you are doing this is probably wrong and won't " CHECK: Coalesced strings are easier to grep and less error prone #289: FILE: hard-interface.c:289: + "what you are doing this is probably wrong and won't " + "work the way you think it would.\n", CHECK: Coalesced strings are easier to grep and less error prone #308: FILE: hard-interface.c:308: + pr_err("Can't create batman mesh interface %s: " + "already exists as regular interface\n", CHECK: Coalesced strings are easier to grep and less error prone #341: FILE: hard-interface.c:341: + "The MTU of interface %s is too small (%i) to handle " + "the transport of batman-adv packets. Packets going " CHECK: Coalesced strings are easier to grep and less error prone #342: FILE: hard-interface.c:342: + "the transport of batman-adv packets. Packets going " + "over this interface will be fragmented on layer2 " CHECK: Coalesced strings are easier to grep and less error prone #343: FILE: hard-interface.c:343: + "over this interface will be fragmented on layer2 " + "which could impact the performance. Setting the MTU " CHECK: Coalesced strings are easier to grep and less error prone #344: FILE: hard-interface.c:344: + "which could impact the performance. Setting the MTU " + "to %zi would solve the problem.\n", CHECK: Coalesced strings are easier to grep and less error prone #352: FILE: hard-interface.c:352: + "The MTU of interface %s is too small (%i) to handle " + "the transport of batman-adv packets. If you " CHECK: Coalesced strings are easier to grep and less error prone #353: FILE: hard-interface.c:353: + "the transport of batman-adv packets. If you " + "experience problems getting traffic through try " CHECK: Coalesced strings are easier to grep and less error prone #354: FILE: hard-interface.c:354: + "experience problems getting traffic through try " + "increasing the MTU to %zi.\n", CHECK: Coalesced strings are easier to grep and less error prone #362: FILE: hard-interface.c:362: + bat_err(hard_iface->soft_iface, "Not using interface %s " + "(retrying later): interface not active\n", total: 0 errors, 0 warnings, 14 checks, 596 lines checked NOTE: Ignored message types: COMPLEX_MACRO hard-interface.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
19
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linux-merge March 2012