[batman-adv] next: batman-adv: use batadv_compare_eth for concise (77c2a6c) - commits - lists.open-mesh.org

5 Jan 2014

Repository : ssh://git@open-mesh.org/batman-adv
On branch  : next
...

commit 77c2a6c858270cc3802595b45b14d76e92401568
Author: Ding Tianhong dingtianhong@huawei.com
Date:   Thu Dec 26 19:40:39 2013 +0800
batman-adv: use batadv_compare_eth for concise
It is better to use batadv_compate_eth instead of memcpy for
    concise style.
Cc: Marek Lindner mareklindner@neomailbox.ch
    Cc: Simon Wunderlich sw@simonwunderlich.de
    Cc: Antonio Quartulli antonio@meshcoding.com
    Cc: "David S. Miller" davem@davemloft.net
    Cc: b.a.t.m.a.n@lists.open-mesh.org
    Cc: netdev@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Tan Xiaojun tanxiaojun@huawei.com
    Signed-off-by: Ding Tianhong dingtianhong@huawei.com
    Acked-by: Antonio Quartulli antonio@meshcoding.com
    Signed-off-by: Marek Lindner mareklindner@neomailbox.ch
...

77c2a6c858270cc3802595b45b14d76e92401568
 originator.c        |    2 +-
 translation-table.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/originator.c b/originator.c
index 1247f8a..e2400b6 100644
--- a/originator.c
+++ b/originator.c
@@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2)
    const void *data1 = container_of(node, struct batadv_orig_node,
    				 hash_entry);
-	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+	return batadv_compare_eth(data1, data2);
 }
/**
diff --git a/translation-table.c b/translation-table.c
index 2412f50..3fca99d 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -51,7 +51,7 @@ static int batadv_compare_tt(const struct hlist_node *node, const void *data2)
    const void *data1 = container_of(node, struct batadv_tt_common_entry,
    				 hash_entry);
-	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+	return batadv_compare_eth(data1, data2);
 }
/**

    