Repository : ssh://git@open-mesh.org/batman-adv
On branches: ecsv/genl,master,next
commit f0f80621705b629aa04ca90411633b9b3dd3c61f Author: Johannes Berg johannes.berg@intel.com Date: Mon Oct 24 14:40:03 2016 +0200
batman-adv: genetlink: statically initialize families
Instead of providing macros/inline functions to initialize the families, make all users initialize them statically and get rid of the macros.
This reduces the kernel code size by about 1.6k on x86-64 (with allyesconfig).
Signed-off-by: Johannes Berg johannes.berg@intel.com Signed-off-by: David S. Miller davem@davemloft.net [sven@narfation.org: adjust compat code] Signed-off-by: Sven Eckelmann sven@narfation.org
f0f80621705b629aa04ca90411633b9b3dd3c61f compat-include/net/genetlink.h | 21 ++------------------- net/batman-adv/netlink.c | 25 +++++++++++++++---------- 2 files changed, 17 insertions(+), 29 deletions(-)
diff --git a/compat-include/net/genetlink.h b/compat-include/net/genetlink.h index 6a287e6..b057e6c 100644 --- a/compat-include/net/genetlink.h +++ b/compat-include/net/genetlink.h @@ -96,11 +96,6 @@ batadv_genlmsg_multicast_netns(struct batadv_genl_family *family, #define genl_unregister_family(_family) \ genl_unregister_family(&(_family)->family)
-#define genl_register_family_with_ops_groups(family, ops, grps) \ - batadv_genl_register_family_with_ops_grps((family), \ - (ops), ARRAY_SIZE(ops), \ - (grps), ARRAY_SIZE(grps)) - static inline int batadv_genl_register_family(struct genl_family *family) { unsigned int i; @@ -148,20 +143,8 @@ static inline int batadv_genl_register_family(struct genl_family *family) return ret; }
-static inline int -batadv_genl_register_family_with_ops_grps(struct genl_family *family, - struct genl_ops *ops, size_t n_ops, - struct genl_multicast_group *mcgrps, - size_t n_mcgrps) -{ - family->ops = ops; - family->n_ops = n_ops; - family->mcgrps = mcgrps; - family->n_mcgrps = n_mcgrps; - family->module = THIS_MODULE; - - return batadv_genl_register_family(family); -} +#define genl_register_family(family) \ + batadv_genl_register_family((family))
#define __genl_const
diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c index a951e02..5dfc5c4 100644 --- a/net/batman-adv/netlink.c +++ b/net/batman-adv/netlink.c @@ -48,13 +48,7 @@ #include "tp_meter.h" #include "translation-table.h"
-struct genl_family batadv_netlink_family = { - .hdrsize = 0, - .name = BATADV_NL_NAME, - .version = 1, - .maxattr = BATADV_ATTR_MAX, - .netnsok = true, -}; +struct genl_family batadv_netlink_family;
/* multicast groups */ enum batadv_netlink_multicast_groups { @@ -609,6 +603,19 @@ static const struct genl_ops batadv_netlink_ops[] = {
};
+struct genl_family batadv_netlink_family = { + .hdrsize = 0, + .name = BATADV_NL_NAME, + .version = 1, + .maxattr = BATADV_ATTR_MAX, + .netnsok = true, + .module = THIS_MODULE, + .ops = batadv_netlink_ops, + .n_ops = ARRAY_SIZE(batadv_netlink_ops), + .mcgrps = batadv_netlink_mcgrps, + .n_mcgrps = ARRAY_SIZE(batadv_netlink_mcgrps), +}; + /** * batadv_netlink_register - register batadv genl netlink family */ @@ -616,9 +623,7 @@ void __init batadv_netlink_register(void) { int ret;
- ret = genl_register_family_with_ops_groups(&batadv_netlink_family, - batadv_netlink_ops, - batadv_netlink_mcgrps); + ret = genl_register_family(&batadv_netlink_family); if (ret) pr_warn("unable to register netlink family"); }