commits September 2013

commits@lists.open-mesh.org

1 participants
91 discussions

[batmand] master: The types for the format string did not always match the type of the parameter. This can lead to wrong output or crashes. There is also no '' format string but a thousand format string. But this thousand ' is not ISO C and doesn't work with all libc implementations. And the thousand ' is not supported for strings. (f420262)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit f420262ee5b730525d25e916db8ea6dd725f462a Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:43:18 2013 +0200 The types for the format string did not always match the type of the parameter. This can lead to wrong output or crashes. There is also no '' format string but a thousand format string. But this thousand ' is not ISO C and doesn't work with all libc implementations. And the thousand ' is not supported for strings. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- f420262ee5b730525d25e916db8ea6dd725f462a allocate.c | 2 +- originator.c | 12 ++++++------ os.h | 2 +- posix/unix_socket.c | 2 +- profile.c | 3 ++- 5 files changed, 11 insertions(+), 10 deletions(-) diff --git a/allocate.c b/allocate.c index 57a4894..beedafe 100644 --- a/allocate.c +++ b/allocate.c @@ -210,7 +210,7 @@ void checkIntegrity(void) for ( memoryWalker = memoryList; memoryWalker != NULL; memoryWalker = memoryWalker->next ) { if ( memoryWalker->counter != 0 ) - debug_output( 5, " tag: %''4i, num malloc: %4i, bytes per malloc: %''4i, total: %6i\n", memoryWalker->tag, memoryWalker->counter, memoryWalker->length, memoryWalker->counter * memoryWalker->length ); + debug_output( 5, " tag: %4i, num malloc: %4i, bytes per malloc: %4i, total: %6i\n", memoryWalker->tag, memoryWalker->counter, memoryWalker->length, memoryWalker->counter * memoryWalker->length ); } pthread_mutex_unlock(&memory_mutex); diff --git a/originator.c b/originator.c index f58bbcf..7de0e4d 100644 --- a/originator.c +++ b/originator.c @@ -423,7 +423,7 @@ void debug_orig(void) { uptime_sec = (uint64_t)(get_time_msec64() / 1000); debug_output(2, "BOD\n"); - debug_output(2, "%''12s (%s/%i) %''15s [%10s], gw_class ... [B.A.T.M.A.N. %s, MainIF/IP: %s/%s, UT: %id%2ih%2im] \n", "Gateway", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF", SOURCE_VERSION, ((struct batman_if *)if_list.next)->dev, orig_str, (uint32_t)(uptime_sec/86400), (uint32_t)((uptime_sec%86400)/3600), (uint32_t)((uptime_sec%3600)/60)); + debug_output(2, "%12s (%s/%i) %15s [%10s], gw_class ... [B.A.T.M.A.N. %s, MainIF/IP: %s/%s, UT: %id%2ih%2im] \n", "Gateway", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF", SOURCE_VERSION, ((struct batman_if *)if_list.next)->dev, orig_str, (uint32_t)(uptime_sec/86400), (uint32_t)((uptime_sec%86400)/3600), (uint32_t)((uptime_sec%3600)/60)); if ( list_empty( &gw_list ) ) { @@ -446,7 +446,7 @@ void debug_orig(void) { get_gw_speeds( gw_node->orig_node->gwflags, &download_speed, &upload_speed ); - debug_output(2, "%s %-15s (%3i) %''15s [%10s], gw_class %3i - %i%s/%i%s, gateway failures: %i \n", ( curr_gateway == gw_node ? "=>" : " " ), str, gw_node->orig_node->router->tq_avg, str2, gw_node->orig_node->router->if_incoming->dev, gw_node->orig_node->gwflags, (download_speed > 2048 ? download_speed / 1024 : download_speed), (download_speed > 2048 ? "MBit" : "KBit"), (upload_speed > 2048 ? upload_speed / 1024 : upload_speed), (upload_speed > 2048 ? "MBit" : "KBit"), gw_node->gw_failure); + debug_output(2, "%s %-15s (%3i) %15s [%10s], gw_class %3i - %i%s/%i%s, gateway failures: %i \n", ( curr_gateway == gw_node ? "=>" : " " ), str, gw_node->orig_node->router->tq_avg, str2, gw_node->orig_node->router->if_incoming->dev, gw_node->orig_node->gwflags, (download_speed > 2048 ? download_speed / 1024 : download_speed), (download_speed > 2048 ? "MBit" : "KBit"), (upload_speed > 2048 ? upload_speed / 1024 : upload_speed), (upload_speed > 2048 ? "MBit" : "KBit"), gw_node->gw_failure); batman_count++; @@ -467,7 +467,7 @@ void debug_orig(void) { uptime_sec = (uint64_t)(get_time_msec64() / 1000); debug_output(1, "BOD \n"); - debug_output(1, " %-11s (%s/%i) %''15s [%10s]: %''20s ... [B.A.T.M.A.N. %s, MainIF/IP: %s/%s, UT: %id%2ih%2im] \n", "Originator", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF", "Potential nexthops", SOURCE_VERSION, ((struct batman_if *)if_list.next)->dev, orig_str, (uint32_t)(uptime_sec/86400), (uint32_t)((uptime_sec%86400)/3600), (uint32_t)((uptime_sec%3600)/60)); + debug_output(1, " %-11s (%s/%i) %15s [%10s]: %20s ... [B.A.T.M.A.N. %s, MainIF/IP: %s/%s, UT: %id%2ih%2im] \n", "Originator", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF", "Potential nexthops", SOURCE_VERSION, ((struct batman_if *)if_list.next)->dev, orig_str, (uint32_t)(uptime_sec/86400), (uint32_t)((uptime_sec%86400)/3600), (uint32_t)((uptime_sec%3600)/60)); if ( debug_clients.clients_num[3] > 0 ) { @@ -481,7 +481,7 @@ void debug_orig(void) { } debug_output( 4, "Originator list \n" ); - debug_output( 4, " %-11s (%s/%i) %''15s [%10s]: %''20s\n", "Originator", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF", "Potential nexthops" ); + debug_output( 4, " %-11s (%s/%i) %15s [%10s]: %20s\n", "Originator", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF", "Potential nexthops" ); } @@ -497,8 +497,8 @@ void debug_orig(void) { addr_to_string( orig_node->orig, str, sizeof (str) ); addr_to_string( orig_node->router->addr, str2, sizeof (str2) ); - debug_output( 1, "%-15s (%3i) %''15s [%10s]:", str, orig_node->router->tq_avg, str2, orig_node->router->if_incoming->dev ); - debug_output( 4, "%''15s (%3i) %''15s [%10s], last_valid: %u: \n", str, orig_node->router->tq_avg, str2, orig_node->router->if_incoming->dev, orig_node->last_valid ); + debug_output( 1, "%-15s (%3i) %15s [%10s]:", str, orig_node->router->tq_avg, str2, orig_node->router->if_incoming->dev ); + debug_output( 4, "%15s (%3i) %15s [%10s], last_valid: %u: \n", str, orig_node->router->tq_avg, str2, orig_node->router->if_incoming->dev, orig_node->last_valid ); debug_out_size = 0; diff --git a/os.h b/os.h index 2f2b2df..2272030 100644 --- a/os.h +++ b/os.h @@ -96,7 +96,7 @@ void *client_to_gw_tun( void *arg ); /* unix_sokcet.c */ void *unix_listen( void *arg ); void internal_output(uint32_t sock); -void debug_output( int8_t debug_prio, const char *format, ... ); +void debug_output( int8_t debug_prio, const char *format, ... ) __attribute__ ((format (printf, 2, 3))); #endif diff --git a/posix/unix_socket.c b/posix/unix_socket.c index 11c5d3e..fc9983b 100644 --- a/posix/unix_socket.c +++ b/posix/unix_socket.c @@ -347,7 +347,7 @@ void *unix_listen(void * BATMANUNUSED(arg)) { } else if ( buff[0] == 'q' ) { if ( status > 2 ) { - debug_output(3, "Unix socket: changing purge timeout from: %i to: %i\n", purge_timeout, strtol(buff + 2, NULL, 10)); + debug_output(3, "Unix socket: changing purge timeout from: %i to: %li\n", purge_timeout, strtol(buff + 2, NULL, 10)); purge_timeout = strtol(buff + 2, NULL, 10); } diff --git a/profile.c b/profile.c index c76ae8d..11d8aa9 100644 --- a/profile.c +++ b/profile.c @@ -23,6 +23,7 @@ #include "os.h" #include "batman.h" +#include <inttypes.h> @@ -67,7 +68,7 @@ void prof_print(void) { for ( index = 0; index < PROF_COUNT; index++ ) { - debug_output( 5, " %''30s: cpu time = %10.3f, calls = %''10i, avg time per call = %4.10f \n", prof_container[index].name, (float)prof_container[index].total_time/CLOCKS_PER_SEC, prof_container[index].calls, ( prof_container[index].calls == 0 ? 0.0 : ( ( (float)prof_container[index].total_time/CLOCKS_PER_SEC ) / (float)prof_container[index].calls ) ) ); + debug_output( 5, " %30s: cpu time = %10.3f, calls = %10"PRId64", avg time per call = %4.10f \n", prof_container[index].name, (float)prof_container[index].total_time/CLOCKS_PER_SEC, prof_container[index].calls, ( prof_container[index].calls == 0 ? 0.0 : ( ( (float)prof_container[index].total_time/CLOCKS_PER_SEC ) / (float)prof_container[index].calls ) ) ); }

1 0

[batmand] master: It is not necessary to call an external binary to clear the screen of a default unix terminal emulator. The external call using system("clear") may be used by an attacker to get untrusted code called with an higher privilege because batmand has to be run using uid 0. (58480ca)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit 58480ca5e0086449d41425bcd2e48ee948c5b8db Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:43:48 2013 +0200 It is not necessary to call an external binary to clear the screen of a default unix terminal emulator. The external call using system("clear") may be used by an attacker to get untrusted code called with an higher privilege because batmand has to be run using uid 0. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 58480ca5e0086449d41425bcd2e48ee948c5b8db posix/init.c | 3 ++- posix/posix.c | 3 ++- posix/unix_socket.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/posix/init.c b/posix/init.c index 9cefe73..308e476 100644 --- a/posix/init.c +++ b/posix/init.c @@ -719,7 +719,8 @@ more_hna: } else if ( strncmp( buff_ptr, "BOD", 3 ) == 0 ) { if ( !batch_mode ) - system( "clear" ); + /* clear screen, set cursor back to 0,0 */ + printf("\033[2J\033[0;0f"); } else { diff --git a/posix/posix.c b/posix/posix.c index 81cd2e1..5cdf417 100644 --- a/posix/posix.c +++ b/posix/posix.c @@ -181,7 +181,8 @@ static void bat_wait( int32_t T, int32_t t ) { void print_animation( void ) { - system( "clear" ); + /* clear screen, set cursor back to 0,0 */ + printf("\033[2J\033[0;0f"); BAT_LOGO_END( 0, 50 ); sym_print( 0, 3, "." ); diff --git a/posix/unix_socket.c b/posix/unix_socket.c index fc9983b..11c96b2 100644 --- a/posix/unix_socket.c +++ b/posix/unix_socket.c @@ -100,7 +100,8 @@ void debug_output(int8_t debug_prio, const char *format, ...) { dprintf(debug_level_info->fd, "[%10u] ", get_time_msec()); if (((debug_level == 1) || (debug_level == 2)) && (debug_level_info->fd == 1) && (strncmp(format, "BOD", 3) == 0)) - system("clear"); + /* clear screen, set cursor back to 0,0 */ + printf("\033[2J\033[0;0f"); if (((debug_level != 1) && (debug_level != 2)) || (debug_level_info->fd != 1) || (strncmp(format, "EOD", 3) != 0)) vdprintf(debug_level_info->fd, format, args);

1 0

[batmand] master: Use POSIX daemon function instead of self-written one (e22dd23)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit e22dd235a9fcf002bc504c812e94a89586f7a486 Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:44:36 2013 +0200 Use POSIX daemon function instead of self-written one Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- e22dd235a9fcf002bc504c812e94a89586f7a486 posix/init.c | 45 ++------------------------------------------- 1 file changed, 2 insertions(+), 43 deletions(-) diff --git a/posix/init.c b/posix/init.c index 308e476..3bc54b0 100644 --- a/posix/init.c +++ b/posix/init.c @@ -35,6 +35,7 @@ #include <arpa/inet.h> #include <fcntl.h> #include <getopt.h> +#include <unistd.h> #include "../os.h" @@ -44,48 +45,6 @@ int8_t stop; - -static int my_daemon(void) { - - int fd; - - switch( fork() ) { - - case -1: - return -1; - - case 0: - break; - - default: - exit(EXIT_SUCCESS); - - } - - if ( setsid() == -1 ) - return(-1); - - /* Make certain we are not a session leader, or else we might reacquire a controlling terminal */ - if ( fork() ) - exit(EXIT_SUCCESS); - - chdir( "/" ); - - if ( ( fd = open(_PATH_DEVNULL, O_RDWR, 0) ) != -1 ) { - - dup2(fd, STDIN_FILENO); - dup2(fd, STDOUT_FILENO); - dup2(fd, STDERR_FILENO); - - if ( fd > 2 ) - close(fd); - - } - - return 0; - -} - static void create_routing_pipe(void) { int fd[2], pipe_opts; @@ -534,7 +493,7 @@ void apply_init_args( int argc, char *argv[] ) { /* daemonize */ if (debug_level == 0) { - if (my_daemon() < 0) { + if (daemon(0, 0) < 0) { printf("Error - can't fork to background: %s\n", strerror(errno)); restore_defaults();

1 0

[batmand] master: The *.d depends files for make just list the files used when building an object file. Removing a file listed in such a dependency file causes make to search for a way to recreate it. This usually cannot work because these files aren't autogenerated. (89f645e)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit 89f645e9a0f4967816d782b47b53dd6a12929743 Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:40:10 2013 +0200 The *.d depends files for make just list the files used when building an object file. Removing a file listed in such a dependency file causes make to search for a way to recreate it. This usually cannot work because these files aren't autogenerated. The gcc option -MP can be used to generate empty rule for these files. Removing a file in a dependency list will then execute this empty rule and continue with the execution of the creation of the object file. This compilation process will then automatically correct the dependency file. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 89f645e9a0f4967816d782b47b53dd6a12929743 Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 50d1fe8..6eae7ef 100755 --- a/Makefile +++ b/Makefile @@ -37,7 +37,7 @@ MANPAGE = man/batmand.8 #NO_POLICY_ROUTING = -DNO_POLICY_ROUTING # batmand flags and options -CFLAGS += -pedantic -Wall -W -std=gnu99 -MD -fno-strict-aliasing +CFLAGS += -pedantic -Wall -W -std=gnu99 -MD -MP -fno-strict-aliasing CPPFLAGS += -DDEBUG_MALLOC -DMEMORY_USAGE -DPROFILE_DATA $(NO_POLICY_ROUTING) LDLIBS += -lpthread

1 0

[batmand] master: Add include guards to avoid redundant declarations or include loops (45a9001)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit 45a900168d3b4d8512679570722a572ff9b1c631 Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:40:43 2013 +0200 Add include guards to avoid redundant declarations or include loops Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 45a900168d3b4d8512679570722a572ff9b1c631 allocate.h | 6 +++--- batman.h | 4 ++-- bitarray.h | 4 +++- hash.h | 4 ++-- hna.h | 5 ++++- originator.h | 4 +++- os.h | 4 ++-- packet.h | 5 +++++ profile.h | 5 ++++- ring_buffer.h | 5 ++++- schedule.h | 4 ++++ types.h | 4 ++-- 12 files changed, 38 insertions(+), 16 deletions(-) diff --git a/allocate.h b/allocate.h index 167ab33..99c3a49 100644 --- a/allocate.h +++ b/allocate.h @@ -20,10 +20,10 @@ */ -#ifndef _ALLOCATE_H -#define _ALLOCATE_H 1 -#include <stdint.h> +#ifndef _BATMAND_ALLOCATE_H +#define _BATMAND_ALLOCATE_H +#include <stdint.h> void checkIntegrity(void); diff --git a/batman.h b/batman.h index c8e35f1..05c48c1 100644 --- a/batman.h +++ b/batman.h @@ -21,8 +21,8 @@ -#ifndef _BATMAN_BATMAN_H -#define _BATMAN_BATMAN_H +#ifndef _BATMAND_BATMAN_H +#define _BATMAND_BATMAN_H #include <sys/types.h> #include <netinet/in.h> diff --git a/bitarray.h b/bitarray.h index 9a1f80d..e0ca302 100644 --- a/bitarray.h +++ b/bitarray.h @@ -19,7 +19,8 @@ * */ - +#ifndef _BATMAND_BITARRAY_H +#define _BATMAND_BITARRAY_H #include "batman.h" #define WORD_BIT_SIZE ( sizeof(TYPE_OF_WORD) * 8 ) @@ -34,3 +35,4 @@ char bit_get_packet( TYPE_OF_WORD *seq_bits, int16_t seq_num_diff, int8_t set_ma int bit_packet_count( TYPE_OF_WORD *seq_bits ); uint8_t bit_count( int32_t to_count ); +#endif diff --git a/hash.h b/hash.h index 91ee7d8..66d7162 100644 --- a/hash.h +++ b/hash.h @@ -18,8 +18,8 @@ * 02110-1301, USA * */ -#ifndef _BATMAN_HASH_H -#define _BATMAN_HASH_H +#ifndef _BATMAND_HASH_H +#define _BATMAND_HASH_H diff --git a/hna.h b/hna.h index 5af9317..99f7664 100644 --- a/hna.h +++ b/hna.h @@ -19,7 +19,8 @@ * */ - +#ifndef _BATMAND_HNA_H +#define _BATMAND_HNA_H #include "batman.h" @@ -82,3 +83,5 @@ void hna_global_update(struct orig_node *orig_node, unsigned char *new_hna, int16_t new_hna_len, struct neigh_node *old_router); void hna_global_check_tq(struct orig_node *orig_node); void hna_global_del(struct orig_node *orig_node); + +#endif diff --git a/originator.h b/originator.h index fb5e063..5ce5162 100644 --- a/originator.h +++ b/originator.h @@ -19,7 +19,8 @@ * */ - +#ifndef _BATMAND_ORIGINATOR_H +#define _BATMAND_ORIGINATOR_H #include "batman.h" #include "types.h" @@ -33,3 +34,4 @@ void update_orig( struct orig_node *orig_node, struct bat_packet *in, uint32_t n void purge_orig( uint32_t curr_time ); void debug_orig(void); +#endif diff --git a/os.h b/os.h index ab02497..26e97f5 100644 --- a/os.h +++ b/os.h @@ -19,8 +19,8 @@ * */ -#ifndef _BATMAN_OS_H -#define _BATMAN_OS_H +#ifndef _BATMAND_OS_H +#define _BATMAND_OS_H #include "batman.h" diff --git a/packet.h b/packet.h index 7d7e5b4..3a98ea5 100644 --- a/packet.h +++ b/packet.h @@ -19,6 +19,9 @@ * */ +#ifndef _BATMAND_PACKET_H +#define _BATMAND_PACKET_H + #define COMPAT_VERSION 5 #define VIS_COMPAT_VERSION 23 @@ -57,3 +60,5 @@ struct vis_data { uint8_t data; uint32_t ip; } __attribute__((packed)); + +#endif diff --git a/profile.h b/profile.h index a4afde0..d9221d5 100644 --- a/profile.h +++ b/profile.h @@ -19,7 +19,8 @@ * */ - +#ifndef _BATMAND_PROFILE_H +#define _BATMAND_PROFILE_H enum { @@ -51,3 +52,5 @@ void prof_init(int32_t index, char *name); void prof_start(int32_t index); void prof_stop(int32_t index); void prof_print(void); + +#endif diff --git a/ring_buffer.h b/ring_buffer.h index 78d8f9e..c1679d9 100644 --- a/ring_buffer.h +++ b/ring_buffer.h @@ -19,7 +19,8 @@ * */ - +#ifndef _BATMAND_RING_BUFFER_H +#define _BATMAND_RING_BUFFER_H #include <stdint.h> #include "batman.h" @@ -28,3 +29,5 @@ void ring_buffer_set(uint8_t tq_recv[], uint8_t *tq_index, uint8_t value); uint8_t ring_buffer_avg(uint8_t tq_recv[]); + +#endif diff --git a/schedule.h b/schedule.h index 50fd5aa..8bd54cd 100644 --- a/schedule.h +++ b/schedule.h @@ -19,7 +19,11 @@ * */ +#ifndef _BATMAND_SCHEDULE_H +#define _BATMAND_SCHEDULE_H void schedule_own_packet( struct batman_if *batman_if ); void schedule_forward_packet(struct orig_node *orig_node, struct bat_packet *in, uint32_t neigh, uint8_t directlink, int16_t hna_buff_len, struct batman_if *if_outgoing, uint32_t curr_time); void send_outstanding_packets(uint32_t curr_time); + +#endif diff --git a/types.h b/types.h index 7aa4884..6ae336e 100644 --- a/types.h +++ b/types.h @@ -19,8 +19,8 @@ * */ -#ifndef TYPES_H -#define TYPES_H +#ifndef _BATMAND_TYPES_H +#define _BATMAND_TYPES_H #include "packet.h"

1 0

[batmand] master: Strings in C are tried to be saved in the .rodata by the compiler/linker. This section is readonly as the name suggests. Pointer to these strings should therefore be const. (ad98735)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit ad98735519ccf083e193537eb04d0214a36a747c Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:41:41 2013 +0200 Strings in C are tried to be saved in the .rodata by the compiler/linker. This section is readonly as the name suggests. Pointer to these strings should therefore be const. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- ad98735519ccf083e193537eb04d0214a36a747c allocate.c | 2 +- hna.c | 4 ++-- linux/kernel.c | 10 +++++----- linux/route.c | 8 ++++---- linux/tun.c | 4 ++-- os.h | 16 ++++++++-------- posix/posix.c | 2 +- posix/unix_socket.c | 2 +- profile.c | 2 +- profile.h | 4 ++-- 10 files changed, 27 insertions(+), 27 deletions(-) diff --git a/allocate.c b/allocate.c index 9d79d87..57a4894 100644 --- a/allocate.c +++ b/allocate.c @@ -67,7 +67,7 @@ struct memoryUsage }; -static size_t getHeaderPad() { +static size_t getHeaderPad(void) { size_t alignwith, pad; if (sizeof(TYPE_OF_WORD) > sizeof(void*)) diff --git a/hna.c b/hna.c index 4c90dd3..b007ce5 100644 --- a/hna.c +++ b/hna.c @@ -39,12 +39,12 @@ struct list_head_first hna_chg_list; static pthread_mutex_t hna_chg_list_mutex; static struct hashtable_t *hna_global_hash = NULL; -int compare_hna(void *data1, void *data2) +static int compare_hna(void *data1, void *data2) { return (memcmp(data1, data2, 5) == 0 ? 1 : 0); } -int choose_hna(void *data, int32_t size) +static int choose_hna(void *data, int32_t size) { unsigned char *key= data; uint32_t hash = 0; diff --git a/linux/kernel.c b/linux/kernel.c index fa8882c..08c7e20 100644 --- a/linux/kernel.c +++ b/linux/kernel.c @@ -70,7 +70,7 @@ static void set_integer_file(const char* filename, int32_t integer) fclose(f); } -void set_rp_filter(int32_t state, char* dev) +void set_rp_filter(int32_t state, const char* dev) { char filename[100], *colon_ptr; @@ -85,7 +85,7 @@ void set_rp_filter(int32_t state, char* dev) *colon_ptr = ':'; } -int32_t get_rp_filter(char *dev) +int32_t get_rp_filter(const char *dev) { int32_t state = 0; char filename[100], *colon_ptr; @@ -103,7 +103,7 @@ int32_t get_rp_filter(char *dev) return state; } -void set_send_redirects(int32_t state, char* dev) +void set_send_redirects(int32_t state, const char* dev) { char filename[100], *colon_ptr; @@ -118,7 +118,7 @@ void set_send_redirects(int32_t state, char* dev) *colon_ptr = ':'; } -int32_t get_send_redirects(char *dev) +int32_t get_send_redirects(const char *dev) { int32_t state = 0; char filename[100], *colon_ptr; @@ -146,7 +146,7 @@ int32_t get_forwarding(void) return get_integer_file("/proc/sys/net/ipv4/ip_forward"); } -int8_t bind_to_iface(int32_t sock, char *dev) +int8_t bind_to_iface(int32_t sock, const char *dev) { char *colon_ptr; diff --git a/linux/route.c b/linux/route.c index bceac95..7934c27 100644 --- a/linux/route.c +++ b/linux/route.c @@ -73,7 +73,7 @@ static const char *rule_type_to_string_script[] = { #include <net/route.h> -void add_del_route(uint32_t dest, uint8_t netmask, uint32_t router, uint32_t src_ip, int32_t ifi, char *dev, uint8_t rt_table, int8_t route_type, int8_t route_action) +void add_del_route(uint32_t dest, uint8_t netmask, uint32_t router, uint32_t src_ip, int32_t ifi, const char *dev, uint8_t rt_table, int8_t route_type, int8_t route_action) { struct rtentry route; struct sockaddr_in *addr; @@ -152,7 +152,7 @@ void add_del_route(uint32_t dest, uint8_t netmask, uint32_t router, uint32_t src close(sock); } -void add_del_rule(uint32_t BATMANUNUSED(network), uint8_t BATMANUNUSED(netmask), int8_t BATMANUNUSED(rt_table), uint32_t BATMANUNUSED(prio), char *BATMANUNUSED(iif), int8_t BATMANUNUSED(rule_type), int8_t BATMANUNUSED(rule_action)) +void add_del_rule(uint32_t BATMANUNUSED(network), uint8_t BATMANUNUSED(netmask), int8_t BATMANUNUSED(rt_table), uint32_t BATMANUNUSED(prio), const char *BATMANUNUSED(iif), int8_t BATMANUNUSED(rule_type), int8_t BATMANUNUSED(rule_action)) { return; } @@ -169,7 +169,7 @@ int flush_routes_rules(int8_t BATMANUNUSED(is_rule)) #else -void add_del_route(uint32_t dest, uint8_t netmask, uint32_t router, uint32_t src_ip, int32_t ifi, char *dev, uint8_t rt_table, int8_t route_type, int8_t route_action) +void add_del_route(uint32_t dest, uint8_t netmask, uint32_t router, uint32_t src_ip, int32_t ifi, const char *dev, uint8_t rt_table, int8_t route_type, int8_t route_action) { int netlink_sock; size_t len; @@ -354,7 +354,7 @@ void add_del_route(uint32_t dest, uint8_t netmask, uint32_t router, uint32_t src * ***/ -void add_del_rule(uint32_t network, uint8_t netmask, int8_t rt_table, uint32_t prio, char *iif, int8_t rule_type, int8_t rule_action) +void add_del_rule(uint32_t network, uint8_t netmask, int8_t rt_table, uint32_t prio, const char *iif, int8_t rule_type, int8_t rule_action) { int netlink_sock; size_t len; diff --git a/linux/tun.c b/linux/tun.c index afb0447..ac5e069 100644 --- a/linux/tun.c +++ b/linux/tun.c @@ -47,7 +47,7 @@ #define IPTABLES_DEL_ACC "iptables -t nat -D POSTROUTING -s %s/%i -j ACCEPT" -int run_cmd(char *cmd) { +static int run_cmd(const char *cmd) { int error, pipes[2], stderr = -1, ret = 0; char error_log[256]; @@ -90,7 +90,7 @@ int probe_nat_tool(void) { return run_cmd("which iptables > /dev/null"); } -void exec_iptables_rule(char *cmd, int8_t route_action) { +static void exec_iptables_rule(const char *cmd, int8_t route_action) { if (disable_client_nat) return; diff --git a/os.h b/os.h index 26e97f5..2f2b2df 100644 --- a/os.h +++ b/os.h @@ -44,8 +44,8 @@ void segmentation_fault(int32_t sig) NO_RETURN; void restore_and_exit(uint8_t is_sigsegv) NO_RETURN; /* route.c */ -void add_del_route( uint32_t dest, uint8_t netmask, uint32_t router, uint32_t src_ip, int32_t ifi, char *dev, uint8_t rt_table, int8_t route_type, int8_t del ); -void add_del_rule( uint32_t network, uint8_t netmask, int8_t rt_table, uint32_t prio, char *iif, int8_t dst_rule, int8_t del ); +void add_del_route( uint32_t dest, uint8_t netmask, uint32_t router, uint32_t src_ip, int32_t ifi, const char *dev, uint8_t rt_table, int8_t route_type, int8_t del ); +void add_del_rule( uint32_t network, uint8_t netmask, int8_t rt_table, uint32_t prio, const char *iif, int8_t dst_rule, int8_t del ); int add_del_interface_rules( int8_t del ); int flush_routes_rules( int8_t rt_table ); @@ -69,13 +69,13 @@ void init_interface_gw(void); void interface_listen_sockets(void); /* kernel.c */ -void set_rp_filter( int32_t state, char* dev ); -int32_t get_rp_filter( char *dev ); -void set_send_redirects( int32_t state, char* dev ); -int32_t get_send_redirects( char *dev ); +void set_rp_filter( int32_t state, const char* dev ); +int32_t get_rp_filter( const char *dev ); +void set_send_redirects( int32_t state, const char* dev ); +int32_t get_send_redirects( const char *dev ); void set_forwarding( int32_t state ); int32_t get_forwarding( void ); -int8_t bind_to_iface( int32_t sock, char *dev ); +int8_t bind_to_iface( int32_t sock, const char *dev ); int is_wifi_interface(char *dev, int fd); /* posix.c */ @@ -96,7 +96,7 @@ void *client_to_gw_tun( void *arg ); /* unix_sokcet.c */ void *unix_listen( void *arg ); void internal_output(uint32_t sock); -void debug_output( int8_t debug_prio, char *format, ... ); +void debug_output( int8_t debug_prio, const char *format, ... ); #endif diff --git a/posix/posix.c b/posix/posix.c index ae1cef0..81cd2e1 100644 --- a/posix/posix.c +++ b/posix/posix.c @@ -125,7 +125,7 @@ uint64_t get_time_msec64(void) } /* batman animation */ -static void sym_print( char x, char y, char *z ) { +static void sym_print( char x, char y, const char *z ) { char i = 0, Z; diff --git a/posix/unix_socket.c b/posix/unix_socket.c index 02a0a3a..11c5d3e 100644 --- a/posix/unix_socket.c +++ b/posix/unix_socket.c @@ -39,7 +39,7 @@ #include "../hna.h" -void debug_output(int8_t debug_prio, char *format, ...) { +void debug_output(int8_t debug_prio, const char *format, ...) { struct list_head *debug_pos; struct debug_level_info *debug_level_info; diff --git a/profile.c b/profile.c index e691f5d..c76ae8d 100644 --- a/profile.c +++ b/profile.c @@ -33,7 +33,7 @@ static struct prof_container prof_container[PROF_COUNT]; -void prof_init(int32_t index, char *name) { +void prof_init(int32_t index, const char *name) { prof_container[index].total_time = 0; prof_container[index].calls = 0; diff --git a/profile.h b/profile.h index d9221d5..e50bf70 100644 --- a/profile.h +++ b/profile.h @@ -42,13 +42,13 @@ struct prof_container { clock_t start_time; clock_t total_time; - char *name; + const char *name; uint64_t calls; }; -void prof_init(int32_t index, char *name); +void prof_init(int32_t index, const char *name); void prof_start(int32_t index); void prof_stop(int32_t index); void prof_print(void);

1 0

[batmand] master: Fix preprocessor check for defined NO_POLICY_ROUTING (02094d3)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit 02094d3e32e42162087420bb019eb51fcff4299d Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:42:20 2013 +0200 Fix preprocessor check for defined NO_POLICY_ROUTING Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 02094d3e32e42162087420bb019eb51fcff4299d linux/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux/route.c b/linux/route.c index 7934c27..12f7734 100644 --- a/linux/route.c +++ b/linux/route.c @@ -69,7 +69,7 @@ static const char *rule_type_to_string_script[] = { * ***/ -#if NO_POLICY_ROUTING +#ifdef NO_POLICY_ROUTING #include <net/route.h>

1 0

[batmand] master: The GCC manual states for different parameters that the options for compilation must also be used when linking. The options for compilation are stored in CFLAGS and added to LINK.o to fix the behavior. (aeb6729)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit aeb6729d9637b519c5ae352a2b4aa9d4f07279c4 Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:39:17 2013 +0200 The GCC manual states for different parameters that the options for compilation must also be used when linking. The options for compilation are stored in CFLAGS and added to LINK.o to fix the behavior. Option which need this are for example -fPIC/-fPIE or -flto. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- aeb6729d9637b519c5ae352a2b4aa9d4f07279c4 Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3205573..50d1fe8 100755 --- a/Makefile +++ b/Makefile @@ -57,7 +57,7 @@ RM ?= rm -f INSTALL ?= install MKDIR ?= mkdir -p COMPILE.c = $(Q_CC)$(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c -LINK.o = $(Q_LD)$(CC) $(LDFLAGS) $(TARGET_ARCH) +LINK.o = $(Q_LD)$(CC) $(CFLAGS) $(LDFLAGS) $(TARGET_ARCH) # standard install paths PREFIX = /usr/local

1 0

[batmand] master: There are different aliasing problems in posix/tunnel.c and maybe other files. This can lead to wrongly generated code when the compiler assumes strict aliasing rules. (ba0674a)
by postmaster＠open-mesh.org 15 Sep '13

15 Sep '13

Repository : ssh://git@open-mesh.org/batmand On branch : master >--------------------------------------------------------------- commit ba0674a50b7bdfd7b09750d9af5c54389f7f54fa Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Sep 15 17:38:21 2013 +0200 There are different aliasing problems in posix/tunnel.c and maybe other files. This can lead to wrongly generated code when the compiler assumes strict aliasing rules. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- ba0674a50b7bdfd7b09750d9af5c54389f7f54fa Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ce1e198..3205573 100755 --- a/Makefile +++ b/Makefile @@ -37,7 +37,7 @@ MANPAGE = man/batmand.8 #NO_POLICY_ROUTING = -DNO_POLICY_ROUTING # batmand flags and options -CFLAGS += -pedantic -Wall -W -std=gnu99 -MD +CFLAGS += -pedantic -Wall -W -std=gnu99 -MD -fno-strict-aliasing CPPFLAGS += -DDEBUG_MALLOC -DMEMORY_USAGE -DPROFILE_DATA $(NO_POLICY_ROUTING) LDLIBS += -lpthread

1 0

[batctl] next: batctl: Don't use hyphen for parameter in manpage (b64f1c8)
by postmaster＠open-mesh.org 13 Sep '13

13 Sep '13

Repository : ssh://git@open-mesh.org/batctl On branch : next >--------------------------------------------------------------- commit b64f1c80347b9c8b3fd1dca4468fb3a65dc1e1da Author: Sven Eckelmann <sven(a)narfation.org> Date: Tue Sep 10 23:12:02 2013 +0200 batctl: Don't use hyphen for parameter in manpage By default, "-" chars are interpreted as hyphens (U+2010) by groff, not as minus signs (U+002D). Since options to programs use minus signs (U+002D), this means for example in UTF-8 locales that you cannot cut and paste options, nor search for them easily. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> >--------------------------------------------------------------- b64f1c80347b9c8b3fd1dca4468fb3a65dc1e1da man/batctl.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/batctl.8 b/man/batctl.8 index 38060d6..caec3ad 100644 --- a/man/batctl.8 +++ b/man/batctl.8 @@ -281,7 +281,7 @@ except specified). The following packet types are available: 128 - non batman packets .RE .RS 7 -Example: batctl td <interface> -p 129 \-> only display batman ogm packets and non batman packets +Example: batctl td <interface> \-p 129 \-> only display batman ogm packets and non batman packets .RE .br .IP "\fBbisect_iv\fP [\fB\-l MAC\fP][\fB\-t MAC\fP][\fB\-r MAC\fP][\fB\-s min\fP [\fB\- max\fP]][\fB\-o MAC\fP][\fB\-n\fP] \fBlogfile1\fP [\fBlogfile2\fP ... \fBlogfileN\fP]"

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits September 2013