On Tue, Sep 24, 2013 at 03:46:50PM +0200, Antonio Quartulli wrote:
On Tue, Sep 24, 2013 at 03:40:33PM +0200, Linus Lüssing wrote:
> Using this option wrongly will break your mesh network, use this option
> wisely and at your own risk!
Exactly for this reason (As we discussed on IRC) I think this mechanism should be
reasoned a bit more.
Hm, my personal reason to want such a feature is included, the VPN
example. And since I know that using batman-adv over VPNs is not
uncommon, I'd love to have this feature upstream.
I believe such a feature would be more commonly used than a
non-default hop penalty for example, therefore I think it is
suitable to be considered for upstream.
As I told you, it would be nice to have a self-activating
mechanism which is able to switch it on or off when really needed.
I totally agree that a self-activating mechanism would be nice
indeed. Maybe even with a self-adjusting number of rebroadcasts.
But since that is all non-trivial I'm not going to work on
such an automatic feature before my queued multicast patches and
the ones to follow are upstream. I'd prefer not hopping between
multiple feature patchsets again to spare everyone a déjà vu.
So since such an automatic feature is not going to be available
upstream within the next one or two years at least, I guess,
I don't see why the easy, manual option which could be added to
a release relatively quickly, should be spared from the
The common network administrator will probably not have enough knowledge to
understand when this is useful or when this is breaking things.
That's why I added the extra warning at the end.
Moreover, with this patch you are adding a userspace API that we won't be able
to remove anymore (!)
So we should have never added a hop-penalty sysfs option either?
That one could have been automized, too.
and since the feature needs some more time before being
mature I'd rather to suggest to avoid this.
I'm sorry, I currently fail to see in which regards this would
need a considerable amount of time to mature. To me this option
seems easy and straightforward, especially as other routing
protocols like babel for instance have such a manual option
available, too. If you have certain, specific maturity concerns,
things I might have overlooked, I'd be happy if you could share