main.h is included in every file and is the only way to access types.h. This makes forward declarations for all types defined in types.h unnecessary.
Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/bridge_loop_avoidance.h | 3 --- net/batman-adv/debugfs.h | 1 - net/batman-adv/gateway_common.h | 1 - net/batman-adv/icmp_socket.h | 1 - net/batman-adv/multicast.h | 2 -- net/batman-adv/network-coding.h | 4 ---- net/batman-adv/routing.h | 4 ---- net/batman-adv/send.h | 3 --- net/batman-adv/soft-interface.h | 4 ---- net/batman-adv/sysfs.h | 2 -- net/batman-adv/translation-table.h | 2 -- 11 files changed, 27 deletions(-)
diff --git a/net/batman-adv/bridge_loop_avoidance.h b/net/batman-adv/bridge_loop_avoidance.h index 449f2f1..025152b 100644 --- a/net/batman-adv/bridge_loop_avoidance.h +++ b/net/batman-adv/bridge_loop_avoidance.h @@ -22,9 +22,6 @@
#include <linux/types.h>
-struct batadv_hard_iface; -struct batadv_orig_node; -struct batadv_priv; struct seq_file; struct sk_buff;
diff --git a/net/batman-adv/debugfs.h b/net/batman-adv/debugfs.h index 187acdc..80ab8d6 100644 --- a/net/batman-adv/debugfs.h +++ b/net/batman-adv/debugfs.h @@ -22,7 +22,6 @@
#include <linux/kconfig.h>
-struct batadv_hard_iface; struct net_device;
#define BATADV_DEBUGFS_SUBDIR "batman_adv" diff --git a/net/batman-adv/gateway_common.h b/net/batman-adv/gateway_common.h index bd5c812..ab893e3 100644 --- a/net/batman-adv/gateway_common.h +++ b/net/batman-adv/gateway_common.h @@ -22,7 +22,6 @@
#include <linux/types.h>
-struct batadv_priv; struct net_device;
enum batadv_gw_modes { diff --git a/net/batman-adv/icmp_socket.h b/net/batman-adv/icmp_socket.h index 7de7fce..e937143 100644 --- a/net/batman-adv/icmp_socket.h +++ b/net/batman-adv/icmp_socket.h @@ -23,7 +23,6 @@ #include <linux/types.h>
struct batadv_icmp_header; -struct batadv_priv;
#define BATADV_ICMP_SOCKET "socket"
diff --git a/net/batman-adv/multicast.h b/net/batman-adv/multicast.h index beb6e56..8f3cb04 100644 --- a/net/batman-adv/multicast.h +++ b/net/batman-adv/multicast.h @@ -20,8 +20,6 @@
#include "main.h"
-struct batadv_orig_node; -struct batadv_priv; struct sk_buff;
/** diff --git a/net/batman-adv/network-coding.h b/net/batman-adv/network-coding.h index 5b79aa8..8f6d4ad 100644 --- a/net/batman-adv/network-coding.h +++ b/net/batman-adv/network-coding.h @@ -22,11 +22,7 @@
#include <linux/types.h>
-struct batadv_nc_node; -struct batadv_neigh_node; struct batadv_ogm_packet; -struct batadv_orig_node; -struct batadv_priv; struct net_device; struct seq_file; struct sk_buff; diff --git a/net/batman-adv/routing.h b/net/batman-adv/routing.h index 3c185a1..204bbe4 100644 --- a/net/batman-adv/routing.h +++ b/net/batman-adv/routing.h @@ -22,10 +22,6 @@
#include <linux/types.h>
-struct batadv_hard_iface; -struct batadv_neigh_node; -struct batadv_orig_node; -struct batadv_priv; struct sk_buff;
bool batadv_check_management_packet(struct sk_buff *skb, diff --git a/net/batman-adv/send.h b/net/batman-adv/send.h index 33ef6fc..82059f2 100644 --- a/net/batman-adv/send.h +++ b/net/batman-adv/send.h @@ -25,9 +25,6 @@
#include "packet.h"
-struct batadv_hard_iface; -struct batadv_orig_node; -struct batadv_priv; struct sk_buff; struct work_struct;
diff --git a/net/batman-adv/soft-interface.h b/net/batman-adv/soft-interface.h index 578e8a6..8e82176 100644 --- a/net/batman-adv/soft-interface.h +++ b/net/batman-adv/soft-interface.h @@ -22,10 +22,6 @@
#include <net/rtnetlink.h>
-struct batadv_hard_iface; -struct batadv_orig_node; -struct batadv_priv; -struct batadv_softif_vlan; struct net_device; struct sk_buff;
diff --git a/net/batman-adv/sysfs.h b/net/batman-adv/sysfs.h index 2294583..6197442 100644 --- a/net/batman-adv/sysfs.h +++ b/net/batman-adv/sysfs.h @@ -23,8 +23,6 @@ #include <linux/sysfs.h> #include <linux/types.h>
-struct batadv_priv; -struct batadv_softif_vlan; struct kobject; struct net_device;
diff --git a/net/batman-adv/translation-table.h b/net/batman-adv/translation-table.h index 9b82d5d..abd8e11 100644 --- a/net/batman-adv/translation-table.h +++ b/net/batman-adv/translation-table.h @@ -22,8 +22,6 @@
#include <linux/types.h>
-struct batadv_orig_node; -struct batadv_priv; struct net_device; struct seq_file;
bfd0fbaef270 ("batman-adv: Make DAT capability changes atomic") started to use clear_bit and set_bit but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/distributed-arp-table.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index dc1191a..4ba7f61 100644 --- a/net/batman-adv/distributed-arp-table.c +++ b/net/batman-adv/distributed-arp-table.c @@ -19,6 +19,7 @@ #include "main.h"
#include <linux/atomic.h> +#include <linux/bitops.h> #include <linux/byteorder/generic.h> #include <linux/errno.h> #include <linux/etherdevice.h>
On Thursday, June 18, 2015 18:53:20 Sven Eckelmann wrote:
bfd0fbaef270 ("batman-adv: Make DAT capability changes atomic") started to use clear_bit and set_bit but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org
net/batman-adv/distributed-arp-table.c | 1 + 1 file changed, 1 insertion(+)
Applied in revision 746aecd.
Thanks, Marek
201a54ba710a ("batman-adv: Make MCAST capability changes atomic") started to use clear_bit and set_bit but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/multicast.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index 2fa9983..b8002a5 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -19,6 +19,7 @@ #include "main.h"
#include <linux/atomic.h> +#include <linux/bitops.h> #include <linux/byteorder/generic.h> #include <linux/errno.h> #include <linux/etherdevice.h>
On Thursday, June 18, 2015 18:53:21 Sven Eckelmann wrote:
201a54ba710a ("batman-adv: Make MCAST capability changes atomic") started to use clear_bit and set_bit but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org
net/batman-adv/multicast.c | 1 + 1 file changed, 1 insertion(+)
Applied in revision 0128bee.
Thanks, Marek
7f220ed1f063 ("batman-adv: Fix potential synchronization issues in mcast tvlv handler") started to use BUG_ON but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/multicast.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index b8002a5..c64d9b1 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -20,6 +20,7 @@
#include <linux/atomic.h> #include <linux/bitops.h> +#include <linux/bug.h> #include <linux/byteorder/generic.h> #include <linux/errno.h> #include <linux/etherdevice.h>
On Thursday, June 18, 2015 18:53:22 Sven Eckelmann wrote:
7f220ed1f063 ("batman-adv: Fix potential synchronization issues in mcast tvlv handler") started to use BUG_ON but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org
net/batman-adv/multicast.c | 1 + 1 file changed, 1 insertion(+)
Applied in revision cfb1542.
Thanks, Marek
586df9e2537b ("batman-adv: Make NC capability changes atomic") started to use clear_bit and set_bit but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/network-coding.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c index 9d8d6a9..62defe0 100644 --- a/net/batman-adv/network-coding.c +++ b/net/batman-adv/network-coding.c @@ -19,6 +19,7 @@ #include "main.h"
#include <linux/atomic.h> +#include <linux/bitops.h> #include <linux/byteorder/generic.h> #include <linux/compiler.h> #include <linux/debugfs.h>
On Thursday, June 18, 2015 18:53:23 Sven Eckelmann wrote:
586df9e2537b ("batman-adv: Make NC capability changes atomic") started to use clear_bit and set_bit but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org
net/batman-adv/network-coding.c | 1 + 1 file changed, 1 insertion(+)
Applied in revision c0d0029.
Thanks, Marek
a51fa16ecf3f ("batman-adv: Make TT capability changes atomic") started to use use clear_bit and set_bit but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/translation-table.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 3aca026..ed3ede3 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -19,6 +19,7 @@ #include "main.h"
#include <linux/atomic.h> +#include <linux/bitops.h> #include <linux/bug.h> #include <linux/byteorder/generic.h> #include <linux/compiler.h>
On Thursday, June 18, 2015 18:53:24 Sven Eckelmann wrote:
a51fa16ecf3f ("batman-adv: Make TT capability changes atomic") started to use use clear_bit and set_bit but did not add the include for these functions.
Signed-off-by: Sven Eckelmann sven@narfation.org
net/batman-adv/translation-table.c | 1 + 1 file changed, 1 insertion(+)
Applied in revision 5138e6a.
Thanks, Marek
On Thursday, June 18, 2015 18:53:19 Sven Eckelmann wrote:
main.h is included in every file and is the only way to access types.h. This makes forward declarations for all types defined in types.h unnecessary.
Signed-off-by: Sven Eckelmann sven@narfation.org
net/batman-adv/bridge_loop_avoidance.h | 3 --- net/batman-adv/debugfs.h | 1 - net/batman-adv/gateway_common.h | 1 - net/batman-adv/icmp_socket.h | 1 - net/batman-adv/multicast.h | 2 -- net/batman-adv/network-coding.h | 4 ---- net/batman-adv/routing.h | 4 ---- net/batman-adv/send.h | 3 --- net/batman-adv/soft-interface.h | 4 ---- net/batman-adv/sysfs.h | 2 -- net/batman-adv/translation-table.h | 2 -- 11 files changed, 27 deletions(-)
Applied in revision 31b0151.
Thanks, Marek
b.a.t.m.a.n@lists.open-mesh.org
-
Marek Lindner -
Sven Eckelmann