Re: [B.A.T.M.A.N.] [PATCHv3 next] batman-adv: avoid potential race condition when adding a new neighbour

On Monday 27 January 2014 16:27:17 Antonio Quartulli wrote:

@@ -266,7 +266,7 @@ batadv_iv_ogm_neigh_new(struct batadv_hard_iface *hard_iface, struct batadv_orig_node *orig_neigh) { struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);

•   struct batadv_neigh_node *neigh_node;
  

•   struct batadv_neigh_node *neigh_node = NULL, *tmp_neigh_node;
  
    neigh_node = batadv_neigh_node_new(hard_iface, neigh_addr,
  

orig_node);

I don't quite get why neigh_node has to be initialized if we set a value in the next line.

Cheers, Marek