Re: [B.A.T.M.A.N.] [PATCH v2 2/4] batman-adv: Store and transmit own neighborhood hash

On Donnerstag, 6. Oktober 2016 08:41:39 CET Linus Lüssing wrote:

struct batadv_elp_packet { u8 packet_type; @@ -247,6 +258,8 @@ struct batadv_elp_packet { u8 orig[ETH_ALEN]; __be32 seqno; __be32 elp_interval;

•   __be16 reserved;
  

•   __be16 tvlv_len;
  

};

Um, you simply increase the size of the elp_packet? Isn't this potentially breaking compat with older versions? batadv_v_elp_packet_recv is using BATADV_ELP_HLEN (sizeof(struct batadv_elp_packet)) as minimal size/header_len in batadv_check_management_packet.

Only thing saving you here is the padding on some links. But this padding could cause some odd behaviour in batadv_tvlv_containers_process2 when tvlv_len is bogus/padding.

Kind regards, Sven