On Mit, 2009-08-26 at 16:51 +0800, Marek Lindner wrote:
On Wednesday 26 August 2009 16:01:27 Sven Eckelmann wrote:
> I found also some other things and also told that Marek - but I
> not everything was included in the patch I send some weeks ago. Maybe it
> was only to break printk statements to fit in 80 chars per line, but I am
> not sure right now.
Yes, you found a way to break a long string into smaller pieces although I
can't quite remember how you did it. ;-)
As a b.a.t.m.a.n@ lurker but kernel-ML reader (not necessarily LKML, but
the more specialized ones):
- moving the ML to vger.kernel.org
was for several folks the simple way
to open the list without the risk of daily countless spam (and there
is next to no spam on these lists).
Yes, the list (or another list) is than hosted elsewhere.
But open-only-for-subscriber lists tend to be - at least - criticized
and - IMHO probably - excluded from the MAINTAINERS file.
I don't know/have no opinion on if it makes sense to make a new list
(@vger.) primarily for the layer 2 "variant" (and it's driver
Current people will probably subscribe that too (and if you sort it
into the same folder, it also looks almost like now). Perhaps the
admins there even accept a list with to-be-subscribed email addresses
(which makes sense for list migrations. Auto-subscribed email
addresses get an email anyways).
- the "80 chars per line" rule in checkpatch.pl is one of the most (if
not *the* most) debated one. There even were requests/patches to
simply remove that check. Or at least deactivate it per default.
(Core) Kernel people prefer code readability over such too simple
For simple strings in "printk()": IMHO ignore the warning and
reject patches from random people which take "checkpatch" output and
silence it with the plain simple reason: "what exactly is it
Disclaimer: Feel free to ignore the above (and I'm the last to decide
such issues here).
: Accept it - it's LKML policy.
: Personally it would bury the historical "80" and - in times with
wide-screen monitors replace it with at least "132" (and I tend to
have > 6 xterms on each virtual desktop) - at least in
checkpatch.pl. YMMV .....
: I didn't look at the source.
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services