Re: [B.A.T.M.A.N.] [PATCHv4] batman-adv: Introduce forward packet creation helper

On Monday, June 20, 2016 22:14:28 Sven Eckelmann wrote:

On Monday 20 June 2016 21:39:54 Linus Lüssing wrote:

...

This patch abstracts the forward packet creation into the new function batadv_forw_packet_alloc().

The queue counting and interface reference counters are now handled internally within batadv_forw_packet_alloc() and its batadv_forw_packet_free() counterpart. This should reduce the risk of having reference/queue counting bugs again and should increase code readibility.

Signed-off-by: Linus Lüssing linus.luessing@c0d3.blue

Changelog v4:

• Removed goto in batadv_iv_ogm_aggregate_new()
• Removed two goto's in batadv_forw_packet_alloc()
• Easier to read debug output code in batadv_forw_packet_alloc()
• Renamed "out" and "packet_free" jump labels in

batadv_add_bcast_packet_to_list()> to "err" and "err_packet_free"

Reviewed-by: Sven Eckelmann sven@narfation.org

Applied in revision afb07c8.

Thanks, Marek