Re: [B.A.T.M.A.N.] [PATCH v2 3/3] batman-adv: throughput meter implementation
On Tuesday 03 May 2016 01:28:28 Antonio Quartulli wrote:
[...]
shouldn't we propagate the value saved in err to
tp_vars->reason ?
We found this error while using the tp_meter, because we tried to run it
against a non-existing originator and batctl crashed.
Yes, looks like I've missed this while reviewing your tp_meter code. Was
the crash something like:
root@node02:~# /host/batctl/batctl tp 02:ba:de:af:ff:01
Throughput meter called towards 02:ba:de:af:ff:01
tp_meter.c:198:36: runtime error: division by zero
traps: batctl[246] trap divide error ip:410f31 sp:7ffea78512c0 error:0 in
batctl[400000+18000]
Floating point exception
I will most likely add code catching it in both batctl and batman-adv.
Kind regards,
Sven
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)