Re: [B.A.T.M.A.N.] [PATCH next] batman-adv: Avoid skb free for batadv_send_skb_to_orig < -1

On Friday, June 10, 2016 18:14:00 Sven Eckelmann wrote:

The tp_meter code frees the skb when the batadv_send_skb_to_orig returns < 0. But the batadv_send_skb_to_orig only defines -1 as return code for failed submits with still valid skbs.

Fixes: 98d7a766b645 ("batman-adv: throughput meter implementation") Signed-off-by: Sven Eckelmann sven@narfation.org

---

Interesting because a patch was submitted to net next to remove NET_XMIT_POLICED and return -EINPROGRESS instead.

I will maybe later send more patches because the current way of handling DROPPED/free'd skb/not-freed skb is quite confusing.

net/batman-adv/tp_meter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision 1aaa327.

Thanks, Marek