Re: [B.A.T.M.A.N.] [PATCHv13 0/4] Multicast optimizations for bridges
Hi,
On Tuesday 19 April 2016 04:10:35 Linus Lüssing wrote:
This patchset enables the usage of the batman-adv multicast
optimizations
for scenarios involving bridges on top of e.g. bat0, too.
The first one alters the forwarding behaviour for IGMP and MLD reports
which is a prerequisite before enabling multicast optimizations in
bridged setups. It also increases the MCAST TVLV version number to 2.
More on the issue of insufficient report handling with the v1
MCAST TVLV can be found here:
http://www.open-mesh.org/projects/batman-adv/wiki/Multicast-optimizations-li
stener-reports
The second patch finally enables the multicast optimizations for
bridged setups.
Along come two more patches adding according debugging facilities
to make it possible for the user to check why the multicast
optimizations might not work ideally to give hints about
what they might change about their topology.
This patchset can be found in the current linus/multicast-bridge
branch.
Cheers, Linus
I've tested this patchset in my virtual environment with 6 nodes (based on
OpenWRT), where 3 of them were meshed and another 3 were connected to each of
the mesh nodes through a bridge. I've run the querier on various nodes, used
the simple multicast listener [1] to create an IPv6 listener and verified that
the querier detection and multicast forwarding was working as expected. There
was a kernel bug which created problems with the querier detection (detected
as enabled/disabled every 2 minutes or so), but Linus fixed that problem [2],
and since the fix is targeted for stable I don't think it is an obstacle for
us.
I've also checked the code briefly and didn't find any problems.
There is one last comment from Sven on v12 on the compat part which needs some
attention, but other than that I think it is ready to merge.
Feel free to add
Tested-by: Simon Wunderlich <sw(a)simonwunderlich.de>
to the patches.
Thanks,
Simon
[1] https://github.com/T-X/sm-listener
[2] https://lkml.org/lkml/2016/5/3/780
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)