On Saturday 12 March 2016 08:34:35 Sven Eckelmann wrote:
On Saturday 12 March 2016 12:42:36 Antonio Quartulli wrote:
On Sat, Mar 12, 2016 at 12:37:17AM +0100, Sven Eckelmann wrote:
 https://git.open-mesh.org/batman-adv.git/commit/fb7b5eb8c81969dc8bea356d 0 a3f0b5e72d2da49
Sven, what is the README there for ?
It serves different purposes. It makes sure that the directory is created by git on checkout even when there is no patch in the directory. It also makes sure that the Makefile dependency glob for compat-patches/* is at least generating one dependency.
But it should also be used to define the rules under which a patch in this directory is acceptable (of course, the rules are not yet defined - so I've just used a placeholder for this draft). The requirements for such a patch should be really high because patches tend to fail when the code or the surrounding code is changed. This is also the reason why I've combined the critical code to really small functions which avoids more patch chunks for more places in the code.
And maybe it should also describe how to generate patches for this directory
git format-patch --abbrev=7 -U3 --diff-algorithm=histogram --no-signature --format=format:'From: %an <%ae>%nDate: %aD%nSubject: [PATCH] %B' -1
Kind regards, Sven