i've checked in a changed and fixed up version of this patch in r1686.
This version has the interface alternating enabled by default, so
we don't need to change the "bonding_enabled" to "bonding_mode"
We have decided here in Bracciano to have alternating as default as it
appears to be beneficial most of the times, but we couldn't really think
of a scenario where this might be a problem.
I've also added some documentation at
and i'm looking for comments and proofreading and comments. ;)
I've also followed your other comments (hopefully correctly), so thank
you very much for the review.
On Wed, May 26, 2010 at 12:39:22PM +0200, Sven Eckelmann wrote:
Only some non-technical comments about the patch for now:
I thought we decided that the "Staging: " part in the title will be appended
when the stuff will be send to Greg and should be omitted inside our source
trees. Also your patch wouldn't apply in linux-next because the bonding stuff
is in master and not in maint (only maint will be send to the kernel folks).
> This is an experimental patch and targeted for upcoming experiments at
> Wireless Battle Mesh v3 in Bracciano/Italy.
> Feedback, comments and reviews appreciated!
That part is quite interesting for the mailinglist but should not be part of
the commit message, or am I wrong? In that situation such information should
be appended after the "---". git-am or similar tools should automatically
ignore that parts, but the receiver can still read that comment.
> Index: a/batman-adv-kernelland/main.h
> --- a/batman-adv-kernelland/main.h (revision 1679)
> +++ a/batman-adv-kernelland/main.h (working copy)
> @@ -63,6 +63,10 @@
> * to be considered as bonding candidates */
> #define BONDING_TQ_THRESHOLD 50
> +#define BONDING_NONE 0
> +#define BONDING_ROUNDROBIN 1
You've wrote something like "space""tab""1" here. Can
you please remove the
space before the tab.
Have you already painted some nice graphics or wrote some text to explain the
modes further (yes, code is the best documentation, but a bad specification)?
The rest looks like it should be tested in italy :)