20 Sep
2012
20 Sep
'12
11:42 a.m.
Hello Def,
On Tue, Sep 18, 2012 at 04:55:32PM +0200, Sven Eckelmann wrote:
On Tuesday 18 September 2012 16:41:58 Def wrote:
sorry for the delay. Overall the patch is correct, I also tested it and it
correctly fixes the problem.
Please, address what Sven just said so that the patch is clean (you can also use
checkpatch.pl --strict to check for this style things..it is in your
linux/scripts/ directory as documented in the file cited by Sven)
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
Into function interface_set_mac_addr, the
function tt_local_add
was invoked before updating dev->dev_addr. The new MAC
addresse was not tagged as NoPurge.
Please don't add extra whitespaces before your commit message.
Your Signed-off-by: is missing.
[...]
-
- memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+
Please don't add trailing whitespaces.
I have no idea whether this works... *looks at Antonio*. But thanks for
bringing this up in the issue tracker and sending this first version of the
patch.