Re: [B.A.T.M.A.N.] [PATCHv3 8/8] batman-adv: add debugfs support to view multiif tables

On Wednesday 13 November 2013 19:14:52 Simon Wunderlich wrote:

+/**

• • batadv_originators_open_multiif - handles debugfs output for the
• • originators_multiif table
• • @inode: inode pointer to debugfs file
• • @file: pointer to the seq_file
• */

+static int batadv_originators_open_multiif(struct inode *inode,

• 			   struct file *file)
  

+{

• struct net_device *net_dev = (struct net_device *)inode->i_private;
• return single_open(file, batadv_orig_multiif_seq_print_text, net_dev);

+}

Please find a better name than 'multiif'. That term isn't used in any function your patchset introduced. How about: batadv_originators_iface_open() ?

+/**

• • batadv_orig_multiif_seq_print_text - writes originator infos for all
• • outgoing interfaces
• • @seq: debugfs table seq_file struct
• • @offset: not used
• • Returns 0
• */

+int batadv_orig_multiif_seq_print_text(struct seq_file *seq, void *offset)

Same here.

Cheers, Marek