Re: [B.A.T.M.A.N.] [PATCHv2 next 02/11] batman-adv: don't mess up with the netdev refcounting if not needed

On Wed, Mar 19, 2014 at 09:08:43AM +0100, Antonio Quartulli wrote:

Looking for an interface and increasing its refcounter only to check if it really exists is not really useful and makes the code look more complex without a real gain.

Hm, I was intending to use it somewhere else as well with the next series of patches. See: http://git.open-mesh.org/batman-adv.git/commitdiff/bd774bd7e00bbe062cb0ab591...

But ok, since it is not in a yet scheduled patchset, I guess you're right, then it should better be introduced when it is needed.

On another note, I think you're introducing a bug/memoryleak here for the compat-code case for netdev_master_upper_dev_get_rcu().

Cheers, Linus