B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

Batman adv selective broadcast mechanism
by oytunyapar＠hotmail.com 31 Mar '21

31 Mar '21

Hi everybody, As I check, batman-adv protocol, sends IP broadcast packets, to every slave interface, including the slave interface from which the broadcast packet is received. Is there any way for preventing the batman-adv from sending IP broadcast packets to some of the slave interfaces (etc. the one which the packet is received)? Regards. Oytun

2 4

[PATCH net-next v3 0/7] mld: change context from atomic to sleepable
by Taehee Yoo 30 Mar '21

30 Mar '21

This patchset changes the context of MLD module. Before this patchset, MLD functions are atomic context so it couldn't use sleepable functions and flags. There are several reasons why MLD functions are under atomic context. 1. It uses timer API. Timer expiration functions are executed in the atomic context. 2. atomic locks MLD functions use rwlock and spinlock to protect their own resources. So, in order to switch context, this patchset converts resources to use RCU and removes atomic locks and timer API. 1. The first patch convert from the timer API to delayed work. Timer API is used for delaying some works. MLD protocol has a delay mechanism, which is used for replying to a query. If a listener receives a query from a router, it should send a response after some delay. But because of timer expire function is executed in the atomic context, this patch convert from timer API to the delayed work. 2. The fourth patch deletes inet6_dev->mc_lock. The mc_lock has protected inet6_dev->mc_tomb pointer. But this pointer is already protected by RTNL and it isn't be used by datapath. So, it isn't be needed and because of this, many atomic context critical sections are deleted. 3. The fifth patch convert ip6_sf_socklist to RCU. ip6_sf_socklist has been protected by ipv6_mc_socklist->sflock(rwlock). But this is already protected by RTNL So if it is converted to use RCU in order to be used in the datapath, the sflock is no more needed. So, its control path context can be switched to sleepable. 4. The sixth patch convert ip6_sf_list to RCU. The reason for this patch is the same as the previous patch. 5. The seventh patch convert ifmcaddr6 to RCU. The reason for this patch is the same as the previous patch. 6. Add new workqueues for processing query/report event. By this patch, query and report events are processed by workqueue So context is sleepable, not atomic. While this logic, it acquires RTNL. 7. Add new mc_lock. The purpose of this lock is to protect per-interface mld data. Per-interface mld data is usually used by query/report event handler. So, query/report event workers need only this lock instead of RTNL. Therefore, it could reduce bottleneck. Changelog: v2 -> v3: 1. Do not use msecs_to_jiffies(). (by Cong Wang) 2. Do not add unnecessary rtnl_lock() and rtnl_unlock(). (by Cong Wang) 3. Fix sparse warnings because of rcu annotation. (by kernel test robot) - Remove some rcu_assign_pointer(), which was used for non-rcu pointer. - Add union for rcu pointer. - Use rcu API in mld_clear_zeros(). - Remove remained rcu_read_unlock(). - Use rcu API for tomb resources. 4. withdraw prevopus 2nd and 3rd patch. - "separate two flags from ifmcaddr6->mca_flags" - "add a new delayed_work, mc_delrec_work" 5. Add 6th and 7th patch. v1 -> v2: 1. Withdraw unnecessary refactoring patches. (by Cong Wang, Eric Dumazet, David Ahern) a) convert from array to list. b) function rename. 2. Separate big one patch into small several patches. 3. Do not rename 'ifmcaddr6->mca_lock'. In the v1 patch, this variable was changed to 'ifmcaddr6->mca_work_lock'. But this is actually not needed. 4. Do not use atomic_t for 'ifmcaddr6->mca_sfcount' and 'ipv6_mc_socklist'->sf_count'. 5. Do not add mld_check_leave_group() function. 6. Do not add ip6_mc_del_src_bulk() function. 7. Do not add ip6_mc_add_src_bulk() function. 8. Do not use rcu_read_lock() in the qeth_l3_add_mcast_rtnl(). (by Julian Wiedmann) Taehee Yoo (7): mld: convert from timer to delayed work mld: get rid of inet6_dev->mc_lock mld: convert ipv6_mc_socklist->sflist to RCU mld: convert ip6_sf_list to RCU mld: convert ifmcaddr6 to RCU mld: add new workqueues for process mld events mld: add mc_lock for protecting per-interface mld data drivers/s390/net/qeth_l3_main.c | 6 +- include/net/if_inet6.h | 37 +- include/net/mld.h | 3 + net/batman-adv/multicast.c | 6 +- net/ipv6/addrconf.c | 9 +- net/ipv6/addrconf_core.c | 2 +- net/ipv6/af_inet6.c | 2 +- net/ipv6/icmp.c | 4 +- net/ipv6/mcast.c | 1080 ++++++++++++++++++------------- 9 files changed, 678 insertions(+), 471 deletions(-) -- 2.17.1

2 13

Problem with batman-adv and wifi adhoc in OpenWrt 19.07
by spiccinini＠altermundi.net 27 Mar '21

27 Mar '21

Hi all! I need some help debugging a non working setup of batman-adv with wifi in adhoc mode in OpenWrt 19.07 (a LibreMesh setup). Libremesh based on OpenWrt 19.07 + ad-hoc: not working Libremesh based on OpenWrt 19.07 + 802.11s: working Libremesh based on OpenWrt 18.06 + ad-hoc: working Libremesh based on OpenWrt 18.06 + 802.11s: working An issue with more info is here https://github.com/libremesh/lime-packages/issues/855 Thanks! SAn

2 2

[PATCH] batman-adv: Drop unused header preempt.h
by Sven Eckelmann 23 Mar '21

23 Mar '21

The commit 05456871ea96 ("batman-adv: Use netif_rx_any_context().") removed the last user for a function declaration from linux/preempt.h. The include should therefore be cleaned up. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- net/batman-adv/bridge_loop_avoidance.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c index bcd543ce..7dc133cf 100644 --- a/net/batman-adv/bridge_loop_avoidance.c +++ b/net/batman-adv/bridge_loop_avoidance.c @@ -25,7 +25,6 @@ #include <linux/lockdep.h> #include <linux/netdevice.h> #include <linux/netlink.h> -#include <linux/preempt.h> #include <linux/rculist.h> #include <linux/rcupdate.h> #include <linux/skbuff.h> -- 2.30.2

1 0

[PATCH maint] batman-adv: Fix order of kernel doc in batadv_priv
by Linus Lüssing 23 Mar '21

23 Mar '21

During the inlining process of kerneldoc some comments were placed at the wrong struct members. Fixing this by reordering the comments. Fixes: 6369b8e999af ("batman-adv: Use inline kernel-doc for enum/struct") Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> --- Note: checkpatch shows me a warning: ``` ~/dev-priv/linux/linux/scripts/checkpatch.pl --strict ./0001-batman-adv-Fix-order-of-kernel-doc-in-batadv_priv.patch CHECK: spinlock_t definition without comment #35: FILE: net/batman-adv/types.h:1665: + spinlock_t forw_bat_list_lock; CHECK: spinlock_t definition without comment #39: FILE: net/batman-adv/types.h:1668: + spinlock_t forw_bcast_list_lock; total: 0 errors, 0 warnings, 2 checks, 25 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./0001-batman-adv-Fix-order-of-kernel-doc-in-batadv_priv.patch has style problems, please review. ``` However it seems to be a false positive: ``` ~/dev-priv/linux/linux/scripts/checkpatch.pl -f ./net/batman-adv/types.h Traceback (most recent call last): File "scripts/spdxcheck.py", line 10, in <module> import git ImportError: No module named git total: 0 errors, 0 warnings, 2410 lines checked NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ./net/batman-adv/types.h has no obvious style problems and is ready for submission. ``` Checkpatch version is: e0c755a45f6f from net-master net/batman-adv/types.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 2f96e96a..30c78e6e 100644 --- a/net/batman-adv/types.h +++ b/net/batman-adv/types.h @@ -1658,19 +1658,19 @@ struct batadv_priv { /** @tp_list: list of tp sessions */ struct hlist_head tp_list; - /** @tp_num: number of currently active tp sessions */ - struct batadv_hashtable *orig_hash; - /** @orig_hash: hash table containing mesh participants (orig nodes) */ - spinlock_t forw_bat_list_lock; + struct batadv_hashtable *orig_hash; /** @forw_bat_list_lock: lock protecting forw_bat_list */ - spinlock_t forw_bcast_list_lock; + spinlock_t forw_bat_list_lock; /** @forw_bcast_list_lock: lock protecting forw_bcast_list */ - spinlock_t tp_list_lock; + spinlock_t forw_bcast_list_lock; /** @tp_list_lock: spinlock protecting @tp_list */ + spinlock_t tp_list_lock; + + /** @tp_num: number of currently active tp sessions */ atomic_t tp_num; /** @orig_work: work queue callback item for orig node purging */ -- 2.30.1

1 0

Neighbor and originator purge timeout
by oytunyapar＠hotmail.com 17 Mar '21

17 Mar '21

Hi everybody, As I checked from source code, BATADV_PURGE_TIMEOUT value determines: 1- When a node will be discarded from the neighbor list, if this particular node did not send ELP messages for BATADV_PURGE_TIMEOUT amount of time 2- When a node will be discarded from the originator list, if this particular node did not send OMG messages for 2 * BATADV_PURGE_TIMEOUT amount of time BATADV_PURGE_TIMEOUT is constant, and determined in compile time. It seem, it could not be configured via "batctl" utility. Am I correct? Regards. Oytun

1 0

batman-adv for kbit level speeds, external neighbor info
by oytunyapar＠hotmail.com 17 Mar '21

17 Mar '21

Hi everybody, I have some questions about batman-adv. Do you suggest, batman-adv, for speeds like 2.4kbit/s (very slow networks)? I tried to use batctl throughput_override, for such a setup. It seems at least 100kbit/s speed is valid for this utility. Is there any way, feeding neighbor information to batman-adv externally (etc. using DLEP protocol, as an external link monitor)? Thank you in advance. Regards. Oytun

3 4

[PATCH 0/1] pull request for net-next: batman-adv 2021-03-12
by Simon Wunderlich 13 Mar '21

13 Mar '21

Hi Jakub, hi David, this time we only have one patch in the pull request of batman-adv to go into net-next. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 25d81f9307ffc166427d93152498f45178f5936a: batman-adv: Fix names for kernel-doc blocks (2021-02-06 09:22:45 +0100) are available in the Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-pullrequest-20210312 for you to fetch changes up to b1de0f01b0115575982cf24c88b35106449e9aa7: batman-adv: Use netif_rx_any_context(). (2021-02-13 18:08:40 +0100) ---------------------------------------------------------------- There is only a single patch this time: - Use netif_rx_any_context(), by Sebastian Andrzej Siewior ---------------------------------------------------------------- Sebastian Andrzej Siewior (1): batman-adv: Use netif_rx_any_context(). net/batman-adv/bridge_loop_avoidance.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)

2 2

[PATCH] batman-adv: Use netif_rx_any_context().
by Sebastian Andrzej Siewior 11 Mar '21

11 Mar '21

The usage of in_interrupt() in non-core code is phased out. Ideally the information of the calling context should be passed by the callers or the functions be split as appropriate. The attempt to consolidate the code by passing an arguemnt or by distangling it failed due lack of knowledge about this driver and because the call chains are hard to follow. As a stop gap use netif_rx_any_context() which invokes the correct code path depending on context and confines the in_interrupt() usage to core code. Signed-off-by: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> --- net/batman-adv/bridge_loop_avoidance.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c index d2de12e527baa..b3411a034d87e 100644 --- a/net/batman-adv/bridge_loop_avoidance.c +++ b/net/batman-adv/bridge_loop_avoidance.c @@ -438,10 +438,7 @@ static void batadv_bla_send_claim(struct batadv_priv *bat_priv, u8 *mac, batadv_add_counter(bat_priv, BATADV_CNT_RX_BYTES, skb->len + ETH_HLEN); - if (in_interrupt()) - netif_rx(skb); - else - netif_rx_ni(skb); + netif_rx_any_context(skb); out: if (primary_if) batadv_hardif_put(primary_if); -- 2.30.0

2 3

battle for yocto
by Kamal R. Prasad 28 Feb '21

28 Feb '21

hello, can someone point me to some info on how to plug in batctl into a yocto build? the kernel provided by raspberry pi os already contains batman-adv kernel module but not batctl. thanks -kamal

3 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N