B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] [PATCH] batman-adv: wait multiple periods before activating bla
by Simon Wunderlich 23 Sep '12

23 Sep '12

For some reasons (bridge forward delay, network device setup order, etc) the initial bridge loop avoidance announcement packets may be lost. This may lead to problems in finding other backbone gws, and therfore create loops in the startup time. Fix this by extending the waiting periods to 3 (define can be changed) before allowing broadcast traffic. Signed-off-by: Simon Wunderlich <siwu(a)hrz.tu-chemnitz.de> --- bridge_loop_avoidance.c | 9 ++++++++- main.h | 1 + types.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index db046d8..93cf799 100644 --- a/bridge_loop_avoidance.c +++ b/bridge_loop_avoidance.c @@ -386,6 +386,7 @@ batadv_bla_get_backbone_gw(struct batadv_priv *bat_priv, uint8_t *orig, entry->crc = BATADV_BLA_CRC_INIT; entry->bat_priv = bat_priv; atomic_set(&entry->request_sent, 0); + atomic_set(&entry->wait_periods, 0); memcpy(entry->orig, orig, ETH_ALEN); /* one for the hash, one for returning */ @@ -415,6 +416,7 @@ batadv_bla_get_backbone_gw(struct batadv_priv *bat_priv, uint8_t *orig, /* this will be decreased in the worker thread */ atomic_inc(&entry->request_sent); + atomic_set(&entry->wait_periods, BATADV_BLA_WAIT_PERIODS); atomic_inc(&bat_priv->bla.num_requests); } @@ -1156,12 +1158,17 @@ static void batadv_bla_periodic_work(struct work_struct *work) * problems when we are not yet known as backbone gw * in the backbone. * - * We can reset this now and allow traffic again. + * We can reset this now after we waited some periods + * to give bridge forward delays and bla group forming + * some grace time. */ if (atomic_read(&backbone_gw->request_sent) == 0) continue; + if (!atomic_dec_and_test(&backbone_gw->wait_periods)) + continue; + atomic_dec(&backbone_gw->bat_priv->bla.num_requests); atomic_set(&backbone_gw->request_sent, 0); } diff --git a/main.h b/main.h index e828755..b45d5ad 100644 --- a/main.h +++ b/main.h @@ -89,6 +89,7 @@ #define BATADV_BLA_PERIOD_LENGTH 10000 /* 10 seconds */ #define BATADV_BLA_BACKBONE_TIMEOUT (BATADV_BLA_PERIOD_LENGTH * 3) #define BATADV_BLA_CLAIM_TIMEOUT (BATADV_BLA_PERIOD_LENGTH * 10) +#define BATADV_BLA_WAIT_PERIODS 3 #define BATADV_DUPLIST_SIZE 16 #define BATADV_DUPLIST_TIMEOUT 500 /* 500 ms */ diff --git a/types.h b/types.h index dc126e7..b425dde 100644 --- a/types.h +++ b/types.h @@ -326,6 +326,7 @@ struct batadv_backbone_gw { struct hlist_node hash_entry; struct batadv_priv *bat_priv; unsigned long lasttime; /* last time we heard of this backbone gw */ + atomic_t wait_periods; atomic_t request_sent; atomic_t refcount; struct rcu_head rcu; -- 1.7.10

2 1

[B.A.T.M.A.N.] running batmand on Debian for Alix
by Dominic Follett-Smith 22 Sep '12

22 Sep '12

Hi, I am having trouble running the batman protocol on my debian distro (2.6.32) on PC Engine's Alix boards. I am using CM9 pci cards, with ath5k driver from the compat-wireless-3.5 package. I can scan for networks, and view a survey dump using the iw tool. despite being able to start the daemon successfully, neither node can receive packets from one another. I set the mode to ad-hoc and channel to channel 7 on both alix boards. The following url is a link to my system profile on pastebin: http://pastebin.com/RtpTe31C it includes (ifconfig, iwconfig, interfaces configuration, sample of running batman, dmesg for wireless interface wlan0 and modinfo for ath5k ) I can't figure out what I am doing wrong, I had perhaps naively assumed that passing a configured wireless interface would be enough, but I guess I have missed something important. Help is always greatly appreciated. Thanks Dominic UCT, SA -- If you are going to achieve excellence in big things, you develop the habit in little matters. Excellence is not an exception, it is a prevailing attitude. Colin Powell

2 2

[B.A.T.M.A.N.] [PATCH net] batman-adv: make batadv_test_bit() return 0 or 1 only
by Antonio Quartulli 19 Sep '12

19 Sep '12

From: Linus Lüssing <linus.luessing(a)web.de> On some architectures test_bit() can return other values than 0 or 1: With a generic x86 OpenWrt image in a kvm setup (batadv_)test_bit() frequently returns -1 for me, leading to batadv_iv_ogm_update_seqnos() wrongly signaling a protected seqno window. This patch tries to fix this issue by making batadv_test_bit() return 0 or 1 only. Signed-off-by: Linus Lüssing <linus.luessing(a)web.de> Acked-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- net/batman-adv/bitarray.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/batman-adv/bitarray.h b/net/batman-adv/bitarray.h index a081ce1..cebaae7 100644 --- a/net/batman-adv/bitarray.h +++ b/net/batman-adv/bitarray.h @@ -20,8 +20,8 @@ #ifndef _NET_BATMAN_ADV_BITARRAY_H_ #define _NET_BATMAN_ADV_BITARRAY_H_ -/* returns true if the corresponding bit in the given seq_bits indicates true - * and curr_seqno is within range of last_seqno +/* Returns 1 if the corresponding bit in the given seq_bits indicates true + * and curr_seqno is within range of last_seqno. Otherwise returns 0. */ static inline int batadv_test_bit(const unsigned long *seq_bits, uint32_t last_seqno, uint32_t curr_seqno) @@ -32,7 +32,7 @@ static inline int batadv_test_bit(const unsigned long *seq_bits, if (diff < 0 || diff >= BATADV_TQ_LOCAL_WINDOW_SIZE) return 0; else - return test_bit(diff, seq_bits); + return test_bit(diff, seq_bits) != 0; } /* turn corresponding bit on, so we can remember that we got the packet */ -- 1.7.12

2 1

[B.A.T.M.A.N.] echo counting in batmand
by Dominic Follett-Smith 18 Sep '12

18 Sep '12

HI there, I am trying to trace where the protocol updates its count of echos via a neighbour. So far this is what I am interpreting: If I know that the OGM came from this station, then we can record that we got the packet in bit_mark, and update our neighbour's bcast_own_sum in their originator entry. if ((has_directlink_flag) && (if_incoming->addr.sin_addr.s_addr == bat_packet->orig) && (bat_packet->seqno - if_incoming->out.seqno + 2 == 0)) { debug_output(4, "count own bcast (is_my_orig): old = %i, ", orig_neigh_node->bcast_own_sum[if_incoming->if_num]); bit_mark((TYPE_OF_WORD *)&(orig_neigh_node->bcast_own[if_incoming->if_num * num_words]), 0); orig_neigh_node->bcast_own_sum[if_incoming->if_num] = bit_packet_count((TYPE_OF_WORD *)&(orig_neigh_node->bcast_own[if_incoming->if_num * num_words])); debug_output(4, "new = %i \n", orig_neigh_node->bcast_own_sum[if_incoming->if_num]); } What I am trying to see is where the sliding window (of size local_window_size) for echos is defined. This I cannot locate, and in my report I am saying that bcast_own_sum is the sliding window for echos, which I am not sure is correct or incorrect. Thanks in advance for the help. Regards Dominic UCT, SA

2 1

Re: [B.A.T.M.A.N.] How to force a specific network topology
by Martin Hundebøll 14 Sep '12

14 Sep '12

Hi Esteban You can try my patch to filter OGMs: http://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/hundeboll/filter The commit message tells how to use it. Unfortunately, its base is quite old, but it should be easy to rebase. Otherwise I can rebase it when I return from Canada next week... Cheers, Martin PS: Sorry for top posting. This Android client want let me change it :( Sven Eckelmann <sven(a)narfation.org> wrote: >On Friday 07 September 2012 16:58:33 Esteban Municio wrote: >> Hi list >> >> Is there any way to block some links between nodes in order to force a >> specific network topology in batman-adv? >> >> Por example, if y have 3 nodes A, B, C and I want to create a string >> topology A <-> B <-> C, where A can not connect directly with C, how >> could I get it without move far away the nodes? > >You can try to add a your interface to a bridge (only one interface per >bridge) and add this bridge to batman-adv. Now you can filter packets using >ebtables (and therefore drop packets from specific hosts). > >Kind regards, > Sven

4 7

[B.A.T.M.A.N.] interface preference
by adam wiz 13 Sep '12

13 Sep '12

Is there any manual way to prioritize a wired interface over a wireless interface? It seems to do so naturally at first, but if I unplug and replug the Ethernet cable a couple times when testing it will stay on wireless. Is this considered an optimization or a bug, and how can I make it so it should always choose the Ethernet, even in multi-hop situations? For example, Babel uses an "rxcost" metric for each interface to manually increase the cost of a route on each interface. Thanks for your help.

2 1

[B.A.T.M.A.N.] 2012.2 OGMs over ethernet issue?
by Guido Iribarren 13 Sep '12

13 Sep '12

Hello again nice folks, I updated today another segment of the network with just 4 nodes, to batman-adv 2012.2 (the one i compiled yesterday with simon patches for blaII, marek stability fixes, and debug log enabled , yikes!) and i couldn't get batman to work over wired ethernet?? (?) P -(50mts wlan)- D -----(ubnt transparent bridge) 2km -- C \----eth-------------------/ Node P and D connected by ethernet on eth0 but close enough that could also see each other through adhoc wlan, with bla enabled, correctly preferred ethernet connection to communicate between them (iperf yielded 92mbps), so far so good. now, node D and C, too far away from each other to communicate over wlan, but connected by a "loooong eth cable" (mediated by a wds transparent bridge) wouldn't find each other batman originator. C originator table was empty, and D only showed P. I thought the transparent bridge was misbehaving, so I tried in a simpler setup using P and D, with the wifi off: but after disabling wlan0 (batctl if del wlan0-2) and adding eth0 (batctl if add eth0) on both nodes, batman could not see each other anymore :( i thought i was doing something wrong, so i tried in different ways, but could not get it to work. batctl td eth0 shows both outgoing OGMs from local , and incoming OGMs from remote, but batctl l only reported outgoing OGMs. http://pastebin.com/7DDUaXu1 diego is local node ("D"), palmeras is on the other side of the ethernet cable ("P") (and jure is further away, connected to palmeras by adhoc wlan, not illustrated in the previous ascii art) i hope i'm overlooking something really obvious? Have a nice weekend! Gui

5 9

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: send announcement when backbone gw is registered
by Simon Wunderlich 13 Sep '12

13 Sep '12

To avoid loops in the startup phase until the first announcement is sent, send an announcement immediately as soon as a backbone gw is added. This may happen due to various reasons, e.g. a packet passes the rx or tx path. Signed-off-by: Simon Wunderlich <siwu(a)hrz.tu-chemnitz.de> --- bridge_loop_avoidance.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index 0921509..c522bdf 100644 --- a/bridge_loop_avoidance.c +++ b/bridge_loop_avoidance.c @@ -362,7 +362,7 @@ out: */ static struct batadv_backbone_gw * batadv_bla_get_backbone_gw(struct batadv_priv *bat_priv, uint8_t *orig, - short vid) + short vid, bool own_backbone) { struct batadv_backbone_gw *entry; struct batadv_orig_node *orig_node; @@ -409,6 +409,10 @@ batadv_bla_get_backbone_gw(struct batadv_priv *bat_priv, uint8_t *orig, "became a backbone gateway"); batadv_orig_node_free_ref(orig_node); } + + if (own_backbone) + batadv_bla_send_announce(bat_priv, entry); + return entry; } @@ -424,7 +428,7 @@ batadv_bla_update_own_backbone_gw(struct batadv_priv *bat_priv, backbone_gw = batadv_bla_get_backbone_gw(bat_priv, primary_if->net_dev->dev_addr, - vid); + vid, true); if (unlikely(!backbone_gw)) return; @@ -632,7 +636,8 @@ static int batadv_handle_announce(struct batadv_priv *bat_priv, if (memcmp(an_addr, batadv_announce_mac, 4) != 0) return 0; - backbone_gw = batadv_bla_get_backbone_gw(bat_priv, backbone_addr, vid); + backbone_gw = batadv_bla_get_backbone_gw(bat_priv, backbone_addr, vid, + false); if (unlikely(!backbone_gw)) return 1; @@ -730,7 +735,8 @@ static int batadv_handle_claim(struct batadv_priv *bat_priv, /* register the gateway if not yet available, and add the claim. */ - backbone_gw = batadv_bla_get_backbone_gw(bat_priv, backbone_addr, vid); + backbone_gw = batadv_bla_get_backbone_gw(bat_priv, backbone_addr, vid, + false); if (unlikely(!backbone_gw)) return 1; -- 1.7.10

2 5

[B.A.T.M.A.N.] [PATCHv2] batman-adv: prevent using any virtual device created on batman-adv as hard-interface
by Antonio Quartulli 13 Sep '12

13 Sep '12

Any virtual device created on top of a batman-adv mesh interface must be prevented to be used to create a new mesh network (this would lead to an unwanted batman-over-batman configuration) Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- v2: - added check for !parent_dev with WARN_ON() hard-interface.c | 41 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/hard-interface.c b/hard-interface.c index fab9e41..7967f14 100644 --- a/hard-interface.c +++ b/hard-interface.c @@ -58,6 +58,45 @@ out: return hard_iface; } +/** + * batadv_is_on_batman_iface - check if a device is a batman iface descendant + * @net_dev: the device to check + * + * If the user creates any virtual device on top of a batman-adv interface, it + * is important to prevent this new interface to be used to create a new mesh + * network (this behaviour would lead to a batman-over-batman configuration). + * This function recursively checks all the fathers of the device passed as + * argument looking for a batman-adv soft interface. + * + * Returns true if the device is descendant of a batman-adv mesh interface (or + * if it is a batman-adv interface itself), false otherwise + */ +static bool batadv_is_on_batman_iface(const struct net_device *net_dev) +{ + struct net_device *parent_dev; + bool ret; + + /* check if this is a batman-adv mesh interface */ + if (batadv_softif_is_valid(net_dev)) + return true; + + /* no more parents..stop recursion */ + if (net_dev->iflink == net_dev->ifindex) + return false; + + /* recurse over the parent device */ + parent_dev = dev_get_by_index(&init_net, net_dev->iflink); + /* if we got a NULL parent_dev there is something broken.. */ + if (WARN(!parent_dev, "Cannot find parent device")) + return false; + + ret = batadv_is_on_batman_iface(parent_dev); + + if (parent_dev) + dev_put(parent_dev); + return ret; +} + static int batadv_is_valid_iface(const struct net_device *net_dev) { if (net_dev->flags & IFF_LOOPBACK) @@ -70,7 +109,7 @@ static int batadv_is_valid_iface(const struct net_device *net_dev) return 0; /* no batman over batman */ - if (batadv_softif_is_valid(net_dev)) + if (batadv_is_on_batman_iface(net_dev)) return 0; return 1; -- 1.7.12

2 1

[B.A.T.M.A.N.] Batman, TTL, broadcast, etc. (UNCLASSIFIED)
by Karan, Cem F CIV (US) 10 Sep '12

10 Sep '12

Classification: UNCLASSIFIED Caveats: NONE Hi all, I'm trying to get some information on how batman works to determine what my next steps are for an experiment I'm running. I'm hoping someone on the list can tell me how Batman operates RIGHT NOW, not just how it is intended to operate in the future, so I can make reasonable plans. 1) I'm guessing from the following pages (which only describe roaming and announcement behaviors) that the TTL field of all packets is decremented by 1. Is this true? http://www.open-mesh.org/projects/batman-adv/wiki/Client-roaming http://www.open-mesh.org/projects/batman-adv/wiki/Client-announcement 2) Follow up to question 1; are the TTL fields of Batman packets and IP packets linked in some way? The library I'm using (zeromq, http://www.zeromq.org/) has a reliable multicast transport built on top of OpenPGM (http://code.google.com/p/openpgm/). My plan is to simulate reliable 1-hop broadcast by using reliable multicast and setting the TTL field to 1. However, this will only affect the IP layer. Unless batman also decrements the TTL field of the IP packets traveling over it, I'm kind of stuck. 3) Finally, does batman have the equivalent of multicast or (better yet) broadcast for data packets? That is, if I send something to a multicast IP address which all of its 1-hop neighbors are listening to, will all of them listen to the packet simultaneously, or will it act like a series of unicast messages? If you're wondering what I'm trying to do, message me directly. It's easy to explain, but off topic for this list. Thanks, Cem Karan Classification: UNCLASSIFIED Caveats: NONE

2 4

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N