B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[PATCH 1/2] batman-adv: Move IRC channel to hackint.org
by Sven Eckelmann 13 Jun '21

13 Jun '21

Due to recent developments around the Freenode.org IRC network, the opinions about the usage of this service shifted dramatically. The majority of the still active users of the #batman channel prefers a move to the hackint.org network. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- Documentation/networking/batman-adv.rst | 2 +- MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/batman-adv.rst b/Documentation/networking/batman-adv.rst index 74821d29a22f..b85563ea3682 100644 --- a/Documentation/networking/batman-adv.rst +++ b/Documentation/networking/batman-adv.rst @@ -157,7 +157,7 @@ Contact Please send us comments, experiences, questions, anything :) IRC: - #batman on irc.freenode.org + #batadv on ircs://irc.hackint.org/ Mailing-list: b.a.t.m.a.n(a)open-mesh.org (optional subscription at https://lists.open-mesh.org/mailman3/postorius/lists/b.a.t.m.a.n.lists.open…) diff --git a/MAINTAINERS b/MAINTAINERS index c6cdd550cd3a..b0cebd3a2e21 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3169,7 +3169,7 @@ S: Maintained W: https://www.open-mesh.org/ Q: https://patchwork.open-mesh.org/project/batman/list/ B: https://www.open-mesh.org/projects/batman-adv/issues -C: irc://chat.freenode.net/batman +C: ircs://irc.hackint.org/batadv T: git https://git.open-mesh.org/linux-merge.git F: Documentation/networking/batman-adv.rst F: include/uapi/linux/batadv_packet.h -- 2.30.2

1 1

MediaTek MT7612u and IBSS mode
by Maurice Smulders 11 Jun '21

11 Jun '21

Platform: Raspberry Pi 4B / CM4 with CentOS 8 stream 64 bit - 5.10.42 kernel Trying to use this Mediatek USB device and I notice a - quite nasty - problem using IBSS mode. On startup of the IBSS network, there is a chance the Pi goes into a tizzy https://github.com/openwrt/mt76/issues/543 - when it's the first (and only) node. I was able to dupe it consistently in my home - fairly static network - but not anymore in a lab environment. I cannot easily go back home - it's ~3000km from where I am at temporarily. Does anyone have experience with these MediaTek devices and B.A.T.M.A.N. on lower performance nodes like a Raspberry Pi... I have ascertained that NONE of the USB Realtek dongles work, as the kernel driver is missing IBSS support at this time... I'm against an urgent deadline, and trying to understand what I can do to make this work MfG, - Maurice

2 1

[PATCH 00/11] pull request for net-next: batman-adv 2021-06-08
by Simon Wunderlich 08 Jun '21

08 Jun '21

Hi Jakub, hi David, here is a feature/cleanup pull request of batman-adv to go into net-next. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 30515832e987597eae354f6ffcdb3374bdfde16d: net: bridge: fix build when IPv6 is disabled (2021-05-14 10:38:59 -0700) are available in the Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-pullrequest-20210608 for you to fetch changes up to 020577f879be736bc87e1f48dfad7220923401c0: batman-adv: Drop reduntant batadv interface check (2021-06-02 22:25:45 +0200) ---------------------------------------------------------------- This feature/cleanup patchset includes the following patches: - bump version strings, by Simon Wunderlich - consistently send iface index/name in genlmsg, by Sven Eckelmann - improve broadcast queueing, by Linus Lüssing (2 patches) - add support for routable IPv4 multicast with bridged setups, by Linus Lüssing - remove repeated declarations, by Shaokun Zhang - fix spelling mistakes, by Zheng Yongjun - clean up hard interface handling after dropping sysfs support, by Sven Eckelmann (4 patches) ---------------------------------------------------------------- Linus Lüssing (3): batman-adv: bcast: queue per interface, if needed batman-adv: bcast: avoid skb-copy for (re)queued broadcasts batman-adv: mcast: add MRD + routable IPv4 multicast with bridges support Shaokun Zhang (1): batman-adv: Remove the repeated declaration Simon Wunderlich (1): batman-adv: Start new development cycle Sven Eckelmann (5): batman-adv: Always send iface index+name in genlmsg batman-adv: Drop implicit creation of batadv net_devices batman-adv: Avoid name based attaching of hard interfaces batman-adv: Don't manually reattach hard-interface batman-adv: Drop reduntant batadv interface check Zheng Yongjun (1): batman-adv: Fix spelling mistakes net/batman-adv/bat_iv_ogm.c | 6 + net/batman-adv/bat_v.c | 10 + net/batman-adv/bridge_loop_avoidance.c | 4 +- net/batman-adv/bridge_loop_avoidance.h | 1 - net/batman-adv/hard-interface.c | 65 +----- net/batman-adv/hard-interface.h | 3 +- net/batman-adv/hash.h | 2 +- net/batman-adv/main.h | 3 +- net/batman-adv/multicast.c | 41 +--- net/batman-adv/netlink.c | 8 + net/batman-adv/routing.c | 9 +- net/batman-adv/send.c | 374 ++++++++++++++++++++++----------- net/batman-adv/send.h | 12 +- net/batman-adv/soft-interface.c | 49 +---- net/batman-adv/soft-interface.h | 2 - 15 files changed, 310 insertions(+), 279 deletions(-)

2 12

[PATCH 0/1] pull request for net: batman-adv 2021-06-08
by Simon Wunderlich 08 Jun '21

08 Jun '21

Hi David, hi Jakub, here is a bugfix for batman-adv which we would like to have integrated into net. Please pull or let me know of any problem! Thank you, Simon The following changes since commit b741596468b010af2846b75f5e75a842ce344a6e: Merge tag 'riscv-for-linus-5.13-mw1' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux (2021-05-08 11:52:37 -0700) are available in the Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-pullrequest-20210608 for you to fetch changes up to 9f460ae31c4435fd022c443a6029352217a16ac1: batman-adv: Avoid WARN_ON timing related checks (2021-05-18 21:10:01 +0200) ---------------------------------------------------------------- Here is a batman-adv bugfix: - Avoid WARN_ON timing related checks, by Sven Eckelmann ---------------------------------------------------------------- Sven Eckelmann (1): batman-adv: Avoid WARN_ON timing related checks net/batman-adv/bat_iv_ogm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

2 2

WARNING in batadv_iv_send_outstanding_bat_ogm_packet
by Tetsuo Handa 06 Jun '21

06 Jun '21

syzbot is hitting WARN_ON(forw_packet->if_outgoing->soft_iface != soft_iface) at batadv_iv_ogm_emit() [1]. This WARN_ON() was added by commit ef0a937f7a1450d3 ("batman-adv: consider outgoing interface in OGM sending") but it is unclear why it needs to use WARN_ON(). Is this fatal error worth crashing the kernel? Please consider replacing with pr_err() etc. like commit b4142fc4d52d051d ("drm/vkms: fix misuse of WARN_ON") does if this is not a kernel bug. [1] https://syzkaller.appspot.com/bug?id=9dc0c4cd70ad72df352243e887fd7e18901e7c…

2 4

[RFC PATCH 1/2] batctl: Combine command section attributes
by Sven Eckelmann 05 Jun '21

05 Jun '21

The __used__ and __section__ attribute for the batctl commands can be combined together to simplify the COMMAND_NAMED macro. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.h b/main.h index d1bea23..00b2ab3 100644 --- a/main.h +++ b/main.h @@ -112,7 +112,7 @@ struct command { .usage = (_usage), \ }; \ static const struct command *__command_ ## _name ## _ ## _type \ - __attribute__((__used__)) __attribute__ ((__section__ ("__command"))) = &command_ ## _name ## _ ## _type + __attribute__((__used__,__section__ ("__command"))) = &command_ ## _name ## _ ## _type #define COMMAND(_type, _handler, _abbr, _flags, _arg, _usage) \ COMMAND_NAMED(_type, _handler, _abbr, _handler, _flags, _arg, _usage) -- 2.30.2

1 1

[PATCH 1/4] batman-adv: Drop implicit creation of batadv net_devices
by Sven Eckelmann 02 Jun '21

02 Jun '21

The sysfs code in batman-adv was could create a new batadv interfaces on demand when a string (interface name) was written to the batman-adv/mesh_iface file. But the code no longer exists in the current batman-adv codebase. The helper code to implement this behavior must be considered as unused and can be dropped. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- net/batman-adv/hard-interface.c | 12 ++---------- net/batman-adv/soft-interface.c | 34 +-------------------------------- net/batman-adv/soft-interface.h | 2 -- 3 files changed, 3 insertions(+), 45 deletions(-) diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c index 4a6a25d5..9a78789b 100644 --- a/net/batman-adv/hard-interface.c +++ b/net/batman-adv/hard-interface.c @@ -725,17 +725,9 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface, kref_get(&hard_iface->refcount); soft_iface = dev_get_by_name(net, iface_name); - if (!soft_iface) { - soft_iface = batadv_softif_create(net, iface_name); - - if (!soft_iface) { - ret = -ENOMEM; - goto err; - } - - /* dev_get_by_name() increases the reference counter for us */ - dev_hold(soft_iface); + ret = -EINVAL; + goto err; } if (!batadv_softif_is_valid(soft_iface)) { diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index a21884c0..0c5b3425 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -26,7 +26,6 @@ #include <linux/netdevice.h> #include <linux/netlink.h> #include <linux/percpu.h> -#include <linux/printk.h> #include <linux/random.h> #include <linux/rculist.h> #include <linux/rcupdate.h> @@ -37,6 +36,7 @@ #include <linux/stddef.h> #include <linux/string.h> #include <linux/types.h> +#include <net/net_namespace.h> #include <net/netlink.h> #include <uapi/linux/batadv_packet.h> #include <uapi/linux/batman_adv.h> @@ -1086,38 +1086,6 @@ static int batadv_softif_newlink(struct net *src_net, struct net_device *dev, return register_netdevice(dev); } -/** - * batadv_softif_create() - Create and register soft interface - * @net: the applicable net namespace - * @name: name of the new soft interface - * - * Return: newly allocated soft_interface, NULL on errors - */ -struct net_device *batadv_softif_create(struct net *net, const char *name) -{ - struct net_device *soft_iface; - int ret; - - soft_iface = alloc_netdev(sizeof(struct batadv_priv), name, - NET_NAME_UNKNOWN, batadv_softif_init_early); - if (!soft_iface) - return NULL; - - dev_net_set(soft_iface, net); - - soft_iface->rtnl_link_ops = &batadv_link_ops; - - ret = register_netdevice(soft_iface); - if (ret < 0) { - pr_err("Unable to register the batman interface '%s': %i\n", - name, ret); - free_netdev(soft_iface); - return NULL; - } - - return soft_iface; -} - /** * batadv_softif_destroy_netlink() - deletion of batadv_soft_interface via * netlink diff --git a/net/batman-adv/soft-interface.h b/net/batman-adv/soft-interface.h index 38b0ad18..67a2ddd6 100644 --- a/net/batman-adv/soft-interface.h +++ b/net/batman-adv/soft-interface.h @@ -12,14 +12,12 @@ #include <linux/netdevice.h> #include <linux/skbuff.h> #include <linux/types.h> -#include <net/net_namespace.h> #include <net/rtnetlink.h> int batadv_skb_head_push(struct sk_buff *skb, unsigned int len); void batadv_interface_rx(struct net_device *soft_iface, struct sk_buff *skb, int hdr_size, struct batadv_orig_node *orig_node); -struct net_device *batadv_softif_create(struct net *net, const char *name); bool batadv_softif_is_valid(const struct net_device *net_dev); extern struct rtnl_link_ops batadv_link_ops; int batadv_softif_create_vlan(struct batadv_priv *bat_priv, unsigned short vid); -- 2.30.2

1 3

Re: [PATCH net-next] batman-adv: Fix spelling mistakes
by Sven Eckelmann 02 Jun '21

02 Jun '21

On Wednesday, 2 June 2021 08:56:03 CEST Zheng Yongjun wrote: > Fix some spelling mistakes in comments: > containg ==> containing > dont ==> don't > datas ==> data > brodcast ==> broadcast > > Signed-off-by: Zheng Yongjun <zhengyongjun3(a)huawei.com> > --- > net/batman-adv/bridge_loop_avoidance.c | 4 ++-- > net/batman-adv/hard-interface.c | 2 +- > net/batman-adv/hash.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) You forgot to send it to the B.A.T.M.A.N. mailing list. And it therefore didn't appear in our patchwork. And you send stuff from the future - which is rather odd. Applied anyway. Thanks, Sven

2 1

irc update
by Aiyion.Prime 01 Jun '21

01 Jun '21

Hey there; I just dropped my freenode connection for good and wanted to ask, whether it'd be possible to announce via mail, if and where #batman migrates? Thanks in advance, Aiyion

2 1

Re: [syzbot] INFO: task hung in register_netdevice_notifier (2)
by syzbot 01 Jun '21

01 Jun '21

syzbot has bisected this issue to: commit 6bf071bf09d4b2ff3ee8783531e2ce814f0870cb Author: Jesper Dangaard Brouer <brouer(a)redhat.com> Date: Tue Jun 18 13:05:27 2019 +0000 xdp: page_pool related fix to cpumap bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1397c4a7d00000 start commit: 7ac3a1c1 Merge tag 'mtd/fixes-for-5.13-rc4' of git://git.k.. git tree: upstream final oops: https://syzkaller.appspot.com/x/report.txt?x=1057c4a7d00000 console output: https://syzkaller.appspot.com/x/log.txt?x=1797c4a7d00000 kernel config: https://syzkaller.appspot.com/x/.config?x=266cda122a0b56c dashboard link: https://syzkaller.appspot.com/bug?extid=355f8edb2ff45d5f95fa syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16cc630fd00000 Reported-by: syzbot+355f8edb2ff45d5f95fa(a)syzkaller.appspotmail.com Fixes: 6bf071bf09d4 ("xdp: page_pool related fix to cpumap") For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N