B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] [PATCHv9 0/3] TT-VLAN: First patchset
by Antonio Quartulli 26 Jun '13

26 Jun '13

Hello folks, after version 4 I decided to split the bug TT-VLAN batch in several patchsets to make them easier to get digested by the maintainers. This is the fourth iteration of the first patchset. Difference from v8: - remove bat_priv->ap_isolation and converts code using it to use vlan->ap_isolation Difference from v7: - fixed refcounting for mesh_obj (must be increased when used by the untagged LAN) - added kernel doc for batadv_softif_destroy_vlan() - added kernel doc for batadv_vlan_kobj_to_batpriv() - moved changes to sysfs routine from patch 3/3 to 2/3. In this way patch 2 is the only one manipulating the sysfs framework Differences from v6: - added patch introducing the per-VLAN ap_isolation attribute. It made no sense to have the new framework without a user. This patch introduces it. - removed the "novlan" sysfs folder. To avoid confusion and keep backward compatibility in a sane way, attributes corresponding to the untagged LAN are located in the root sysfs mesh folder (as it was done before). To implement this, some changes to the sysfs routines were needed (with respect to v6). - the array used to build the sysfs subfolder name now has a proper size instead of a too generic "256". Differences from v5 are: - added "untagged VLAN" removal routine. In the previous code the "untagged VLAN" was added but never removed. - use the correct vid argument when invoking batadv_tt_local_remove(). One invocation to the mentioned function was getting a vid that was not ORed with the HAS_TAG flag. However, such invocation has been enclosed into the new batadv_softif_destroy_vlan() function introduced to account the previous point. - bat_priv->softif_vlan_list is now an hlist instead of of a list. Thanks to Marek for his feedback. Antonio Quartulli (3): batman-adv: add per VLAN interface attribute framework batman-adv: add sysfs framework for VLAN batman-adv: make the AP isolation attribute VLAN specific compat.c | 9 +++ compat.h | 24 +++++++ hard-interface.c | 2 + main.c | 5 +- soft-interface.c | 176 ++++++++++++++++++++++++++++++++++++++++++++++++++- soft-interface.h | 4 ++ sysfs-class-net-mesh | 5 +- sysfs.c | 175 +++++++++++++++++++++++++++++++++++++++++++++++++- sysfs.h | 10 +++ translation-table.c | 27 ++++++-- translation-table.h | 2 +- types.h | 25 +++++++- 12 files changed, 445 insertions(+), 19 deletions(-) -- 1.8.1.5

2 5

[B.A.T.M.A.N.] [PATCHv8 0/3] TT-VLAN: First patchset
by Antonio Quartulli 26 Jun '13

26 Jun '13

Hello folks, after version 4 I decided to split the bug TT-VLAN batch in several patchsets to make them easier to get digested by the maintainers. This is the fourth iteration of the first patchset. Difference from v7: - fixed refcounting for mesh_obj (must be increased when used by the untagged LAN) - added kernel doc for batadv_softif_destroy_vlan() - added kernel doc for batadv_vlan_kobj_to_batpriv() - moved changes to sysfs routine from patch 3/3 to 2/3. In this way patch 2 is the only one manipulating the sysfs framework Differences from v6: - added patch introducing the per-VLAN ap_isolation attribute. It made no sense to have the new framework without a user. This patch introduces it. - removed the "novlan" sysfs folder. To avoid confusion and keep backward compatibility in a sane way, attributes corresponding to the untagged LAN are located in the root sysfs mesh folder (as it was done before). To implement this, some changes to the sysfs routines were needed (with respect to v6). - the array used to build the sysfs subfolder name now has a proper size instead of a too generic "256". Differences from v5 are: - added "untagged VLAN" removal routine. In the previous code the "untagged VLAN" was added but never removed. - use the correct vid argument when invoking batadv_tt_local_remove(). One invocation to the mentioned function was getting a vid that was not ORed with the HAS_TAG flag. However, such invocation has been enclosed into the new batadv_softif_destroy_vlan() function introduced to account the previous point. - bat_priv->softif_vlan_list is now an hlist instead of of a list. Thanks to Marek for his feedback. Antonio Quartulli (3): batman-adv: add per VLAN interface attribute framework batman-adv: add sysfs framework for VLAN batman-adv: make the AP isolation attribute VLAN specific compat.c | 9 +++ compat.h | 24 +++++++ hard-interface.c | 2 + main.c | 5 +- soft-interface.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++++++- soft-interface.h | 4 ++ sysfs-class-net-mesh | 5 +- sysfs.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++++++- sysfs.h | 10 +++ translation-table.c | 21 +++++-- translation-table.h | 2 +- types.h | 23 +++++++ 12 files changed, 440 insertions(+), 15 deletions(-) -- 1.8.1.5

1 4

[B.A.T.M.A.N.] Basic Multicast Optimizations
by Linus Lüssing 26 Jun '13

26 Jun '13

This is the sixth revision of the basic multicast optimization patches. It simplifies and speeds-up the new batadv_tt_global_hash_count(): * We now use batadv_tt_global_hash_find() instead of our custom look-up. * A counter for the orig_list was added, so that we won't need to recount with every multicast packet. Cheers, Linus

4 9

[B.A.T.M.A.N.] [RFC 00/10] Improving the routing protocol abstraction
by Antonio Quartulli 26 Jun '13

26 Jun '13

Hello list, with this RFC I'd like to introduce some new routing API functions meant to improve the routing protocol abstraction. This changes have been written while developing batman V. The latter helped me in understanding what batman iv and v have in common and what not. The main problem was the metric: the two protocols use different metric domains and different semantics. Therefore all the functions handling/printing the metric needed to be generalised and rearranged to let the protocols decide what to do. Another issue was the way routing protocols handle the orig and neigh node structures. Also these two have been changed and some small APIs have been provided as well. Moreover, after Simon's RFC about the new multi-interface optimisation, we saw the need for a better abstraction so that mechanisms like that could easily be re-used by new algorithms (like batman v) with little effort. The new API functions are the following: + metric related: - bat_metric_get - bat_metric_is_similar - bat_metric_compare + orig_node related: - bat_orig_print: print the originator table - bat_orig_add_if - bat_orig_del_if - bat_orig_free Any feedback will surely be welcome :-) Cheers, p.s. there are some small "checkpatch glitches" but they will be removed before this RFC becomes a real patchset :) Antonio Quartulli (10): batman-adv: make struct batadv_neigh_node algorithm agnostic batman-adv: make struct batadv_orig_node algorithm agnostic batman-adv: add bat_orig_print function API batman-adv: add bat_metric_get API function batman-adv: add bat_metric_is_similar API function batman-adv: add bat_metric_compare API function batman-adv: adapt bonding to use the new API functions batman-adv: adapt the gateway feature to use the new API functions batman-adv: adapt the neighbor purging routine to use the new API functions batman-adv: provide orig_node routing API bat_iv_ogm.c | 373 +++++++++++++++++++++++++++++++++++++++++++--------- gateway_client.c | 74 ++++++----- main.c | 5 +- main.h | 7 + network-coding.c | 8 +- originator.c | 238 ++++++++------------------------- originator.h | 5 +- routing.c | 37 ++++-- routing.h | 3 +- translation-table.c | 4 +- types.h | 106 +++++++++------ 11 files changed, 518 insertions(+), 342 deletions(-) -- 1.8.1.5

3 26

[B.A.T.M.A.N.] Possible bad interaction between BLA2 and TT?
by Gui Iribarren 25 Jun '13

25 Jun '13

Hey everyone! fiiinally got back home, a week ago, and got time to debug a strange issue here. The report i had from a few users was "intermittent connectivity", with "waves" of traffic, with random pauses lasting from a few seconds to a minute or so. I initially dismissed as interference, or even OS problems, but turns out they were right! and sadly, batman seems to be in the way From what i've seen, watching "batctl tg -w" on every node along the way, i could determine the window of time where the traffic gets lost: from the moment when there's a TT change on one side of the network, to the moment that change is propagated to the other side. By ordex's advice, i ran some "batctl ll tt ; batctl l" along the way and i'm sending the pastebin results at the end of this mail. Some (hopefully) useful context follows, and a batctl vd graph is attached The IPv6 of tdorado is pinged (to rule out DAT interactions) from labanda-este (works fine always) and from labanda-oeste (suffers the issue, as well as all nodes "behind" it, i.e. casapuente & alfredo). both labandas are tl-wdr3500 connected by 2.4ghz, 5ghz, and an ethernet cable. The ethernet carries only batadv packets (eth0.1 is added to bat0); there's no "lan backbone" (the eth0.2 that appears under br-lan is not connected to anything) root@tdorado:~# opkg list kmod-batman-adv # same in all nodes kmod-batman-adv - 3.8.3+2013.2.0-2 root@tdorado:~# ip a s br-lan 6: br-lan: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP link/ether 64:70:02:3d:a0:f7 brd ff:ff:ff:ff:ff:ff inet6 2a00:1508:1:f004:6670:2ff:fe3d:a0f7/64 scope global dynamic valid_lft 6985sec preferred_lft 6985sec root@tdorado:~# batctl tl -n |grep f7 * 64:70:02:3d:a0:f7 [.....] 1.140 root@tdorado:~# batctl o |head -n 1 [B.A.T.M.A.N. adv 2013.2.0, MainIF/MAC: wlan0-1/66:70:02:3d:a0:f9 (bat0)] labanda-este http://pastebin.com/R1kHQCQG labanda-oeste http://pastebin.com/b1Uc23VZ Both ping6s were started at the same time, so the seq numbers are synchronized, and can be used as timestamps. the "gap" in labanda-oeste is between seq=73 and seq=89 in labanda-oeste there were no messages or traffic for 25secs, and then the "TT inconsistency" came up, resolved, and seq=89 succeded, traffic restored. at that time, seq=74, labanda-este got a TT update: [ 23161800] Deleting tdorado from global tt entry 44:d8:84:b0:d2:f5: tt removed by changes and (AFAIU) dropped traffic coming from labanda-oeste until labanda-oeste finally got the TT update and increased the ttvn to 129 does any of this make sense? I imagine a tcpdump would help, so i'll try getting one, but maybe this debug was enough to get an insight? As you can imagine, any further pointer will be greatly appreciated, I hope you're having a great week, ...and that i'm not ruining it as always :D Gui

2 4

[B.A.T.M.A.N.] [RFC 1/4] batman-adv: renamed batadv_dat_snoop_*_arp_* functions to batadv_dat_snoop_*_msg_*
by Mihail 25 Jun '13

25 Jun '13

From: "mihail.costea90(a)gmail.com" <mihail.costea90(a)gmail.com> Renamed snooping functions in order to suggest that they should work on more protocols than ARP. Signed-off-by: Mihail Costea <mihail.costea90(a)gmail.com> Signed-off-by: Stefan Popa <Stefan.A.Popa(a)intel.com> Reviewed-by: Stefan Popa <Stefan.A.Popa(a)intel.com> --- distributed-arp-table.c | 16 ++++++++-------- distributed-arp-table.h | 16 ++++++++-------- routing.c | 12 ++++++------ soft-interface.c | 6 +++--- 4 files changed, 25 insertions(+), 25 deletions(-) diff --git a/distributed-arp-table.c b/distributed-arp-table.c index af670d3..b2ca7e0 100644 --- a/distributed-arp-table.c +++ b/distributed-arp-table.c @@ -978,7 +978,7 @@ out: } /** - * batadv_dat_snoop_outgoing_arp_request - snoop the ARP request and try to + * batadv_dat_snoop_outgoing_msg_request - snoop the ARP request and try to * answer using DAT * @bat_priv: the bat priv with all the soft interface information * @skb: packet to check @@ -987,7 +987,7 @@ out: * otherwise. In case of a positive return value the message has to be enqueued * to permit the fallback. */ -bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv, +bool batadv_dat_snoop_outgoing_msg_request(struct batadv_priv *bat_priv, struct sk_buff *skb) { uint16_t type = 0; @@ -1060,7 +1060,7 @@ out: } /** - * batadv_dat_snoop_incoming_arp_request - snoop the ARP request and try to + * batadv_dat_snoop_incoming_msg_request - snoop the ARP request and try to * answer using the local DAT storage * @bat_priv: the bat priv with all the soft interface information * @skb: packet to check @@ -1068,7 +1068,7 @@ out: * * Returns true if the request has been answered, false otherwise. */ -bool batadv_dat_snoop_incoming_arp_request(struct batadv_priv *bat_priv, +bool batadv_dat_snoop_incoming_msg_request(struct batadv_priv *bat_priv, struct sk_buff *skb, int hdr_size) { uint16_t type; @@ -1130,11 +1130,11 @@ out: } /** - * batadv_dat_snoop_outgoing_arp_reply - snoop the ARP reply and fill the DHT + * batadv_dat_snoop_outgoing_msg_reply - snoop the ARP reply and fill the DHT * @bat_priv: the bat priv with all the soft interface information * @skb: packet to check */ -void batadv_dat_snoop_outgoing_arp_reply(struct batadv_priv *bat_priv, +void batadv_dat_snoop_outgoing_msg_reply(struct batadv_priv *bat_priv, struct sk_buff *skb) { uint16_t type; @@ -1167,13 +1167,13 @@ void batadv_dat_snoop_outgoing_arp_reply(struct batadv_priv *bat_priv, BATADV_P_DAT_DHT_PUT); } /** - * batadv_dat_snoop_incoming_arp_reply - snoop the ARP reply and fill the local + * batadv_dat_snoop_incoming_msg_reply - snoop the ARP reply and fill the local * DAT storage only * @bat_priv: the bat priv with all the soft interface information * @skb: packet to check * @hdr_size: size of the encapsulation header */ -bool batadv_dat_snoop_incoming_arp_reply(struct batadv_priv *bat_priv, +bool batadv_dat_snoop_incoming_msg_reply(struct batadv_priv *bat_priv, struct sk_buff *skb, int hdr_size) { uint16_t type; diff --git a/distributed-arp-table.h b/distributed-arp-table.h index 557bab9..28c062b 100644 --- a/distributed-arp-table.h +++ b/distributed-arp-table.h @@ -31,13 +31,13 @@ #define BATADV_DAT_DATA_MAX_LEN 16 void batadv_dat_status_update(struct net_device *net_dev); -bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv, +bool batadv_dat_snoop_outgoing_msg_request(struct batadv_priv *bat_priv, struct sk_buff *skb); -bool batadv_dat_snoop_incoming_arp_request(struct batadv_priv *bat_priv, +bool batadv_dat_snoop_incoming_msg_request(struct batadv_priv *bat_priv, struct sk_buff *skb, int hdr_size); -void batadv_dat_snoop_outgoing_arp_reply(struct batadv_priv *bat_priv, +void batadv_dat_snoop_outgoing_msg_reply(struct batadv_priv *bat_priv, struct sk_buff *skb); -bool batadv_dat_snoop_incoming_arp_reply(struct batadv_priv *bat_priv, +bool batadv_dat_snoop_incoming_msg_reply(struct batadv_priv *bat_priv, struct sk_buff *skb, int hdr_size); bool batadv_dat_drop_broadcast_packet(struct batadv_priv *bat_priv, struct batadv_forw_packet *forw_packet); @@ -105,28 +105,28 @@ static inline void batadv_dat_status_update(struct net_device *net_dev) } static inline bool -batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv, +batadv_dat_snoop_outgoing_msg_request(struct batadv_priv *bat_priv, struct sk_buff *skb) { return false; } static inline bool -batadv_dat_snoop_incoming_arp_request(struct batadv_priv *bat_priv, +batadv_dat_snoop_incoming_msg_request(struct batadv_priv *bat_priv, struct sk_buff *skb, int hdr_size) { return false; } static inline bool -batadv_dat_snoop_outgoing_arp_reply(struct batadv_priv *bat_priv, +batadv_dat_snoop_outgoing_msg_reply(struct batadv_priv *bat_priv, struct sk_buff *skb) { return false; } static inline bool -batadv_dat_snoop_incoming_arp_reply(struct batadv_priv *bat_priv, +batadv_dat_snoop_incoming_msg_reply(struct batadv_priv *bat_priv, struct sk_buff *skb, int hdr_size) { return false; diff --git a/routing.c b/routing.c index 7c372f1..1c43f55 100644 --- a/routing.c +++ b/routing.c @@ -967,10 +967,10 @@ int batadv_recv_unicast_packet(struct sk_buff *skb, orig_node = batadv_orig_hash_find(bat_priv, orig_addr); } - if (batadv_dat_snoop_incoming_arp_request(bat_priv, skb, + if (batadv_dat_snoop_incoming_msg_request(bat_priv, skb, hdr_size)) goto rx_success; - if (batadv_dat_snoop_incoming_arp_reply(bat_priv, skb, + if (batadv_dat_snoop_incoming_msg_reply(bat_priv, skb, hdr_size)) goto rx_success; @@ -1015,10 +1015,10 @@ int batadv_recv_ucast_frag_packet(struct sk_buff *skb, if (!new_skb) return NET_RX_SUCCESS; - if (batadv_dat_snoop_incoming_arp_request(bat_priv, new_skb, + if (batadv_dat_snoop_incoming_msg_request(bat_priv, new_skb, hdr_size)) goto rx_success; - if (batadv_dat_snoop_incoming_arp_reply(bat_priv, new_skb, + if (batadv_dat_snoop_incoming_msg_reply(bat_priv, new_skb, hdr_size)) goto rx_success; @@ -1159,9 +1159,9 @@ int batadv_recv_bcast_packet(struct sk_buff *skb, if (batadv_bla_is_backbone_gw(skb, orig_node, hdr_size)) goto out; - if (batadv_dat_snoop_incoming_arp_request(bat_priv, skb, hdr_size)) + if (batadv_dat_snoop_incoming_msg_request(bat_priv, skb, hdr_size)) goto rx_success; - if (batadv_dat_snoop_incoming_arp_reply(bat_priv, skb, hdr_size)) + if (batadv_dat_snoop_incoming_msg_reply(bat_priv, skb, hdr_size)) goto rx_success; /* broadcast for me */ diff --git a/soft-interface.c b/soft-interface.c index a6ab9e4..9e8fd44 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -232,7 +232,7 @@ static int batadv_interface_tx(struct sk_buff *skb, * packet, instead we first wait for DAT to try to retrieve the * correct ARP entry */ - if (batadv_dat_snoop_outgoing_arp_request(bat_priv, skb)) + if (batadv_dat_snoop_outgoing_msg_request(bat_priv, skb)) brd_delay = msecs_to_jiffies(ARP_REQ_DELAY); if (batadv_skb_head_push(skb, sizeof(*bcast_packet)) < 0) @@ -271,10 +271,10 @@ static int batadv_interface_tx(struct sk_buff *skb, goto dropped; } - if (batadv_dat_snoop_outgoing_arp_request(bat_priv, skb)) + if (batadv_dat_snoop_outgoing_msg_request(bat_priv, skb)) goto dropped; - batadv_dat_snoop_outgoing_arp_reply(bat_priv, skb); + batadv_dat_snoop_outgoing_msg_reply(bat_priv, skb); ret = batadv_unicast_send_skb(bat_priv, skb); if (ret != 0) -- 1.7.10.4

3 19

[B.A.T.M.A.N.] [PATCHv7 0/3] TT-VLAN: First patchset
by Antonio Quartulli 20 Jun '13

20 Jun '13

Hello folks, after version 4 I decided to split the bug TT-VLAN batch in several patchsets to make them easier to get digested by the maintainers. This is the third iteration of the first patchset. Differences from v6: - added patch introducing the per-VLAN ap_isolation attribute. It made no sense to have the new framework without a user. This patch introduces it. - removed the "novlan" sysfs folder. To avoid confusion and keep backward compatibility in a sane way, attributes corresponding to the untagged LAN are located in the root sysfs mesh folder (as it was done before). To implement this, some changes to the sysfs routines were needed (with respect to v6). - the array used to build the sysfs subfolder name now has a proper size instead of a too generic "256". Differences from v5 are: - added "untagged VLAN" removal routine. In the previous code the "untagged VLAN" was added but never removed. - use the correct vid argument when invoking batadv_tt_local_remove(). One invocation to the mentioned function was getting a vid that was not ORed with the HAS_TAG flag. However, such invocation has been enclosed into the new batadv_softif_destroy_vlan() function introduced to account the previous point. - bat_priv->softif_vlan_list is now an hlist instead of of a list. Thanks to Marek for his feedbacks. *** BLURB HERE *** Antonio Quartulli (3): batman-adv: add per VLAN interface attribute framework batman-adv: add sysfs framework for VLAN batman-adv: make the AP isolation attribute VLAN specific compat.c | 9 +++ compat.h | 24 ++++++++ hard-interface.c | 2 + main.c | 5 +- soft-interface.c | 171 ++++++++++++++++++++++++++++++++++++++++++++++++++- soft-interface.h | 4 ++ sysfs-class-net-mesh | 2 +- sysfs.c | 167 ++++++++++++++++++++++++++++++++++++++++++++++++- sysfs.h | 10 +++ translation-table.c | 21 +++++-- translation-table.h | 2 +- types.h | 23 +++++++ 12 files changed, 426 insertions(+), 14 deletions(-) -- 1.8.1.5

1 3

Re: [B.A.T.M.A.N.] [PATCHv5 1/2] batman-adv: add per VLAN interface attribute framework
by Marek Lindner 19 Jun '13

19 Jun '13

On Thursday, June 13, 2013 02:04:19 Antonio Quartulli wrote: > --- a/hard-interface.c > +++ b/hard-interface.c > @@ -643,6 +643,8 @@ static int batadv_hard_if_event(struct notifier_block > *this, > > if (batadv_softif_is_valid(net_dev) && event == NETDEV_REGISTER) { > batadv_sysfs_add_meshif(net_dev); > + bat_priv = netdev_priv(net_dev); > + batadv_softif_create_vlan(bat_priv, BATADV_NO_FLAGS); > return NOTIFY_DONE; > } When is this entry ever removed ? Did you try to rmmod the module with these patches enabled ? > + /* explicitly remove the associated TT local entry because it is marked > + * with the NOPURGE flag > + */ > + batadv_tt_local_remove(bat_priv, dev->dev_addr, vid, > + "vlan interface destroyed", false); Curious. In batadv_interface_add_vid() you force the BATADV_VLAN_HAS_TAG tag onto each batadv_tt_local_add() call but on removal we don't have the flag set. Are you certain that is correct ? > @@ -613,6 +632,8 @@ struct batadv_priv { > struct work_struct cleanup_work; > struct batadv_hard_iface __rcu *primary_if; /* rcu protected pointer */ > struct batadv_algo_ops *bat_algo_ops; > + struct list_head softif_vlan_list; > + spinlock_t softif_vlan_list_lock; /* protects softif_vlan_list */ > #ifdef CONFIG_BATMAN_ADV_BLA > struct batadv_priv_bla bla; > #endif Why do we need a full blown list ? Isn't hlist sufficient ? Cheers, Marek

1 0

[B.A.T.M.A.N.] [PATCHv6 0/2] TT-VLAN: First patchset
by Antonio Quartulli 19 Jun '13

19 Jun '13

Hello folks, after version 4 I decided to split the bug TT-VLAN batch in several patchsets to make them easier to get digested by the maintainers. This is another iteration of the first patchset. Differences from v5 are: - added "untagged VLAN" removal routine. In the previous code the "untagged VLAN" was added but never removed. - use the correct vid argument when invoking batadv_tt_local_remove(). One invocation to the mentioned function was getting a vid that was not ORed with the HAS_TAG flag. However, such invocation has been enclosed into the new batadv_softif_destroy_vlan() function introduced to account the previous point. - bat_priv->softif_vlan_list is now an hlist instead of of a list. Thanks to Marek for his feedbacks. Cheers, Antonio Quartulli (2): batman-adv: add per VLAN interface attribute framework batman-adv: add sysfs framework for VLAN compat.c | 9 +++ compat.h | 24 ++++++++ hard-interface.c | 2 + main.c | 5 +- soft-interface.c | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ soft-interface.h | 1 + sysfs.c | 142 +++++++++++++++++++++++++++++++++++++++++++++++ sysfs.h | 10 ++++ types.h | 21 +++++++ 9 files changed, 377 insertions(+), 3 deletions(-) -- 1.8.1.5

1 2

[B.A.T.M.A.N.] [PATCHv2] batman-adv: (style) fix for switched vid-ifiindex parameter order
by Linus Lüssing 19 Jun '13

19 Jun '13

batadv_tt_local_add() first takes the vid and then the interface index parameter. One of these calls had the order switched. However in this case it is not a functional, but just a style fix because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX. Introduced by 580d7919f19e4f73ccd79e82a532af2bdc638042 ("batman-adv: add the VLAN ID attribute to the TT entry") Acked-by: Antonio Quartulli <ordex(a)autistici.org> Signed-off-by: Linus Lüssing <linus.luessing(a)web.de> --- v2: Added "Introduced by..." to commit message main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.c b/main.c index f2f1137..a7ad6cb 100644 --- a/main.c +++ b/main.c @@ -128,7 +128,7 @@ int batadv_mesh_init(struct net_device *soft_iface) goto err; batadv_tt_local_add(soft_iface, soft_iface->dev_addr, - BATADV_NULL_IFINDEX, BATADV_NO_FLAGS); + BATADV_NO_FLAGS, BATADV_NULL_IFINDEX); ret = batadv_bla_init(bat_priv); if (ret < 0) -- 1.7.10.4

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N