B.A.T.M.A.N May 2014

b.a.t.m.a.n@lists.open-mesh.org

24 participants
58 discussions

Re: [B.A.T.M.A.N.] [PATCHv4 2/3] mac80211: export the expected throughput
by Antonio Quartulli 20 May '14

20 May '14

On 20/05/14 10:42, Krishnathiepan Rasanayagam wrote: > Dear all, > Sorry if I'm disturbing you. please let me know how to ask a question > and getting answer about batman-adv By writing a *new* email to the batman-adv mailing list *only* for example? :) In case you want to know more, I think that you can just visit this link: http://www.open-mesh.org/projects/open-mesh/wiki Cheers, -- Antonio Quartulli

1 0

[B.A.T.M.A.N.] [PATCHv3 0/6] Export the expected throughput towards a peer
by Antonio Quartulli 19 May '14

19 May '14

Changes since v2: - fix throughput computation in minstrel - squash minstrel patches Changes since v1: - add expected throughput nl80211 attribute to the GET_STATION reply message - the unit of the exported value has been changed to kbps - the way the exported value was computed in minstrel and minstrel_ht has been changed after having really understood what minstrel is doing (thanks Johannes!) - the number of arguments of the RC api have been reduced - allow the API result to be 0 if the underlying layer does not know what to report - squash ex patch 2/3/4 - use wiphy_to_rdev() where needed Antonio Quartulli (4): cfg80211: export expected throughput through get_station() cfg80211: export expected throughput via nl80211 (GET_STATION) mac80211: export the expected throughput cfg80211: implement cfg80211_get_station cfg80211 API include/net/cfg80211.h | 75 ++++++++++++++++++++++++-------------- include/net/mac80211.h | 7 ++++ include/uapi/linux/nl80211.h | 3 ++ net/mac80211/cfg.c | 19 ++++++++++ net/mac80211/driver-ops.h | 13 +++++++ net/mac80211/rc80211_minstrel.c | 12 ++++++ net/mac80211/rc80211_minstrel_ht.c | 17 +++++++++ net/mac80211/trace.h | 32 ++++++++++++++++ net/wireless/nl80211.c | 4 ++ net/wireless/util.c | 18 +++++++++ 10 files changed, 172 insertions(+), 28 deletions(-) -- 1.8.5.5

3 7

[B.A.T.M.A.N.] [PATCH] batctl: Avoid overoptimization of signal related check
by Sven Eckelmann 19 May '14

19 May '14

According to C99, it is not safe to use a simple char for checks because the compiler may optimizes it away when it only gets modified in a signal handler. It is also undefined when the signal is modifying an object with static storage duration not from type volatile sig_atomic_t. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- ping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ping.c b/ping.c index c52ad13..bc5184d 100644 --- a/ping.c +++ b/ping.c @@ -44,7 +44,7 @@ #include "debugfs.h" -char is_aborted = 0; +static volatile sig_atomic_t is_aborted = 0; static void ping_usage(void) -- 2.0.0.rc2

1 0

[B.A.T.M.A.N.] AR9331 Ad-hoc connection speed on OpenWRT Barrier Breaker
by Dirk van der Walt 19 May '14

19 May '14

Hi list, I'm sorry for posting a non-Batman-adv matter but I figured this place is the most likely to also have someone with the same equipment and the same goal. I have a few Dragino MS14's (same as the Village Telco MP2s) [Atheros AR9331] running the latest build of Barrier Breaker. Somehow the ad-hoc connection speed refuse to go above 1Mb/s. This have a ripple effect on the throughput of the batman-adv mesh. The same firmware build works fine with OM2Ps so I suspect it is probably chipset related. The same equipment works just fine with AA but I really would like to run the latest versions of the software. Anyone who experienced the same problem and (hopefully) have a fix to this issue? Kind regards

1 0

[B.A.T.M.A.N.] pull request: batman-adv 20140518
by Antonio Quartulli 19 May '14

19 May '14

Hello David, here you have our pull request for net-next. Unfortunately this time we have nothing exciting for you (as you may have seen we preferred to focus on bug fixing during the last period). Patch 1 and 2 slightly improve our codestyle in order to respect two new checks that have been recently introduced in checkpatch. Patch 3 is just increasing our internal version number. Please pull or let me know of any problem. Thanks a lot! Antonio The following changes since commit 33fcc5e05ea2b43ce0c6d356424ee5e25406f4c2: Merge branch 'cdc_ncm-coalesce' (2014-05-16 22:39:13 -0400) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem for you to fetch changes up to 871d3d9fdf1c2fb58927080c8e96edccb1fee010: batman-adv: Start new development cycle (2014-05-18 15:04:00 +0200) ---------------------------------------------------------------- Included changes: - fix codestyle to respect new checkpatch warnings - increase internal version number ---------------------------------------------------------------- Antonio Quartulli (2): batman-adv: add blank line between declarations and the rest of the code batman-adv: remove semi-colon after macro definition Simon Wunderlich (1): batman-adv: Start new development cycle net/batman-adv/debugfs.c | 13 +++++++++++-- net/batman-adv/distributed-arp-table.c | 1 + net/batman-adv/main.h | 2 +- net/batman-adv/network-coding.c | 1 + net/batman-adv/sysfs.c | 14 ++++++++++++-- 5 files changed, 26 insertions(+), 5 deletions(-)

2 4

[B.A.T.M.A.N.] [PATCHv2 0/6] Export the expected throughput towards a peer
by Antonio Quartulli 17 May '14

17 May '14

Changes since v1: - add expected throughput nl80211 attribute to the GET_STATION reply message - the unit of the exported value has been changed to kbps - the way the exported value was computed in minstrel and minstrel_ht has been changed after having really understood what minstrel is doing (thanks Johannes!) - the number of arguments of the RC api have been reduced - allow the API result to be 0 if the underlying layer does not know what to report - squash ex patch 2/3/4 - use wiphy_to_rdev() where needed Cheers, Antonio Quartulli (6): cfg80211: export expected throughput through get_station() mac80211: export the expected throughput mac80211: minstrel - implement get_expected_throughput() API mac80211: minstrel_ht - implement get_expected_throughput() API cfg80211: implement cfg80211_get_station cfg80211 API cfg80211: export expected throughput via nl80211 (GET_STATION) include/net/cfg80211.h | 75 ++++++++++++++++++++++++-------------- include/net/mac80211.h | 7 ++++ include/uapi/linux/nl80211.h | 3 ++ net/mac80211/cfg.c | 19 ++++++++++ net/mac80211/driver-ops.h | 13 +++++++ net/mac80211/rc80211_minstrel.c | 12 ++++++ net/mac80211/rc80211_minstrel_ht.c | 17 +++++++++ net/mac80211/trace.h | 32 ++++++++++++++++ net/wireless/nl80211.c | 4 ++ net/wireless/util.c | 18 +++++++++ 10 files changed, 172 insertions(+), 28 deletions(-) -- 1.8.5.5

1 6

[B.A.T.M.A.N.] pull request net: 20140515
by Antonio Quartulli 16 May '14

16 May '14

Hello David, our debugging campaign continues.. Here I have another small set of fixes intended for net/linux-3.15 and *stable* (please enqueue them). I know we already sent some fixes and we are running late in the rc cycle, but, as you can see from the stats below, the changes are very very small. Patch 1 prevents a NULL dereference in batadv_orig_hardif_seq_print_text() along the failure path. Patch 2 fixes a reference counting imbalance that gets triggered everytime the batman packet fragmentation mechanism is used; this imbalance prevents the netdev object held by batman-adv from being released on shutdown. Patch 3 fixes the reference counting for the orig_node objects in order to avoid any access after they have been free'd. Patch 4 fixes the TT local check in DAT (Distributed ARP Table) that is used to avoid sending (self-forged) ARP replies on behalf of other host in the LAN. Please pull or let me know of any problem! Thanks a lot, Antonio The following changes since commit e84d2f8d2ae33c8215429824e1ecf24cbca9645e: net: filter: s390: fix JIT address randomization (2014-05-14 16:10:16 -0400) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem for you to fetch changes up to cc2f33860cea0e48ebec096130bd0f7c4bf6e0bc: batman-adv: fix local TT check for outgoing arp requests in DAT (2014-05-15 20:23:47 +0200) ---------------------------------------------------------------- Include changes: - fix NULL dereference in batadv_orig_hardif_seq_print_text() - fix reference counting imbalance when using fragmentation - avoid access to orig_node objects after they have been free'd - fix local TT check for outgoing arp requests in DAT ---------------------------------------------------------------- Antonio Quartulli (3): batman-adv: fix reference counting imbalance while sending fragment batman-adv: increase orig refcount when storing ref in gw_node batman-adv: fix local TT check for outgoing arp requests in DAT Marek Lindner (1): batman-adv: fix indirect hard_iface NULL dereference net/batman-adv/distributed-arp-table.c | 3 +-- net/batman-adv/fragmentation.c | 11 ++++++++--- net/batman-adv/gateway_client.c | 11 +++++++++-- net/batman-adv/originator.c | 3 ++- 4 files changed, 20 insertions(+), 8 deletions(-)

2 7

[B.A.T.M.A.N.] [PATCH] batman-adv: remove semi-colon after macro definition
by Antonio Quartulli 15 May '14

15 May '14

Reported by checkpatch with the following warning: "WARNING: macros should not use a trailing semicolon" Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> --- debugfs.c | 4 ++-- sysfs.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/debugfs.c b/debugfs.c index 99f2ba0..a12e25e 100644 --- a/debugfs.c +++ b/debugfs.c @@ -342,7 +342,7 @@ struct batadv_debuginfo batadv_debuginfo_##_name = { \ .llseek = seq_lseek, \ .release = single_release, \ } \ -}; +} /* the following attributes are general and therefore they will be directly * placed in the BATADV_DEBUGFS_SUBDIR subdirectory of debugfs @@ -404,7 +404,7 @@ struct batadv_debuginfo batadv_hardif_debuginfo_##_name = { \ .llseek = seq_lseek, \ .release = single_release, \ }, \ -}; +} static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO, batadv_originators_hardif_open); diff --git a/sysfs.c b/sysfs.c index f51b484..fc47baa 100644 --- a/sysfs.c +++ b/sysfs.c @@ -108,7 +108,7 @@ struct batadv_attribute batadv_attr_vlan_##_name = { \ .mode = _mode }, \ .show = _show, \ .store = _store, \ -}; +} /* Use this, if you have customized show and store functions */ #define BATADV_ATTR(_name, _mode, _show, _store) \ @@ -117,7 +117,7 @@ struct batadv_attribute batadv_attr_##_name = { \ .mode = _mode }, \ .show = _show, \ .store = _store, \ -}; +} #define BATADV_ATTR_SIF_STORE_BOOL(_name, _post_func) \ ssize_t batadv_store_##_name(struct kobject *kobj, \ -- 1.8.5.5

2 1

[B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: fix alignment
by Antonio Quartulli 15 May '14

15 May '14

Introduced by 9729d2085c0fa4398eb1ee518b0097866dfdcd77 ("batman-adv: fix TT VLAN inconsistency on VLAN re-add") Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> --- soft-interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/soft-interface.c b/soft-interface.c index 5a9dc2f..82804e7 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -594,8 +594,8 @@ static int batadv_interface_add_vid(struct net_device *dev, __be16 proto, * exists, because the entry was deleted by kill_vid() */ batadv_tt_local_add(bat_priv->soft_iface, - bat_priv->soft_iface->dev_addr, vid, - BATADV_NULL_IFINDEX, BATADV_NO_MARK); + bat_priv->soft_iface->dev_addr, vid, + BATADV_NULL_IFINDEX, BATADV_NO_MARK); return 0; } -- 1.8.5.5

2 3

[B.A.T.M.A.N.] [PATCH 1/7] cfg80211: export expected throughput through get_station()
by Antonio Quartulli 14 May '14

14 May '14

From: Antonio Quartulli <antonio(a)open-mesh.com> Users may need information about the expected throughput towards a given peer computed by the RC algorithm. Export such value in Mbps/100 through the get_station() API. This unit has been chosen because it is the same of the throughput returned by MinstrelHT. This information will be useful to the batman-adv module which will use it for its new metric computation. Signed-off-by: Antonio Quartulli <antonio(a)open-mesh.com> --- Changes since the RFC: - Change all the station_info_flags to use BIT() - Properly comment about the unit used by the throughput value - added new ieee80211_ops.get_expected_throughput() API (to support drivers having HW RC) - improved doc about new cfg80211_get_station() function - minor cleanups include/net/cfg80211.h | 63 ++++++++++++++++++++++++++++---------------------- 1 file changed, 35 insertions(+), 28 deletions(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 9496fe5..d4b85f7 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -862,36 +862,38 @@ int cfg80211_check_station_change(struct wiphy *wiphy, * @STATION_INFO_NONPEER_PM: @nonpeer_pm filled * @STATION_INFO_CHAIN_SIGNAL: @chain_signal filled * @STATION_INFO_CHAIN_SIGNAL_AVG: @chain_signal_avg filled + * @STATION_INFO_EXPECTED_THROUGHPUT: @expected_throughput filled */ enum station_info_flags { - STATION_INFO_INACTIVE_TIME = 1<<0, - STATION_INFO_RX_BYTES = 1<<1, - STATION_INFO_TX_BYTES = 1<<2, - STATION_INFO_LLID = 1<<3, - STATION_INFO_PLID = 1<<4, - STATION_INFO_PLINK_STATE = 1<<5, - STATION_INFO_SIGNAL = 1<<6, - STATION_INFO_TX_BITRATE = 1<<7, - STATION_INFO_RX_PACKETS = 1<<8, - STATION_INFO_TX_PACKETS = 1<<9, - STATION_INFO_TX_RETRIES = 1<<10, - STATION_INFO_TX_FAILED = 1<<11, - STATION_INFO_RX_DROP_MISC = 1<<12, - STATION_INFO_SIGNAL_AVG = 1<<13, - STATION_INFO_RX_BITRATE = 1<<14, - STATION_INFO_BSS_PARAM = 1<<15, - STATION_INFO_CONNECTED_TIME = 1<<16, - STATION_INFO_ASSOC_REQ_IES = 1<<17, - STATION_INFO_STA_FLAGS = 1<<18, - STATION_INFO_BEACON_LOSS_COUNT = 1<<19, - STATION_INFO_T_OFFSET = 1<<20, - STATION_INFO_LOCAL_PM = 1<<21, - STATION_INFO_PEER_PM = 1<<22, - STATION_INFO_NONPEER_PM = 1<<23, - STATION_INFO_RX_BYTES64 = 1<<24, - STATION_INFO_TX_BYTES64 = 1<<25, - STATION_INFO_CHAIN_SIGNAL = 1<<26, - STATION_INFO_CHAIN_SIGNAL_AVG = 1<<27, + STATION_INFO_INACTIVE_TIME = BIT(0), + STATION_INFO_RX_BYTES = BIT(1), + STATION_INFO_TX_BYTES = BIT(2), + STATION_INFO_LLID = BIT(3), + STATION_INFO_PLID = BIT(4), + STATION_INFO_PLINK_STATE = BIT(5), + STATION_INFO_SIGNAL = BIT(6), + STATION_INFO_TX_BITRATE = BIT(7), + STATION_INFO_RX_PACKETS = BIT(8), + STATION_INFO_TX_PACKETS = BIT(9), + STATION_INFO_TX_RETRIES = BIT(10), + STATION_INFO_TX_FAILED = BIT(11), + STATION_INFO_RX_DROP_MISC = BIT(12), + STATION_INFO_SIGNAL_AVG = BIT(13), + STATION_INFO_RX_BITRATE = BIT(14), + STATION_INFO_BSS_PARAM = BIT(15), + STATION_INFO_CONNECTED_TIME = BIT(16), + STATION_INFO_ASSOC_REQ_IES = BIT(17), + STATION_INFO_STA_FLAGS = BIT(18), + STATION_INFO_BEACON_LOSS_COUNT = BIT(19), + STATION_INFO_T_OFFSET = BIT(20), + STATION_INFO_LOCAL_PM = BIT(21), + STATION_INFO_PEER_PM = BIT(22), + STATION_INFO_NONPEER_PM = BIT(23), + STATION_INFO_RX_BYTES64 = BIT(24), + STATION_INFO_TX_BYTES64 = BIT(25), + STATION_INFO_CHAIN_SIGNAL = BIT(26), + STATION_INFO_CHAIN_SIGNAL_AVG = BIT(27), + STATION_INFO_EXPECTED_THROUGHPUT = BIT(28), }; /** @@ -1013,6 +1015,9 @@ struct sta_bss_parameters { * @local_pm: local mesh STA power save mode * @peer_pm: peer mesh STA power save mode * @nonpeer_pm: non-peer mesh STA power save mode + * @expected_throughput: expected throughput in Mbps/100 reported by the RC + * algorithm towards this station. The unit of this value has been chosen + * because it is the same of the throughput returned by MinstrelHT */ struct station_info { u32 filled; @@ -1051,6 +1056,8 @@ struct station_info { enum nl80211_mesh_power_mode peer_pm; enum nl80211_mesh_power_mode nonpeer_pm; + u32 expected_throughput; + /* * Note: Add a new enum station_info_flags value for each new field and * use it to check which fields are initialized. -- 1.8.3.2

5 19

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N May 2014