B.A.T.M.A.N May 2014

b.a.t.m.a.n@lists.open-mesh.org

24 participants
58 discussions

[B.A.T.M.A.N.] [PATCH] batadv-vis: Avoid file handler leak after failed realloc
by Sven Eckelmann 27 May '14

27 May '14

The read_file function opens the file and thus has to close the filehandler after an realloc error. This was forgotten in the fix 0ad384e11ed039d4c3025a7eaf19fe6bcfd41acf ("batadv-vis: Avoid memory leak after failed realloc"). Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- vis/vis.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vis/vis.c b/vis/vis.c index f429942..55c2dad 100644 --- a/vis/vis.c +++ b/vis/vis.c @@ -56,6 +56,7 @@ static char *read_file(char *fname) buf_tmp = realloc(buf, size + 4097); if (!buf_tmp) { free(buf); + fclose(fp); return NULL; } -- 2.0.0.rc4

2 1

[B.A.T.M.A.N.] [PATCH 01/10] batadv-vis: Avoid memory leak after failed realloc
by Sven Eckelmann 27 May '14

27 May '14

realloc doesn't free the original buffer when the reallocation failed. An abort of read_file without free'ing the buffer would leak it. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- vis/vis.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/vis/vis.c b/vis/vis.c index 7a8e780..b51fede 100644 --- a/vis/vis.c +++ b/vis/vis.c @@ -40,7 +40,7 @@ static char *read_file(char *fname) { FILE *fp; - char *buf = NULL; + char *buf = NULL, *buf_tmp; size_t size, ret; fp = fopen(fname, "r"); @@ -51,10 +51,13 @@ static char *read_file(char *fname) size = 0; while (!feof(fp)) { - buf = realloc(buf, size + 4097); - if (!buf) + buf_tmp = realloc(buf, size + 4097); + if (!buf_tmp) { + free(buf); return NULL; + } + buf = buf_tmp; ret = fread(buf + size, 1, 4096, fp); size += ret; } -- 2.0.0.rc2

3 11

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Restrict movement of batman interfaces between netns.
by Daniel Ehlers 26 May '14

26 May '14

We shall _not_ move composed interfaces between network namespaces. Should fix issue #179, though I only tested it in a pure netns enviroment and not in a more complex lxc setup. Signed-off-by: Daniel Ehlers <danielehlers(a)mindeye.net> --- soft-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/soft-interface.c b/soft-interface.c index e783afb..dcaf02b 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -909,7 +909,7 @@ static void batadv_softif_init_early(struct net_device *dev) dev->netdev_ops = &batadv_netdev_ops; dev->destructor = batadv_softif_free; - dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER; + dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_NETNS_LOCAL; dev->tx_queue_len = 0; /* can't call min_mtu, because the needed variables -- 1.9.2

1 0

[B.A.T.M.A.N.] bridge: multicast snooping patches / exports
by Linus Lüssing 24 May '14

24 May '14

Hi, The first patch is simply a cosmetic patch. So far I (and maybe others too?) have been regularly confusing these two structs, therefore I'd suggest renaming them and therefore making the follow-up patches easier to understand and nicer to fit in. The second patch fixes a minor issue, but probably not worth for stable. On the other hand the first two patches are also preparations for the third and fourth patch: These two patches are exporting functionality needed to marry the bridge multicast snooping with the batman-adv multicast optimizations recently added for the 3.15 kernel, allowing to use these optimzations in common setups having a bridge on top of e.g. bat0, too. So far these bridged setups would fall back to simple flooding through the batman-adv mesh network for any multicast packet entering bat0. More information about the batman-adv multicast optimizations currently implemented can be found here: http://www.open-mesh.org/projects/batman-adv/wiki/Basic-multicast-optimizat… The integration on the batman-adv side could afterwards look like this, for instance: http://git.open-mesh.org/batman-adv.git/commitdiff/576b59dd3e34737c702e548b… Cheers, Linus

2 6

Re: [B.A.T.M.A.N.] BATMAN-ADV emulated in DCE module of ns-3
by Krishnathiepan Rasanayagam 23 May '14

23 May '14

hello, I dint get the meaning of the message. did you developed a framework of batman-adv on ns-3? or something else? regards, krishna On Tue, May 20, 2014 at 10:10 PM, Krishnathiepan Rasanayagam <r.krishnathiepan(a)gmail.com> wrote: > hello, > I dint get the meaning of the message. did you developed a framework of > batman-adv on ns-3? or something else? > > regards, > krishna -- Best regards, Krishna.

4 4

[B.A.T.M.A.N.] Adding security on BATMAN-ADV
by Krishnathiepan Rasanayagam 22 May '14

22 May '14

Hello all, I'm researching on batman-adv about adding security on node authentication. I'm trying to integrate threshold cryptography in BATMAN-ADV. Does anyone have worked in that area? or similar researches have been done on it? Please let me know. -- Best regards, Krishna.

2 6

[B.A.T.M.A.N.] BATMAN-ADV security
by Krishnathiepan Rasanayagam 21 May '14

21 May '14

Does batman-adv has any special features regarding security . in terms of authentication or encryption etc -- Best regards, Krishna.

1 0

[B.A.T.M.A.N.] BATMAN-ADV emulated in DCE module of ns-3
by seb gmail 20 May '14

20 May '14

Hello, I have developed a module to emulate BATMAN-ADV and Batctl with the framework of ns-3 called DCE. With DCE, you can emulate a Linux TCP/IP stack and run existing implementation of userpsace and kernelspace network protocols or applications. We continue our effort to push this module to be available for the next version of DCE. Best regards, Sébastien Bindel

1 0

[B.A.T.M.A.N.] [PATCHv4 0/3] Export the expected throughput towards a peer
by Antonio Quartulli 20 May '14

20 May '14

Changes since v3: - squash patch 1 and 2 - in 3/3 change mac_addr from u8 * to const u8 * (both in the new cfg80211_get_station and in the already existing rdev_get_station) - add type and unit for NL80211_STA_EXPECTED_THROUGHPUT Changes since v2: - fix throughput computation in minstrel - squash minstrel patches Changes since v1: - add expected throughput nl80211 attribute to the GET_STATION reply message - the unit of the exported value has been changed to kbps - the way the exported value was computed in minstrel and minstrel_ht has been changed after having really understood what minstrel is doing (thanks Johannes!) - the number of arguments of the RC api have been reduced - allow the API result to be 0 if the underlying layer does not know what to report - squash ex patch 2/3/4 - use wiphy_to_rdev() where needed Antonio Quartulli (3): cfg80211: export expected throughput through get_station() mac80211: export the expected throughput cfg80211: implement cfg80211_get_station cfg80211 API include/net/cfg80211.h | 75 ++++++++++++++++++++++++-------------- include/net/mac80211.h | 7 ++++ include/uapi/linux/nl80211.h | 3 ++ net/mac80211/cfg.c | 19 ++++++++++ net/mac80211/driver-ops.h | 13 +++++++ net/mac80211/rc80211_minstrel.c | 12 ++++++ net/mac80211/rc80211_minstrel_ht.c | 17 +++++++++ net/mac80211/trace.h | 32 ++++++++++++++++ net/wireless/nl80211.c | 4 ++ net/wireless/rdev-ops.h | 2 +- net/wireless/util.c | 18 +++++++++ 11 files changed, 173 insertions(+), 29 deletions(-) -- 1.8.5.5

2 4

Re: [B.A.T.M.A.N.] security in batman-adv
by Antonio Quartulli 20 May '14

20 May '14

Hi Krishnathiepan, On 20/05/14 10:58, Krishnathiepan Rasanayagam wrote: > thanks a lot for replying. > I'm researching on adding security to batman-adv. > is there any specific group or people working on that? > > Reagards, > krishna > > please start a new email thread every time you want to talk about a new topic otherwise people may not see your message at all. I am not aware of any specific group working on security in batman-adv at the moment. Personally I always try to find a solution to this problem on a different layer other than batman-adv (e.g. by using IBSS-RSN on the wifi layer). However it depends on what your specific goal is. I think that "security on batman-adv" is quite a broad topic that you may need to clarify. Cheers, -- Antonio Quartulli

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N May 2014