B.A.T.M.A.N August 2013

b.a.t.m.a.n@lists.open-mesh.org

12 participants
45 discussions

[B.A.T.M.A.N.] pull request: batman-adv 2013-08-28
by Antonio Quartulli 29 Aug '13

29 Aug '13

Hello David, here is a small pull request intended for net-next/linux-3.12. In this batch you have two really minor things (code rearranging and version increment) and two behavioural changes: 1) the 'protocol' field of outgoing SKBs is now set according to the type of the payload that batman-adv is going to encapsulate; 2) a uevent is now sent when a node exits the "GW client" mode. This is done in order to tell userspace that a remote "GW server" is not available anymore. Please pull or let me know of any problem! Thanks a lot, Antonio The following changes since commit 5b2941b18dc5f60a5c14a5c15693f9c58b0dd922: Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jesse/openvswitch (2013-08-27 22:11:18 -0400) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem for you to fetch changes up to c6eaa3f067d6f9fa55fd9645e93ed79411bebdaf: batman-adv: send GW_DEL event when the gw client mode is deselected (2013-08-28 11:33:00 +0200) ---------------------------------------------------------------- Included changes: - set the protocol field in the skb structure according to the encapsulated payload - make the gateway component send a uevent in case of "gw client mode" de-selection - increment version number - minor code rearrangement ---------------------------------------------------------------- Antonio Quartulli (2): batman-adv: move enum definition at the top of the file batman-adv: send GW_DEL event when the gw client mode is deselected Simon Wunderlich (2): batman-adv: set skb priority according to content batman-adv: Start new development cycle net/batman-adv/bat_iv_ogm.c | 32 +++++++++++---------- net/batman-adv/gateway_client.c | 27 ++++++++++++++++++ net/batman-adv/gateway_client.h | 1 + net/batman-adv/icmp_socket.c | 1 + net/batman-adv/main.c | 58 ++++++++++++++++++++++++++++++++++++++ net/batman-adv/main.h | 3 +- net/batman-adv/routing.c | 20 ++++++++++++- net/batman-adv/send.c | 1 - net/batman-adv/soft-interface.c | 2 ++ net/batman-adv/sysfs.c | 4 +++ net/batman-adv/translation-table.c | 5 ++++ net/batman-adv/unicast.c | 2 ++ net/batman-adv/vis.c | 2 ++ 13 files changed, 140 insertions(+), 18 deletions(-)

2 5

[B.A.T.M.A.N.] [PATCHv4 0/9] Improving the routing protocol abstraction
by Antonio Quartulli 28 Aug '13

28 Aug '13

Hello list, This is the *fourth* version of the "improved routing abstraction" patchset. Thanks for the feedback so far! (Message below is the same as v3) This patchset is introducing a new set of routing API functions meant to improve the routing protocol abstraction. Also the orig_node and the neigh_node structure have been heavily modified in order to split their generic members from those which are metric related. (the rest of the message is what you already had in the RFC cover letter). This changes have been written while developing batman V. The latter helped me in understanding what batman iv and v have in common and what not. The main problem was the metric: the two protocols use different metric domains and different semantics. Therefore all the functions handling/printing the metric needed to be generalised and rearranged to let the protocols decide what to do. Another issue was the way routing protocols handle the orig and neigh node structures. Also these two have been changed and some small APIs have been provided as well. Moreover, after Simon's RFC about the new multi-interface optimisation, we saw the need for a better abstraction so that mechanisms like that could easily be re-used by new algorithms (like batman v) with little effort. ****** API functions changed from v3 ****** + neigh comparison related: - bat_neigh_cmp - bat_neigh_is_equiv_or_better + orig_node related: - bat_orig_print: print the originator table - bat_orig_free - bat_orig_add_if - bat_orig_del_if Changes from v1: - removed bat_metric_compare() API. This is not really useful since we are assuming all the metrics are in the same domain (uint32_t) so a simple comparison is more than enough. Changes from v2: - initialise best_metric in the neighbor purging routine - don't optimise ntohs. Will be done in a separate patch Changes from v3: - bat_metric_is_equiv_or_better is now called bat_neigh_is_equiv_or_better and now directly takes two neigh_node as parameters. This allows to do not export the metric at all: all the metric magic is handled inside the function. - bat_metric_compare has been re-introduced again with the bat_neigh_cmp name. As for bat_neigh_is_equiv_or_better it also takes two neigh_node as parameters and the metric is handled inside only. - as result of the two changes above bat_metric_get has been removed. The metric is always handled inside the routing protocol code and there is no need to export it to the rest of the module. This simplified the code and reduced code duplication. (Thanks Marek for the hint!) Cheers, Antonio Quartulli (9): batman-adv: make struct batadv_neigh_node algorithm agnostic batman-adv: make struct batadv_orig_node algorithm agnostic batman-adv: add bat_orig_print API function batman-adv: add bat_neigh_cmp API function batman-adv: add bat_neigh_is_equiv_or_better API function batman-adv: adapt bonding to use the new API functions batman-adv: adapt the neighbor purging routine to use the new API functions batman-adv: provide orig_node routing API batman-adv: adapt the TT component to use the new API functions bat_iv_ogm.c | 398 ++++++++++++++++++++++++++++++++++++++++++++-------- gateway_client.c | 16 +-- main.c | 4 +- main.h | 6 + network-coding.c | 8 +- originator.c | 248 ++++++++------------------------ originator.h | 5 +- routing.c | 42 ++++-- routing.h | 3 +- translation-table.c | 35 +++-- types.h | 91 ++++++++---- 11 files changed, 546 insertions(+), 310 deletions(-) -- 1.8.1.5

1 10

[B.A.T.M.A.N.] [PATCHv3 0/9] Improving the routing protocol abstraction
by Antonio Quartulli 27 Aug '13

27 Aug '13

Hello list, This is the third version of the "improved routing abstraction" patchset. Thanks for the feedback so far! This patchset is introducing a new set of routing API functions meant to improve the routing protocol abstraction. Also the orig_node and the neigh_node structure have been heavily modified in order to split their generic members from those which are metric related. (the rest of the message is what you already had in the RFC cover letter). This changes have been written while developing batman V. The latter helped me in understanding what batman iv and v have in common and what not. The main problem was the metric: the two protocols use different metric domains and different semantics. Therefore all the functions handling/printing the metric needed to be generalised and rearranged to let the protocols decide what to do. Another issue was the way routing protocols handle the orig and neigh node structures. Also these two have been changed and some small APIs have been provided as well. Moreover, after Simon's RFC about the new multi-interface optimisation, we saw the need for a better abstraction so that mechanisms like that could easily be re-used by new algorithms (like batman v) with little effort. This is the second version of this RFC where I introduced some changes to the names of some functions and some other minor changes discussed in the previous RFC thread. + metric related: - bat_metric_get - bat_metric_is_equiv_or_better + orig_node related: - bat_orig_print: print the originator table - bat_orig_free - bat_orig_add_if - bat_orig_del_if Changes from v1: - removed bat_metric_compare() API. This is not really useful since we are assuming all the metrics are in the same domain (uint32_t) so a simple comparison is more than enough. Changes from v2: - initialise best_metric in the neighbor purging routine - don't optimise ntohs. Will be done in a separate patch Cheers, *** BLURB HERE *** Antonio Quartulli (9): batman-adv: make struct batadv_neigh_node algorithm agnostic batman-adv: make struct batadv_orig_node algorithm agnostic batman-adv: add bat_orig_print function API batman-adv: add bat_metric_get API function batman-adv: add bat_metric_is_equiv_or_better API function batman-adv: adapt bonding to use the new API functions batman-adv: adapt the neighbor purging routine to use the new API functions batman-adv: provide orig_node routing API batman-adv: adapt the TT component to use the new API functions bat_iv_ogm.c | 344 +++++++++++++++++++++++++++++++++++++++++++--------- gateway_client.c | 16 +-- main.c | 4 +- main.h | 6 + network-coding.c | 8 +- originator.c | 231 ++++++++--------------------------- originator.h | 5 +- routing.c | 26 ++-- routing.h | 3 +- translation-table.c | 31 +++-- types.h | 83 ++++++++----- 11 files changed, 454 insertions(+), 303 deletions(-) -- 1.8.1.5

2 23

[B.A.T.M.A.N.] [RFC] batctl update to use the sys framework for VLAN
by Marco Dalla Torre 27 Aug '13

27 Aug '13

Hello list, The following is a small patch proposal to allow the batctl tool to use the sys framework for VLAN recently added to batman-adv, so that commands can be applied in a per VLAN fashion at user discretion. Comments and suggestions are extremely welcome. If no directory entry corresponding to the user-selected device is found at the standard location for non VLAN interfaces (/sys/class/net/${base_device}), 'batctl' now looks into directory: /sys/devices/virtual/net/${base_device}/mesh/vlan${vid} Where: -${base_device}: the batman device on top of which the VLAN is sitting -${device}: the device interface for the VLAN, -${vid}: the identifier assigned to the VLAN. Information on VLAN devices (base device, vid) is acquired by parsing /proc/net/vlan/${device}. If the user-selected command is not supported by the VLAN, an appropriate error is shown. --- functions.c | 7 ++++++- sys.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/functions.c b/functions.c index cc05a48..973b6f8 100644 --- a/functions.c +++ b/functions.c @@ -135,8 +135,13 @@ static void file_open_problem_dbg(char *dir, char *fname, char *full_path) fprintf(stderr, "Error - the folder '/sys/' was not found on the system\n"); fprintf(stderr, "Please make sure that the sys filesystem is properly mounted\n"); return; + } else if (strstr(dir, "/sys/devices/virtual/")) { + fprintf(stderr, "The selected feature '%s' is not supported for vlans\n", fname); + return; } - } + } + + if (!file_exists(module_ver_path)) { fprintf(stderr, "Error - batman-adv module has not been loaded\n"); diff --git a/sys.c b/sys.c index b1d7ea8..799f275 100644 --- a/sys.c +++ b/sys.c @@ -371,6 +371,39 @@ static void settings_usage(int setting) fprintf(stderr, " \t -h print this help\n"); } +int get_basedev_vid(char *mesh_iface, char **base_dev, unsigned short *vid) +{ + char *vdev; + char line[100]; + const char path[]="/proc/net/vlan/"; + int size=sizeof(path)+sizeof(mesh_iface); + FILE *fp = NULL; + + char *fpath=malloc(size); + strcpy(fpath, path); + /* prepare path file path: /proc/net/vlan/$mesh_iface*/ + strcat(fpath, mesh_iface); + + fp = fopen(fpath, "r"); + if (fp == NULL) { + return 1; + } + + if (fscanf(fp, "%ms %*s %hu %*s %*d %*s %*d", &vdev, vid)==0) { + return 0; + } + while (fgets(line, sizeof(line), fp) != NULL) { + if (sscanf(line, "Device: %ms", base_dev) == 1) { + break; + } + } + // handle base device not found case + if (*base_dev==NULL) { + return 0; + } + return 1; +} + int handle_sys_setting(char *mesh_iface, int setting, int argc, char **argv) { int optchar, res = EXIT_FAILURE; @@ -392,6 +425,27 @@ int handle_sys_setting(char *mesh_iface, int setting, int argc, char **argv) snprintf(path_buff, PATH_BUFF_LEN, SYS_BATIF_PATH_FMT, mesh_iface); path_buff[PATH_BUFF_LEN - 1] = '\0'; + if (access(path_buff, F_OK) != 0) { + if (errno == ENOENT) { + // does not exist, no lan interface: check vlan + unsigned short vid=0; + char *base_dev=NULL; + if (get_basedev_vid(mesh_iface, &base_dev, &vid) == 1) { + free(path_buff); + char sys_vlan_path[]="/sys/devices/virtual/net/%s/mesh/vlan%d/"; + int size=sizeof(sys_vlan_path)+sizeof(base_dev); + path_buff=malloc(size); + sprintf(path_buff, sys_vlan_path, base_dev, vid); + } + } + if (errno == ENOTDIR) { + // not a directory, something wrong here + fprintf(stderr, "Error - expected directory at '%s'\n", + path_buff); + return EXIT_FAILURE; + } + } + if (argc == 1) { res = read_file(path_buff, (char *)batctl_settings[setting].sysfs_name, NO_FLAGS, 0, 0, 0); -- 1.8.3.2

1 1

[B.A.T.M.A.N.] [PATCH 1/3] batman-adv: print the VID in the dat_cache output
by Antonio Quartulli 25 Aug '13

25 Aug '13

Now that DAT is vlan aware, it should also print the VID along with the MAC address of each cached entry. Introduced by: 3e26722bc9f248ec4316749fc1957365c0fa5e4b ("batman-adv: make the Distributed ARP Table vlan aware") Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- distributed-arp-table.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/distributed-arp-table.c b/distributed-arp-table.c index df65f8c..c825d76 100644 --- a/distributed-arp-table.c +++ b/distributed-arp-table.c @@ -761,8 +761,8 @@ int batadv_dat_cache_seq_print_text(struct seq_file *seq, void *offset) goto out; seq_printf(seq, "Distributed ARP Table (%s):\n", net_dev->name); - seq_printf(seq, " %-7s %-13s %5s\n", "IPv4", "MAC", - "last-seen"); + seq_printf(seq, " %-7s %-9s %4s %11s\n", "IPv4", + "MAC", "VID", "last-seen"); for (i = 0; i < hash->size; i++) { head = &hash->table[i]; @@ -775,8 +775,9 @@ int batadv_dat_cache_seq_print_text(struct seq_file *seq, void *offset) last_seen_msecs = last_seen_msecs % 60000; last_seen_secs = last_seen_msecs / 1000; - seq_printf(seq, " * %15pI4 %14pM %6i:%02i\n", + seq_printf(seq, " * %15pI4 %14pM %4i %6i:%02i\n", &dat_entry->ip, dat_entry->mac_addr, + BATADV_PRINT_VID(dat_entry->vid), last_seen_mins, last_seen_secs); } rcu_read_unlock(); -- 1.8.1.5

2 7

[B.A.T.M.A.N.] pull request net: 2013-08-17b
by Antonio Quartulli 20 Aug '13

20 Aug '13

Hello David, here is the correct pull request for net/linux-3.11. As described earlier this patchset contains a change which properly ends a seq_read cycle and another change that takes care of aborting TX operations if the skb preparation should faile. Please pull or let me know if there is any problem. (about merge of net into net-next?) Thanks a lot! Antonio The following changes since commit 0f7dd1aa8f959216f1faa71513b9d3c1a9065e5a: Merge tag 'clk-fixes-for-linus' of git://git.linaro.org/people/mturquette/linux (2013-08-16 10:00:18 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem for you to fetch changes up to d823c33c0717cffea2dc73180ef780bf626908c7: batman-adv: check return type of unicast packet preparations (2013-08-17 12:52:27 +0200) ---------------------------------------------------------------- Included change: - Add a missing skb_abort_seq_read() to properly close seq_read session - Check if the skb has been correctly prepared before going on ---------------------------------------------------------------- Antonio Quartulli (1): batman-adv: properly end seq_read session Linus Lüssing (1): batman-adv: check return type of unicast packet preparations net/batman-adv/main.c | 1 + net/batman-adv/unicast.c | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-)

2 5

[B.A.T.M.A.N.] pull request net: 2013-08-17
by Antonio Quartulli 20 Aug '13

20 Aug '13

Hello David, here you have another very small fix intended for net/linux-3.11. Tha patch properly closes a seq_read session by adding an invocation to skb_abort_seq_read(). Please pull or let me know if there is any problem. Also, when do you plan to merge net into net-next? I have a couple of changes for net-next which is better to apply after the merge. Thanks a lot, Antonio The following changes since commit 0f7dd1aa8f959216f1faa71513b9d3c1a9065e5a: Merge tag 'clk-fixes-for-linus' of git://git.linaro.org/people/mturquette/linux (2013-08-16 10:00:18 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem for you to fetch changes up to 9863634227f1390737104f93c0748e6a7b52020e: batman-adv: properly end seq_read session (2013-08-17 12:23:37 +0200) ---------------------------------------------------------------- Included change: - Add a missing skb_abort_seq_read() to properly close seq_read session ---------------------------------------------------------------- Antonio Quartulli (1): batman-adv: properly end seq_read session net/batman-adv/main.c | 1 + 1 file changed, 1 insertion(+)n-Reply-To: Hello David, here you have another very small fix for net/linux-3.11. Tha patch properly closes a seq_read session by adding an invocation to skb_abort_seq_read(). Please pull or let me know if there is any problem. Also, when do you plan to merge net into net-next? I have a couple of changes for net-next which is better to apply after the merge. Thanks a lot, Antonio The following changes since commit 0f7dd1aa8f959216f1faa71513b9d3c1a9065e5a: Merge tag 'clk-fixes-for-linus' of git://git.linaro.org/people/mturquette/linux (2013-08-16 10:00:18 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem for you to fetch changes up to 9863634227f1390737104f93c0748e6a7b52020e: batman-adv: properly end seq_read session (2013-08-17 12:23:37 +0200) ---------------------------------------------------------------- Included change: - Add a missing skb_abort_seq_read() to properly close seq_read session ---------------------------------------------------------------- Antonio Quartulli (1): batman-adv: properly end seq_read session net/batman-adv/main.c | 1 + 1 file changed, 1 insertion(+)

2 3

[B.A.T.M.A.N.] Regression in VLAN sysfs patches
by Simon Wunderlich 20 Aug '13

20 Aug '13

Hello, it seems there is an regression in the VLAN sysfs patches. I've tracked the issue a little bit, it seems to be somewhere between: 6f27447 Antonio Quartulli batman-adv: fix vlan compat code (broken) ... (few more patches i can't test because vlan compat is broken) cc14598 Linus Lüssing batman-adv: (style) fix for switched vid-ifiindex parameter order (works) The regression is probably in some of Antonios VLAN/sysfs patches. It can be triggered by calling: ifconfig bat0 down ; ifconfig bat0 up Which will lead to a WARNING [1]. This can be reproduced every time I call it. Note that I've not explicitly configured a VLAN on bat0, this is automatically created/added. I'm using a fairly old OpenWRT revision (29637) on kernel 2.6.39.4 here in virtual machines. Cheers, Simon [1] [ 39.317111] 8021q: adding VLAN 0 to HW filter on device bat0 [ 39.322208] ------------[ cut here ]------------ [ 39.324213] WARNING: at fs/sysfs/dir.c:455 sysfs_add_one+0x8b/0xb0() [ 39.325378] sysfs: cannot create duplicate filename '/devices/virtual/net/bat0/mesh/vlan0' [ 39.326955] Modules linked in: virtio_net batman_adv ebt_snat ebt_dnat ebt_arpreply ebt_ip ebt_arp ebt_redirect ebt_mark ebt_vlan ebt_stp ebt_pkttype ebt_mark_m ebt_limit ebt_among ebt_802_3 ebtable_nat ebtable_filter ebtable_broute nf_nat_irc nf_conntrack_irc nf_nat_ftp nf_conntrack_ftp xt_string xt_layer7 ipt_MASQUERADE iptable_nat nf_nat xt_CT xt_conntrack xt_NOTRACK iptable_raw xt_state nf_conntrack_ipv4 nf_defrag_ipv4 nf_conntrack ipt_REJECT xt_TCPMSS ipt_LOG xt_comment xt_multiport xt_mac xt_limit iptable_mangle iptable_filter ts_fsm ts_bm ts_kmp libcrc32c ipv6 virtio_rng crc32c crypto_hash crypto_algapi [ 39.340649] Pid: 1166, comm: ifconfig Not tainted 2.6.39.4 #180 [ 39.342140] Call Trace: [ 39.342686] [<c10d557b>] ? sysfs_add_one+0x8b/0xb0 [ 39.343899] [<c10284af>] warn_slowpath_common+0x5f/0x80 [ 39.345480] [<c10d557b>] ? sysfs_add_one+0x8b/0xb0 [ 39.347153] [<c102854e>] warn_slowpath_fmt+0x2e/0x30 [ 39.348504] [<c10d557b>] sysfs_add_one+0x8b/0xb0 [ 39.349761] [<c10d55fb>] create_dir+0x5b/0x90 [ 39.351197] [<c10d56ee>] sysfs_create_dir+0x8e/0xa0 [ 39.352558] [<c11386c5>] kobject_add_internal+0xc5/0x1d0 [ 39.353945] [<c1138ad5>] kobject_add+0x75/0x90 [ 39.355177] [<c1138c86>] kobject_create_and_add+0x36/0x70 [ 39.356550] [<c4b8293e>] batadv_sysfs_add_vlan+0x62/0x216 [batman_adv] [ 39.358314] [<c108ce09>] ? __kmalloc+0x119/0x130 [ 39.359554] [<c4b8051d>] batadv_softif_create_vlan+0xb6/0xa25 [batman_adv] [ 39.361571] [<c4b806b9>] batadv_softif_create_vlan+0x252/0xa25 [batman_adv] [ 39.363355] [<c4b80672>] batadv_softif_create_vlan+0x20b/0xa25 [batman_adv] [ 39.365227] [<c127f925>] vlan_device_event+0xc5/0x510 [ 39.366578] [<c126f39c>] ? packet_notifier+0x19c/0x1b0 [ 39.368010] [<c126f200>] ? packet_dev_mc+0xd0/0xd0 [ 39.369239] [<c10425a0>] notifier_call_chain+0x30/0x60 [ 39.370600] [<c104266a>] raw_notifier_call_chain+0x1a/0x20 [ 39.372089] [<c120d04e>] call_netdevice_notifiers+0x4e/0x60 [ 39.373468] [<c121b855>] ? rtmsg_ifinfo+0xb5/0xe0 [ 39.374713] [<c121055e>] __dev_notify_flags+0x2e/0x70 [ 39.376240] [<c12105e3>] dev_change_flags+0x43/0x60 [ 39.377803] [<c1258665>] devinet_ioctl+0x285/0x670 [ 39.378985] [<c1210ec5>] ? dev_ioctl+0x665/0x6c0 [ 39.379871] [<c1210be5>] ? dev_ioctl+0x385/0x6c0 [ 39.380797] [<c12597f2>] inet_ioctl+0x72/0xa0 [ 39.381689] [<c11fea88>] sock_ioctl+0x218/0x250 [ 39.382603] [<c11fe870>] ? sock_fasync+0x80/0x80 [ 39.383550] [<c109e09e>] do_vfs_ioctl+0x4ee/0x530 [ 39.384488] [<c108df28>] ? fd_install+0x48/0x60 [ 39.385606] [<c11ff738>] ? sys_socket+0x48/0x70 [ 39.386665] [<c120054a>] ? sys_socketcall+0x6a/0x270 [ 39.387666] [<c109e119>] sys_ioctl+0x39/0x60 [ 39.388541] [<c128d325>] syscall_call+0x7/0xb [ 39.389417] ---[ end trace c59b34f09c69e69f ]--- [ 39.390323] kobject_add_internal failed for vlan0 with -EEXIST, don't try to register things with the same name in the same directory. [ 39.392757] Pid: 1166, comm: ifconfig Tainted: G W 2.6.39.4 #180 [ 39.394234] Call Trace: [ 39.395176] [<c128a7fc>] ? printk+0x18/0x1c [ 39.396080] [<c11387a8>] kobject_add_internal+0x1a8/0x1d0 [ 39.397123] [<c1138ad5>] kobject_add+0x75/0x90 [ 39.398037] [<c1138c86>] kobject_create_and_add+0x36/0x70 [ 39.399241] [<c4b8293e>] batadv_sysfs_add_vlan+0x62/0x216 [batman_adv] [ 39.400455] [<c108ce09>] ? __kmalloc+0x119/0x130 [ 39.401382] [<c4b8051d>] batadv_softif_create_vlan+0xb6/0xa25 [batman_adv] [ 39.402634] [<c4b806b9>] batadv_softif_create_vlan+0x252/0xa25 [batman_adv] [ 39.404345] [<c4b80672>] batadv_softif_create_vlan+0x20b/0xa25 [batman_adv] [ 39.405675] [<c127f925>] vlan_device_event+0xc5/0x510 [ 39.406671] [<c126f39c>] ? packet_notifier+0x19c/0x1b0 [ 39.407821] [<c126f200>] ? packet_dev_mc+0xd0/0xd0 [ 39.408836] [<c10425a0>] notifier_call_chain+0x30/0x60 [ 39.410132] [<c104266a>] raw_notifier_call_chain+0x1a/0x20 [ 39.411492] [<c120d04e>] call_netdevice_notifiers+0x4e/0x60 [ 39.412554] [<c121b855>] ? rtmsg_ifinfo+0xb5/0xe0 [ 39.413485] [<c121055e>] __dev_notify_flags+0x2e/0x70 [ 39.414473] [<c12105e3>] dev_change_flags+0x43/0x60 [ 39.415752] [<c1258665>] devinet_ioctl+0x285/0x670 [ 39.416716] [<c1210ec5>] ? dev_ioctl+0x665/0x6c0 [ 39.417651] [<c1210be5>] ? dev_ioctl+0x385/0x6c0 [ 39.418691] [<c12597f2>] inet_ioctl+0x72/0xa0 [ 39.419606] [<c11fea88>] sock_ioctl+0x218/0x250 [ 39.420642] [<c11fe870>] ? sock_fasync+0x80/0x80 [ 39.421544] [<c109e09e>] do_vfs_ioctl+0x4ee/0x530 [ 39.422456] [<c108df28>] ? fd_install+0x48/0x60 [ 39.423348] [<c11ff738>] ? sys_socket+0x48/0x70 [ 39.424641] [<c120054a>] ? sys_socketcall+0x6a/0x270 [ 39.426055] [<c109e119>] sys_ioctl+0x39/0x60 [ 39.426982] [<c128d325>] syscall_call+0x7/0xb [ 39.427944] kobject_create_and_add: kobject_add error: -17 [ 39.428999] batman_adv: bat0: Can't add sysfs directory: bat0/vlan0

3 6

[B.A.T.M.A.N.] Basic Multicast Optimizations
by Linus Lüssing 19 Aug '13

19 Aug '13

This is the ninth revision of the basic multicast optimization patches. It fixes a regression in Patch 3/5, introduced in v8 while rebasing: An atomic_dec() for the orig_list_count got lost. Cheers, Linus

2 6

[B.A.T.M.A.N.] pull request net: 2013-08-19
by Antonio Quartulli 19 Aug '13

19 Aug '13

Hi David, after a not so quiet weekend, here is my small pull request intended for net/linux-3.11. This is a fix that aims to block TX operations in case of skb preparation failure. Please pull or let me know of any problem. Thanks, Antonio p.s. is net going to be merged into net-next one of these days? I need it in order to send a couple of changes to net-next. The following changes since commit 0f7dd1aa8f959216f1faa71513b9d3c1a9065e5a: Merge tag 'clk-fixes-for-linus' of git://git.linaro.org/people/mturquette/linux (2013-08-16 10:00:18 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem for you to fetch changes up to 50fa3b31f4700deb1a860fa1a04016b889765323: batman-adv: check return type of unicast packet preparations (2013-08-17 20:02:32 +0200) ---------------------------------------------------------------- Included change: - Check if the skb has been correctly prepared before going on ---------------------------------------------------------------- Linus Lüssing (1): batman-adv: check return type of unicast packet preparations net/batman-adv/unicast.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)

1 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N August 2013