Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Prefix non-static functions with batadv_

On Fri, May 11, 2012 at 08:29:46PM +0200, Sven Eckelmann wrote:

batman-adv can be compiled as part of the kernel instead of an module. In that case the linker will see all non-static symbols of batman-adv and all other non-static symbols of the kernel. This could lead to symbol collisions. A prefix for the batman-adv symbols that defines their private namespace avoids such a problem.

Hi Sven

Two probably dumb questions...

1) Did you use objdump to check for any symbols you missed?

2) A quick look at the patch suggests its changing function names. Are there any variables with global scope?

Thanks Andrew