Re: [B.A.T.M.A.N.] [PATCH 2/4] batman: don't bother flipping ->tt_crc

On Wed, Apr 18, 2012 at 07:10:58 +0100, Al Viro wrote:

@@ -722,7 +721,7 @@ update_tt: tt_update_orig(bat_priv, orig_node, tt_buff, batman_ogm_packet->tt_num_changes, batman_ogm_packet->ttvn,

• 	       batman_ogm_packet->tt_crc);
  

• 	       ntohs(batman_ogm_packet->tt_crc));
  

If we don't need to flip tt_crc, wy are you introducing ntohs here? Am I overlooking something?

@@ -969,7 +968,7 @@ static void bat_iv_ogm_process(const struct ethhdr *ethhdr, ethhdr->h_source, if_incoming->net_dev->name, if_incoming->net_dev->dev_addr, batman_ogm_packet->orig, batman_ogm_packet->prev_sender, batman_ogm_packet->seqno,

• batman_ogm_packet->ttvn, batman_ogm_packet->tt_crc,
  

• batman_ogm_packet->ttvn, ntohs(batman_ogm_packet->tt_crc),
  

  batman_ogm_packet->tt_num_changes, batman_ogm_packet->tq,

The same here..I am not understanding..

Thank you for your patches!

Cheers,