On Mon, Apr 09, 2012 at 12:37:51AM +0200, Simon Wunderlich wrote:
Hey Antonio,
thanks a lot for fixing my style bugs!!
There is a little bug in one (one line doubled), otherwise:
Reviewed-by: Simon Wunderlich siwu@hrz.tu-chemnitz.de
Cheers, Simon
Hi guys,
I'm sorry, but I didn't make this "double line" fix in the last pull-request. So, please commit this patches as they are. We need another clean up patch that will be sent within the next pull-request.
Cheers,
On Sat, Apr 07, 2012 at 11:06:06PM +0200, Antonio Quartulli wrote:
** this patches are for batman-ad/next ***
After my first pull request, David S. Miller hardly suggested me to fix some problems that I am going to summarise here. Please respect such suggestions in your next patches:
- Multi-line comments must end with */ on a new line:
/* ..
- ..
*/
- if we use #ifdef in our headers to redefine some functions depending on the
fact that we are compiling a component or not, we must use static inline functions doing nothing with the correct parameters instead of simple "foo(...)". In this way we can allow the compiler to check for the types and the number of arguments:
Instead of:
#define bla_init(...) (1)
we must do:
static inline bla_init(struct bat_priv *bat_priv) { return 1; }
Other than David's complaining I also get a suggestion from Bernd Petrovitsch about the type of stp_addr (it should be "static const uint8_t []" instead of "uint8_t []" only). I applied such change in patch 2/3.
Cheers,